Spec URL: http://mtasaka.fedorapeople.org/Review_request/xfe-related/fox.spec SRPM URL: http://mtasaka.fedorapeople.org/Review_request/xfe-related/fox-1.6.49-1.fc.src.rpm Description: FOX is a C++ based Toolkit for developing Graphical User Interfaces easily and effectively. It offers a wide, and growing, collection of Controls, and provides state of the art facilities such as drag and drop, selection, as well as OpenGL widgets for 3D graphical manipulation. FOX also implements icons, images, and user-convenience features such as status line help, and tooltips. Tooltips may even be used for 3D objects. Fedora Account System Username: mtasaka Koji scratch build: F-20: http://koji.fedoraproject.org/koji/taskinfo?taskID=5316774 F-19: http://koji.fedoraproject.org/koji/taskinfo?taskID=5316772 F-18: http://koji.fedoraproject.org/koji/taskinfo?taskID=5316773
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ISSUES ================= - Is there a reason you've got LGPLv3+ instead of LGPLv2+ , and GPLv3+ instead of GPLv2+? Because of libraries it links against? - I don't think filter.pl should get installed/packaged. - Have you contacted upstream about fixing the FSF address? - Looks like a number of linking issues in rpmlint output. libCHART probably need to link against libFOX, not link against a bunch of other libraries. - Ask upstream why libFOX calls exit(). ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Fully versioned dependency in subpackages, if present. [x]: Package complies to the Packaging Guidelines [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2 or later) (with incorrect FSF address)", "LGPL (v2.1 or later) (with incorrect FSF address)", "GPL (v2 or later)", "Unknown or generated". 128 files have unknown license. Detailed output of licensecheck in /export/home/orion/redhat/fox-1.6.49/958149-fox/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: update-desktop-database is invoked when required Note: desktop file(s) in fox-utils [x]: Useful -debuginfo package or justification otherwise. [x]: Large documentation must go in a -doc subpackage. Note: Documentation size is 51200 bytes in 6 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install if there is such a file. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Perl: [-]: Package contains the mandatory BuildRequires and Requires:. Note: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) missing? ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: fox-1.6.49-1.fc20.x86_64.rpm fox-devel-1.6.49-1.fc20.x86_64.rpm fox-utils-1.6.49-1.fc20.x86_64.rpm fox-doc-1.6.49-1.fc20.noarch.rpm fox.x86_64: W: spelling-error %description -l en_US tooltips -> tool tips, tool-tips, tiptops fox.x86_64: W: spelling-error %description -l en_US Tooltips -> Tool tips, Tool-tips, Tiptops fox.x86_64: W: shared-lib-calls-exit /usr/lib64/libFOX-1.6.so.0.0.49 exit.5 fox.x86_64: E: incorrect-fsf-address /usr/share/doc/fox-1.6.49/LICENSE fox-devel.x86_64: W: no-manual-page-for-binary fox-config fox-devel.x86_64: W: no-manual-page-for-binary fox-config.x86_64 4 packages and 0 specfiles checked; 1 errors, 5 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint fox-devel fox fox-doc fox-utils fox-devel.x86_64: W: no-manual-page-for-binary fox-config fox-devel.x86_64: W: no-manual-page-for-binary fox-config.x86_64 fox.x86_64: W: spelling-error %description -l en_US tooltips -> tool tips, tool-tips, tiptops fox.x86_64: W: spelling-error %description -l en_US Tooltips -> Tool tips, Tool-tips, Tiptops fox.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libFOX-1.6.so.0.0.49 /lib64/libXrender.so.1 fox.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libFOX-1.6.so.0.0.49 /lib64/libXfixes.so.3 fox.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libFOX-1.6.so.0.0.49 /lib64/libXi.so.6 fox.x86_64: W: shared-lib-calls-exit /usr/lib64/libFOX-1.6.so.0.0.49 exit.5 fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 typeinfo for FX::FXComposite fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXObject::onDefault(FX::FXObject*, unsigned int, void*) fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXObject::tryHandle(FX::FXObject*, unsigned int, void*) fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXComposite::destroy() fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXWindow::resize(int, int) fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXWindow::doesOverrideRedirect() const fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXComposite::getDefaultWidth() fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXComposite::getDefaultHeight() fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXWindow::getWidthForHeight(int) fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXWindow::getHeightForWidth(int) fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXWindow::canFocus() const fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXWindow::setFocus() fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXWindow::killFocus() fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXWindow::changeFocus(FX::FXWindow*) fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXWindow::setDefault(unsigned char) fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXWindow::enable() fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXWindow::disable() fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXWindow::attach(unsigned long) fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXWindow::setShape(FX::FXRegion const&) fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXWindow::setShape(FX::FXBitmap*) fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXWindow::setShape(FX::FXIcon*) fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXWindow::clearShape() fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXWindow::raise() fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXWindow::lower() fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXWindow::move(int, int) fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXWindow::position(int, int, int, int) fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXWindow::recalc() fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXWindow::reparent(FX::FXWindow*, FX::FXWindow*) fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXWindow::show() fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXWindow::hide() fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXComposite::isComposite() const fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXWindow::dropEnable() fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXWindow::dropDisable() fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXWindow::contains(int, int) const fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXWindow::setBackColor(unsigned int) fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXWindow::doesSaveUnder() const fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXWindow::tr(char const*, char const*) const fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXJPGImage::mimeType fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXMetaClass::~FXMetaClass() fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXComposite::metaClass fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXWindow::colorTypeName fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 vtable for FX::FXMemoryStream fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXGIFImage::mimeType fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXTIFImage::mimeType fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXPNGImage::mimeType fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXWindow::textTypeName fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXBMPImage::mimeType fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXWindow::textType fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXWindow::colorType fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXMetaClass::search(unsigned int) const fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXDCWindow::drawImage(FX::FXImage const*, int, int) fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXComposite::FXComposite(FX::FXComposite*, unsigned int, int, int, int, int) fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXApp::registerDragType(FX::FXString const&) const fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXComposite::~FXComposite() fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXComposite::handle(FX::FXObject*, unsigned int, void*) fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXDCWindow::setStipple(FX::FXStipplePattern, int, int) fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXComposite::create() fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXWindow::load(FX::FXStream&) fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXMemoryStream::close() fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXImage::FXImage(FX::FXApp*, unsigned int const*, unsigned int, int, int) fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXMetaClass::FXMetaClass(char const*, FX::FXObject* (*)(), FX::FXMetaClass const*, void const*, unsigned int, unsigned int) fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::operator<<(FX::FXStream&, FX::FXString const&) fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXDCWindow::setBackground(unsigned int) fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXStream::loadObject(FX::FXObject*&) fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXWindow::setDNDData(FX::FXDNDOrigin, unsigned long, unsigned char*, unsigned int) const fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::fxsavePNG(FX::FXStream&, unsigned int const*, int, int) fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXDCWindow::setForeground(unsigned int) fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXWindow::FXWindow() fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXStream::saveObject(FX::FXObject const*) fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::fxsaveGIF(FX::FXStream&, unsigned int const*, int, int, bool) fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::operator>>(FX::FXStream&, FX::FXString&) fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXDCWindow::setTile(FX::FXImage*, int, int) fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::fxtrace(unsigned int, char const*, ...) fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXMemoryStream::FXMemoryStream(FX::FXObject const*) fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXWindow::onQueryHelp(FX::FXObject*, unsigned int, void*) fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXDCWindow::setFillStyle(FX::FXFillStyle) fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXMemoryStream::takeBuffer(unsigned char*&, unsigned long&) fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXComposite::detach() fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXString::FXString(char const*) fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXDCWindow::FXDCWindow(FX::FXDrawable*) fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXDCWindow::~FXDCWindow() fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXWindow::onClipboardRequest(FX::FXObject*, unsigned int, void*) fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXWindow::save(FX::FXStream&) const fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXWindow::onQueryTip(FX::FXObject*, unsigned int, void*) fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXMemoryStream::open(FX::FXStreamDirection, unsigned char*) fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXComposite::layout() fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXDCWindow::fillRectangle(int, int, int, int) fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXString::FXString() fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::fxsaveBMP(FX::FXStream&, unsigned int const*, int, int) fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::fxsaveTIF(FX::FXStream&, unsigned int const*, int, int, unsigned short) fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXDCWindow::FXDCWindow(FX::FXDrawable*, FX::FXEvent*) fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXString::operator=(FX::FXString const&) fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::fxsaveJPG(FX::FXStream&, unsigned int const*, int, int, int) fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXString::~FXString() fox.x86_64: W: undefined-non-weak-symbol /usr/lib64/libCHART-1.6.so.0.0.49 FX::FXStream::~FXStream() fox.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libCHART-1.6.so.0.0.49 /lib64/libX11.so.6 fox.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libCHART-1.6.so.0.0.49 /lib64/libXext.so.6 fox.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libCHART-1.6.so.0.0.49 /lib64/libfreetype.so.6 fox.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libCHART-1.6.so.0.0.49 /lib64/libXft.so.2 fox.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libCHART-1.6.so.0.0.49 /lib64/libXcursor.so.1 fox.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libCHART-1.6.so.0.0.49 /lib64/libXrender.so.1 fox.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libCHART-1.6.so.0.0.49 /lib64/libXrandr.so.2 fox.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libCHART-1.6.so.0.0.49 /lib64/libXfixes.so.3 fox.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libCHART-1.6.so.0.0.49 /lib64/libXi.so.6 fox.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libCHART-1.6.so.0.0.49 /lib64/libdl.so.2 fox.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libCHART-1.6.so.0.0.49 /lib64/libpthread.so.0 fox.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libCHART-1.6.so.0.0.49 /lib64/librt.so.1 fox.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libCHART-1.6.so.0.0.49 /lib64/libjpeg.so.62 fox.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libCHART-1.6.so.0.0.49 /lib64/libpng15.so.15 fox.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libCHART-1.6.so.0.0.49 /lib64/libtiff.so.5 fox.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libCHART-1.6.so.0.0.49 /lib64/libz.so.1 fox.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libCHART-1.6.so.0.0.49 /lib64/libbz2.so.1 fox.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libCHART-1.6.so.0.0.49 /lib64/libGLU.so.1 fox.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libCHART-1.6.so.0.0.49 /lib64/libGL.so.1 fox.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libCHART-1.6.so.0.0.49 /lib64/libm.so.6 fox.x86_64: E: incorrect-fsf-address /usr/share/doc/fox-1.6.49/LICENSE 4 packages and 0 specfiles checked; 1 errors, 123 warnings. # echo 'rpmlint-done:' Requires -------- fox-devel (rpmlib, GLIBC filtered): /bin/sh /usr/bin/pkg-config fox libCHART-1.6.so.0()(64bit) libFOX-1.6.so.0()(64bit) fox (rpmlib, GLIBC filtered): /sbin/ldconfig libGL.so.1()(64bit) libGLU.so.1()(64bit) libX11.so.6()(64bit) libXcursor.so.1()(64bit) libXext.so.6()(64bit) libXfixes.so.3()(64bit) libXft.so.2()(64bit) libXi.so.6()(64bit) libXrandr.so.2()(64bit) libXrender.so.1()(64bit) libbz2.so.1()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libfreetype.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libjpeg.so.62()(64bit) libjpeg.so.62(LIBJPEG_6.2)(64bit) libm.so.6()(64bit) libpng15.so.15()(64bit) libpng15.so.15(PNG15_0)(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libtiff.so.5()(64bit) libtiff.so.5(LIBTIFF_4.0)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) fox-doc (rpmlib, GLIBC filtered): fox fox-utils (rpmlib, GLIBC filtered): /bin/sh fox libFOX-1.6.so.0()(64bit) libGL.so.1()(64bit) libGLU.so.1()(64bit) libX11.so.6()(64bit) libXcursor.so.1()(64bit) libXext.so.6()(64bit) libXfixes.so.3()(64bit) libXft.so.2()(64bit) libXi.so.6()(64bit) libXrandr.so.2()(64bit) libXrender.so.1()(64bit) libbz2.so.1()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libfreetype.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libjpeg.so.62()(64bit) libm.so.6()(64bit) libpng15.so.15()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libtiff.so.5()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) Provides -------- fox-devel: fox-devel fox-devel(x86-64) pkgconfig(fox) fox: fox fox(x86-64) libCHART-1.6.so.0()(64bit) libFOX-1.6.so.0()(64bit) fox-doc: fox-doc fox-utils: fox-utils fox-utils(x86-64) Source checksums ---------------- http://ftp.fox-toolkit.org/pub/fox-1.6.49.tar.gz : CHECKSUM(SHA256) this package : 3679ecd23064958259fbef5898aabb048d63b2dcb796de1d8801fe0b51e5a90e CHECKSUM(SHA256) upstream package : 3679ecd23064958259fbef5898aabb048d63b2dcb796de1d8801fe0b51e5a90e Generated by fedora-review 0.4.1 (b2e211f) last change: 2013-04-29 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -b 958149 -m fedora-rawhide-x86_64
Thank you for initial comments: (In reply to comment 1:) > - Is there a reason you've got LGPLv3+ instead of LGPLv2+ , > and GPLv3+ instead of GPLv2+? Because of libraries it links against? Because I firstly packaged development version 1.7.38, then later I decided to use stable version 1.6.49 instead (to use stabilized API/ABI on Fedora)... Changed. > - I don't think filter.pl should get installed/packaged. I removed this. >- Have you contacted upstream about fixing the FSF address? Actually this is already fixed in 1.7.x. > - Looks like a number of linking issues in rpmlint output. > libCHART probably need to link against libFOX, > not link against a bunch of other libraries. libCHART.so is modified not to contain non-weak undefined symbols. rpmlint still complains about unused libraries' dependency, however linking against libFOX.so will create these anyway and this should not be a blocker. > - Ask upstream why libFOX calls exit(). This should not be a blocker. Anyway libFOX.so may exit() at the very initial setup process (mainly when parsing command line option), not after such setup is done, and seems safe. Also there are some other toolkit-like libraries calling exit() in some situation (line GLib).
http://mtasaka.fedorapeople.org/Review_request/xfe-related/fox.spec http://mtasaka.fedorapeople.org/Review_request/xfe-related/fox-1.6.49-2.fc.src.rpm * Fri May 3 2013 Mamoru TASAKA <mtasaka> - 1.6.49-2 - Fix libCHART.so linkage to erase undefined non-weak symbols - Fix license tag for stable tarball - Modify files entry for documentation
Okay, not a blocker, but the unused-direct-shlib-dependency warnings should get fixed at some point. Please bring it up with upstream if they are not resolved in their master branch. Approved.
Okay, thank you. New Package SCM Request ======================= Package Name: fox Short Description: C++ based Toolkit for developing Graphical User Interfaces Owners: mtasaka Branches: f19 f18 f17 InitialCC:
Git done (by process-git-requests).
Closed on all branches, push requested on stable branches, closing. Thank you for review and git procedure.