Bug 958398
| Summary: | Detect rule name duplication in Guvnor | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Retired] JBoss BRMS Platform 6 | Reporter: | Toshiya Kobayashi <tkobayas> | ||||||||
| Component: | Business Central | Assignee: | manstis | ||||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Jiri Locker <jlocker> | ||||||||
| Severity: | medium | Docs Contact: | |||||||||
| Priority: | high | ||||||||||
| Version: | 5.x.x | CC: | brms-jira, etirelli, jlocker, jschatte, kverlaen, manstis, paradhya, pzapataf, rrajasek | ||||||||
| Target Milestone: | ER1 | ||||||||||
| Target Release: | 6.0.2 | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | 862163 | Environment: | |||||||||
| Last Closed: | 2014-08-06 19:54:48 UTC | Type: | Feature Request | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Toshiya Kobayashi
2013-05-01 10:27:37 UTC
same here... need to be tackled for 6.0 Pedro, can you check if someone in your group can tackle this one? The core engine has a configuration option to define the severity of rule name duplication build result message: ERROR, WARN, INFO. Maybe all that is missing here is to properly catch that message and present to the user in the UI? When two rules are created with the same name, either in two separate DRL files or in the same, upon building & deploying the project an error message is raised and shown in the project editor problem window. Generally works, but name collision with template rules is not detected (not always). It is only detected when saving the rule template and there exists a rule with the same name. But when you create a rule with name colliding with rule template generated rule, the collision is not detected. And it is not detected when building the package either. Created attachment 854893 [details]
drl rule source saved
Created attachment 854897 [details]
guided rule template source saved
Created attachment 854899 [details]
project build
I've tried both cases you mention, in a very recent build (23/01/2014) of version 6 (NOT 5.x.x as is mentioned in the bug specs!). First case: existing template and saving a drl file containing a rule with the same name as one of the template rules. When saving the drl file an error message is displayed in the problems window (see screenshot "drl rule source saved"), as well as when building the project (see screenshot project_build). Second case: existing drl file with one rule and saving a rule template file containing a set of rules, one of which has the same name as the drl rule. When saving the template file an error message is displayed in the problems window (see screenshot "guided rule template source saved"), as well as when building the project. Sorry, forgot to add: Did you check this in the 6 version? if so, could you please recheck this in a recent build and if the problem persists give a more detailed scenario to reproduce the defect? This issue has been in needinfo since my last comment, since we have not been able to reproduce it in any way. Looking at, what I assume to be, the remaining issue. I created a Template which generated a rule called "t1_0". I then created a DRL file for a rule with the same name. The "Problems Panel" correctly showed "Duplicate rule name: t1_0". The same happened when I created a Guided Rule called "t1_0". Michael Anstis <michael.anstis> updated the status of jira GUVNOR-1948 to Resolved Described collisions verified manually. |