Bug 958489 - Koan should not be using python-virtinst code
Summary: Koan should not be using python-virtinst code
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: cobbler
Version: 19
Hardware: All
OS: Linux
urgent
urgent
Target Milestone: ---
Assignee: James C.
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-05-01 16:16 UTC by Orion Poplawski
Modified: 2013-08-09 01:29 UTC (History)
13 users (show)

Fixed In Version: cobbler-2.4.0-beta5.fc19.1
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 958499 (view as bug list)
Environment:
Last Closed: 2013-05-14 04:47:03 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Orion Poplawski 2013-05-01 16:16:33 UTC
Description of problem:

Error: Package: koan-2.4.0-beta3.fc19.2.noarch (@rawhide/19)
           Requires: python-virtinst
           Removing: python-virtinst-0.600.4-1.fc20.noarch (@rawhide)
               python-virtinst = 0.600.4-1.fc20
           Obsoleted By: virt-install-0.10.0-0.1.gitd3f9bc8e.fc20.noarch (rawhide)
               Not found

Version-Release number of selected component (if applicable):
0.10.0-0.1.gitd3f9bc8e

Comment 1 Orion Poplawski 2013-05-01 16:18:16 UTC
You also probably should be using versioned provides/obsoletes:

Provides: oldpackagename = $provEVR
Obsoletes: oldpackagename < $obsEVR

Comment 2 Daniel Berrangé 2013-05-01 16:24:34 UTC
This explicitly did *not* define Provides, since the APIs formerly provided in python-virtinst are no longer considered public & the APIs will be changed at will. No 3rd party app should be using the python-virtinst APIs.

Thus koan needs to be updated to not use these, now private, APIs. The simplest option for koan is probably to just copy the few files it needs from the previous python-virtinst release into its own source tree.

Comment 3 Orion Poplawski 2013-05-01 16:30:44 UTC
Daniel - Looks like koji-vm also requires python-virtinst.

# repoquery --whatrequires python-virtinst
koan-0:2.4.0-beta3.fc19.2.noarch
koji-vm-0:1.8.0-1.fc20.noarch

Comment 4 Daniel Berrangé 2013-05-01 16:34:10 UTC
Created bug 958499 for koji

Comment 5 Orion Poplawski 2013-05-06 21:15:42 UTC
This is breaking F19 installs for me.

Comment 6 Cole Robinson 2013-05-09 17:33:16 UTC
F19 koan does all it's virt bits by calling out to virt-install these days and has done so for a year, the Requires bit just needs to be changed. I mailed cobbler-owner asking if they mind me pushing a build but if I don't hear back by Monday I'll just do it.

Comment 7 Fedora Update System 2013-05-10 00:41:16 UTC
cobbler-2.4.0-beta5.fc19.1 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/cobbler-2.4.0-beta5.fc19.1

Comment 8 Fedora Update System 2013-05-10 15:32:45 UTC
Package cobbler-2.4.0-beta5.fc19.1:
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing cobbler-2.4.0-beta5.fc19.1'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-7849/cobbler-2.4.0-beta5.fc19.1
then log in and leave karma (feedback).

Comment 9 Fedora Update System 2013-05-14 04:47:03 UTC
cobbler-2.4.0-beta5.fc19.1 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Matt Sellers 2013-07-26 16:40:35 UTC
I believe this bug reappeared in cobbler/koan 2.4.0-1

# updated fedora 19 install:

[root@fs-idcpo01 tmp]# rpm -q koan
koan-2.4.0-1.fc19.noarch

[root@fs-idcpo01 libvirt]# koan --server=mirror --system='wiki1' --virt --virt-bridge=br0 --qemu-disk-type=virtio --qemu-net-type=virtio --virt-type=kvm
- looking for Cobbler at http://mirror:80/cobbler_api
- reading URL: http://172.20.45.23/cblr/svc/op/ks/system/wiki1
install_tree: http://mirror/fedora/linux/releases/19/Fedora/x86_64/os/
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/koan/app.py", line 1477, in load_virt_modules
    import xencreate
  File "/usr/lib/python2.7/site-packages/koan/xencreate.py", line 30, in <module>
    import virtinstall
  File "/usr/lib/python2.7/site-packages/koan/virtinstall.py", line 42, in <module>
    from virtinst import osdict
ImportError: No module named virtinst


Dependency re-introduction occurred between beta6 -> release.

--- cobbler-cobbler-2.4.0-beta6/koan/virtinstall.py     2013-05-24 16:07:25.000000000 -0500
+++ cobbler-2.4.0-1/koan/virtinstall.py 2013-07-26 11:19:59.203770532 -0500
@@ -39,6 +39,8 @@ try:
 except:
y     virtinst_version = None
 
+from virtinst import osdict
+
 def _sanitize_disks(disks):
     ret = []
     for d in disks:

Temporary workaround is the utilize beta6 virtinstall.py source. 

Thank You!

Comment 11 Orion Poplawski 2013-08-09 01:29:59 UTC
Matt - I would suggest filing a new bug for this.


Note You need to log in before you can comment on or make changes to this bug.