Spec URL: http://www.cora.nwra.com/~orion/fedora/python-envisage.spec SRPM URL: http://www.cora.nwra.com/~orion/fedora/python-envisage-4.3.0-1.fc18.src.rpm Description: Envisage is a Python-based framework for building extensible applications, that is, applications whose functionality can be extended by adding "plug-ins". Envisage provides a standard mechanism for features to be added to an application, whether by the original developer or by someone else. In fact, when you build an application using Envisage, the entire application consists primarily of plug-ins. In this respect, it is similar to the Eclipse and Netbeans frameworks for Java applications. Each plug-in is able to: * Advertise where and how it can be extended (its "extension points"). * Contribute extensions to the extension points offered by other plug-ins. * Create and share the objects that perform the real work of the application ("services"). The Envisage project provides the basic machinery of the plug-in framework as well as GUI building tools (envisage.ui). The workbench is the older way to build GUIs from Envisage. It is now recommended to use the Task framework. Fedora Account System Username: orion
Okay, just updated the package to split off docs and such. Should be good to go.
* Tue May 7 2013 Orion Poplawski <orion.com> - 4.3.0-2 - Fix line-endings, cleanup some files - Fix license tag http://www.cora.nwra.com/~orion/fedora/python-envisage-4.3.0-2.fc18.src.rpm
Rahul - will you be reviewing this soon or should I try to find someone else?
Will do this in the weekend
Rahul - ping?
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Binary eggs must be removed in %prep Note: Binary egg files not removed in %prep: ./envisage/tests/eggs/acme.bar-0.1a1-py2.7.egg ./envisage/tests/eggs/acme.baz-0.1a1-py2.7.egg ./envisage/tests/eggs/acme.foo-0.1a1-py2.7.egg See: http://fedoraproject.org/wiki/Packaging:Python#Packaging_eggs_and_setuptools_concerns ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python- envisage-doc [x]: Package complies to the Packaging Guidelines [?]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 356 files have unknown license. Detailed output of licensecheck in /home/rahul/work/958523-python- envisage/licensecheck.txt This is not a blocker but ideally upstreams should include per file copyright notices and you should request them to do it [x]: License file installed when any subpackage combination is installed. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. You should add a comment on top of requires [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Large documentation must go in a -doc subpackage. Note: Documentation size is 30720 bytes in 4 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [?]: Package meets the Packaging Guidelines::Python Does upstream have an Python3 build? [x]: Package contains BR: python2-devel or python3-devel ===== SHOULD items ===== Generic: [!]: Uses parallel make. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [-]: Package does not include license text files separate from upstream. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python-envisage-4.3.0-2.fc20.noarch.rpm python-envisage-doc-4.3.0-2.fc20.noarch.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint python-envisage python-envisage-doc 2 packages and 0 specfiles checked; 0 errors, 0 warnings. # echo 'rpmlint-done:' Requires -------- python-envisage (rpmlib, GLIBC filtered): python(abi) python-AppTools python-traitsui python-envisage-doc (rpmlib, GLIBC filtered): Provides -------- python-envisage: python-envisage python-envisage-doc: python-envisage-doc Source checksums ---------------- http://www.enthought.com/repo/ets/envisage-4.3.0.tar.gz : CHECKSUM(SHA256) this package : 290d031b57670eb78fd4b8065317618e70f9869f55643e480bdfa1adf5f99c15 CHECKSUM(SHA256) upstream package : 290d031b57670eb78fd4b8065317618e70f9869f55643e480bdfa1adf5f99c15 Generated by fedora-review 0.4.1 (b2e211f) last change: 2013-04-29 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -b 958523
* Tue May 14 2013 Orion Poplawski <orion.com> - 4.3.0-3 - Remove shipped egg-info and eggs http://www.cora.nwra.com/~orion/fedora/python-envisage-4.3.0-3.fc18.src.rpm I'll send a message about adding license headers. I've not had much success with python 3 on a lot of these packages. Need to start from the bottom.
Depending on whether you need a older EPEL branch, you don't need to define that macro on top but I assume you already know that. I don't see any outstanding blockers. == APPROVED ==
Thanks. New Package SCM Request ======================= Package Name: python-envisage Short Description: Extensible application framework Owners: orion Branches: f18 f19 el6 InitialCC:
Git done (by process-git-requests).
Checked in and built. Thanks all.