Flat document collections
When using the *gnome-documents* application, it was possible include one collection into another and then vice versa at the same time. Consequently, the application terminated unexpectedly. This update ensures that the collections are flat and do not allow circular chains of collections, thus fixing this bug.
Description of problem:
I played a bit with collections and I found one crash. After that I even cannot start g-d any more. see reproducer
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1.have one document in g-d
2.place that document into two collections
3.right click select those two collections only
4.go into collection dialog via +
5.click several times the first and the second collection there
crash,g-d doesn't start any more
normal sane behaviour
We should not allow collections to be added to or removed from themselves.
This request was not resolved in time for the current release.
Red Hat invites you to ask your support representative to
propose this request, if still desired, for consideration in
the next release of Red Hat Enterprise Linux.
I was able to reproduce (kinda) on gnome-documents-3.14.3-1.el7.x86_64. Gnome-Documents didn't crash for me, but I was able to add a collection to itself and it created an infinite loop of those collections. Similar issue except no crash. But as comment #2 says, collections probably shouldn't be able to be added or removed from themselves.
I have built gnome-documents-3.14.3-3.el7:
This prevents nested collections and ensures that they are always flat. This is in line with what we did upstream in more recent versions.
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.