Bug 958714 - X keyboard layouts/options should be set through localed
Summary: X keyboard layouts/options should be set through localed
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: anaconda
Version: 19
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Vratislav Podzimek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F19Beta, F19BetaBlocker
TreeView+ depends on / blocked
 
Reported: 2013-05-02 09:40 UTC by Rui Matos
Modified: 2013-05-13 16:10 UTC (History)
9 users (show)

Fixed In Version: anaconda-19.25-1
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-05-13 16:10:33 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Rui Matos 2013-05-02 09:40:47 UTC
Currently anaconda configures X keyboard layouts/options in /etc/X11/xorg.conf.d/00-anaconda-keyboard.conf .

It would be best for standardization's sake if it used /etc/X11/xorg.conf.d/00-keyboard.conf instead which is the file that systemd's localed uses.

gnome-settings-daemon 3.8 gets the default layouts from localed so this would make them immediately available there.

I guess anaconda could either write this file itself to the installed system or use the localed dbus api and then copy the file to the installed system.

Comment 1 Vratislav Podzimek 2013-05-06 16:03:16 UTC
Patch posted to anaconda-patches.

Comment 2 Adam Williamson 2013-05-08 17:16:50 UTC
http://www.happyassassin.net/extras/updates-958714.img to test this fix (19.24 with just the patch for this bug added).

Comment 3 Adam Williamson 2013-05-08 17:38:30 UTC
For the record: if you pick French keyboard layout during install, then French keyboard is used in g-i-s and in GNOME even though this window shows as empty. So that's good.

Comment 4 Adam Williamson 2013-05-08 18:05:38 UTC
Confirmed that with the patch (I cherrypicked it from anaconda git onto 19.24), the g-i-s 'input sources' page is no longer blank. If I configure only French during install, it shows both French and English (US). Not sure if that's a bug, or if it's just that GNOME always wants a US layout present as a fallback or whatever.

Comment 5 Adam Williamson 2013-05-08 18:07:03 UTC
the 00-keyboard.conf that got written contained just French, so anaconda clearly did its job.

Comment 6 Rui Matos 2013-05-08 18:31:57 UTC
(In reply to comment #4)
> If I configure
> only French during install, it shows both French and English (US). Not sure
> if that's a bug, or if it's just that GNOME always wants a US layout present
> as a fallback or whatever.

Yes we're enforcing that now, see https://bugzilla.gnome.org/show_bug.cgi?id=697597 . Not the smartest implementation admittedly though.

Comment 7 Jens Petersen 2013-05-09 01:28:04 UTC
I hope anaconda will stop forcing US soon...

Comment 8 Adam Williamson 2013-05-09 01:35:49 UTC
jens: how do you mean? anaconda doesn't force US. It lets you set any arbitrary set of layouts from the keyboard spoke, and if you don't include US English, it doesn't write it into the config file it writes. I tested that behaviour earlier today.

Comment 9 Jens Petersen 2013-05-09 03:14:19 UTC
okay badly chosen word - I meant setting US as the default layout for all locales.

Comment 10 Adam Williamson 2013-05-09 03:52:42 UTC
I'd be -1 on this as a blocker, as ultimately, the layout  you chose in anaconda is used. But it's getting fixed anyway, doesn't really matter.

"I meant setting US as the default layout for all locales."

Well, it doesn't exactly do that either. There's a checkbox on the Language selection screen that toggles that behaviour. Early in F18 it defaulted to trying to set an 'appropriate' layout for the language, but many people complained about that, so Vita changed it.

I think in the end the solution will be this 'langtable' thing; once that provides as accurate a mapping as anaconda's old database used to, then we should be good.

Comment 11 Fedora Update System 2013-05-10 00:51:50 UTC
anaconda-19.25-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/anaconda-19.25-1.fc19

Comment 12 Fedora Update System 2013-05-10 15:30:00 UTC
Package anaconda-19.25-1.fc19, python-blivet-0.13-1.fc19, pykickstart-1.99.30-1.fc19:
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing anaconda-19.25-1.fc19 python-blivet-0.13-1.fc19 pykickstart-1.99.30-1.fc19'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-7834/python-blivet-0.13-1.fc19,pykickstart-1.99.30-1.fc19,anaconda-19.25-1.fc19
then log in and leave karma (feedback).

Comment 13 Adam Williamson 2013-05-13 16:10:33 UTC
The update was pushed stable on Saturday, this should've been closed. It's verified fixed in TC4.


Note You need to log in before you can comment on or make changes to this bug.