A few things flagged by fedora-review:

- Package contains BR: python2-devel or python3-devel
  See: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires

needs BuildRequires: python2-devel instead of BR: python

- Large documentation must go in a -doc subpackage.
  Note: Documentation size is 1269760 bytes in 21 files.
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation

Move pdf bits to a edk2-docs or edk2-tools-docs package

[ ]: Sources contain only permissible code or content.

I'll address this in a separate comment

[ ]: Fully versioned dependency in subpackages, if present.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in edk2-tools

Like it says, 'Requires: edk2' needs to be fully versioned

[ ]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "BSD (4 clause) ISC", "Public domain", "Unknown or generated", "BSD (4
     clause)", "MIT/X11 (BSD like)", "BSD (3 clause) ISC", "zlib/libpng",
     "ISC", "BSD (2 clause) GPL (v2 or later)", "BSD (3 clause)", "BSD (2
     clause)", "*No copyright* Public domain". 7334 files have unknown

The bits being distributed seem to all be BSD, but there's quite a few other hits.

GPLv2 comes from bundled libfdt. If we eventually ship ovmf we'd need to be able to build against system library here.
zlib/libpng comes from bundled Python 2.7.2 . (Is that just for a devkit or would that be included in a future ovmf?)

[!]: Dist tag is present.

Version: should be <date>git<commit>
Release: should be 1%{?dist}

[!]: Uses parallel make.

Use make %{?_smp_mflags}

[ ]: SourceX tarball generation or download is documented.

Stick a comment above the Source line describing how you generated it. Example from virt-manager looks like:

# Generate source with
#   git clone git://git.fedorahosted.org/git/virt-manager.git
#   cd virt-manager
#   git archive --output virt-manager-%{gitcommit}.tar.gz --prefix virt-manager-%{gitcommit}/ %{gitcommit}


[!]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
     Note: Arch-ed rpms have a total of 10895360 bytes in /usr/share 10895360
     edk2-tools-20130502.g732d199-1.x86_64.rpm

Since this is all python bits I guess edk2-tools should be noarch.

(In reply to comment #1)
> 
> [ ]: Sources contain only permissible code or content.
> 
> I'll address this in a separate comment
> 

I was going to ping someone to see if it's acceptable to even have the fat bits in the tarball. I know for patent encumbered code we don't want it in Fedora in any form. But we can avoid the question entirely, just delete the fat code during the tarball generation step and document it in the spec.

> - Package contains BR: python2-devel or python3-devel
> - Large documentation must go in a -doc subpackage.

Will do.

> [ ]: Fully versioned dependency in subpackages, if present.
>      Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in edk2-tools
> 
> Like it says, 'Requires: edk2' needs to be fully versioned

I think it's the other way round; edk2 requires edk2-tools.  I'll use the fully versioned dependency.

> [ ]: License field in the package spec file matches the actual license.
> The bits being distributed seem to all be BSD, but there's quite a few other > hits.
> 
> GPLv2 comes from bundled libfdt. If we eventually ship ovmf we'd need to be > able to build against system library here.

We cannot, since OVMF does not run Linux executables.  So, like the mingw packages, it can be packaged separately.  But anyway libfdt is not used for OVMF, only for ARM.

> zlib/libpng comes from bundled Python 2.7.2 . (Is that just for a devkit or
> would that be included in a future ovmf?)

It could be included in a future OVMF package, but isn't by default so we can just leave it out.  Again, it is a version of Python that runs in the firmware so it can be packaged separately, but no problem.

> [!]: Dist tag is present.
> 
> Version: should be <date>git<commit>
> Release: should be 1%{?dist}

Will do.

> [!]: Uses parallel make.
> 
> Use make %{?_smp_mflags}

I don't really trust this to work always...

> [ ]: SourceX tarball generation or download is documented.
> 
> Stick a comment above the Source line describing how you generated it. 

Will do.

> [!]: Large data in /usr/share should live in a noarch subpackage if package is
>      arched.
>      Note: Arch-ed rpms have a total of 10895360 bytes in /usr/share 10895360
>      edk2-tools-20130502.g732d199-1.x86_64.rpm
> 
> Since this is all python bits I guess edk2-tools should be noarch.

I will make a separate edk2-tools-python package, but note that most of the tools are written in C.

Spec URL: http://bonzini.fedorapeople.org/edk2.spec
SRPM URL: http://bonzini.fedorapeople.org/edk2-20130515svn14365-1.fc19.src.rpm

This is wrong now:

Requires: edk2-tools-python%{?_isa} = %{version}-%{release}

Because edk2-tools-python is noarch, so just dropping the isa bit should be fine.

Also the changelog entry has an incorrect version name, still references git but the package is svn.

After that it should be all set!

Spec URL: http://bonzini.fedorapeople.org/edk2.spec
SRPM URL: http://bonzini.fedorapeople.org/edk2-20130515svn14365-2.fc19.src.rpm

Looks good to me

New Package SCM Request
=======================
Package Name: edk2
Short Description: EFI Development Kit II
Owners: bonzini crobinso
Branches: f18 f19
InitialCC: virtmaint

Git done (by process-git-requests).

edk2-20130515svn14365-2.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/edk2-20130515svn14365-2.fc18

edk2-20130515svn14365-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/edk2-20130515svn14365-2.fc19

edk2-20130515svn14365-2.fc19 has been pushed to the Fedora 19 testing repository.

edk2-20130515svn14365-2.fc18 has been pushed to the Fedora 18 stable repository.

edk2-20130515svn14365-2.fc19 has been pushed to the Fedora 19 stable repository.

Package Change Request
======================
Package Name: edk2
New Branches: el6 epel7
Owners: bonzini crobinso
InitialCC: virtmaint

Git done (by process-git-requests).