Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 959023

Summary: modify search_utility.py to make it possible to customise search by column type
Product: [Retired] Beaker Reporter: Raymond Mancy <rmancy>
Component: web UIAssignee: beaker-dev-list
Status: CLOSED WONTFIX QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 0.12CC: mastyk, qwan, tools-bugs
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-06-02 11:35:13 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 912607    

Description Raymond Mancy 2013-05-03 02:56:55 UTC
Description of problem:

Make search_utility.py be able to do this in a nicer manner
https://bugzilla.redhat.com/show_bug.cgi?id=912607

Version-Release number of selected component (if applicable):


How reproducible:

Always

Steps to Reproduce:
1. Try to implement the above BZ
2.
3.
  
Actual results:

Kinda hacky

Expected results:

Less so

Additional info:

My initial thought was to define customisable column filters on the columns themselves. Currently customisable filters are per column (and defined in the
'table' class), and are not able to be grouped together by 'types' within that table. We already do have customisable column objects though, so we could just expand them to do something like this:

  class InventoryFilter(Filter):

      def is_not(self, col, val):
          # Return relevant WhereClause
          # that excludes non NULLs and maybe
          # does additional filter on lastcheckin
  

  class InventoryColumn(MyColumn):

      filter = InventoryFilter
      

  ~
  custom_filter = getattr(column.filter, '%s' % operation)
  # etc 

This would mean they columns are responsible themselves for defining customisable filters.

Comment 3 Martin Styk 2020-06-02 11:35:13 UTC
Hello,

thank you for opening issue in Beaker project.
This issue was marked with component "web ui".
As we are not planning to address any further issues in current UI, due to technical stack and not being able to work with Python 3 codebase, I'm closing this issue as WONTFIX.
New UI will be reimplemented within new versions of Beaker.

If you have any questions feel free to reach out to me.

Best regards,
Martin <martin.styk>