Created attachment 743143 [details]
Proposed patch - part 1 - Free confdb message holder list on confdb exit
Description of problem:
objdb_notify_dispatch traverse thru confdb_ipc_message_holder_list list
until it's empty. If IPC connection is still feeding confdb/objdb with
changes then iteration will never end. To prevent this and let corosync
properly preempt, terminal condition is enhanced with maximum number of
processed items from list. Change makes confdb preemptable so corosync
can accept new connections, receive/send token, ...
Also when confdb service is unloaded. it's needed to free confdb message holder list. This operation will not only properly free memory, but also decreases
connection reference(s). This should solve deadloop in
coroipcs_ipc_service_exit, because confdb_exit_fn removes not only
notify_pipe but also deletes poll_dispatch, so nobody is left to
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1. Start corosync -p
2. Start IPC client which track key changes and also make changes of that key
3. Exit corosync (sending SIGINT)
Corosync will not exit (unit test $? != 0)
Corosync will properly exit (unit test $? == 0)
Created attachment 743144 [details]
Proposed patch - part 2 - Make objdb_notify_dispatch preemptable
Verified with stop-with-confdb-load.sh test:
FAIL on corosync-1.4.1-15.el6.x86_64 (RHEL6.4)
PASS on corosync-1.4.1-17.el6.x86_64 (RHEL6.5)
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.