Bug 959200 - libbluray: bd_debug should guard against long strings
Summary: libbluray: bd_debug should guard against long strings
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: libbluray
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Xavier Bachelot
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 959198 1045452
TreeView+ depends on / blocked
 
Reported: 2013-05-03 10:42 UTC by Florian Weimer
Modified: 2013-12-20 13:05 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
: 1045452 (view as bug list)
Environment:
Last Closed: 2013-10-23 15:02:33 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)

Description Florian Weimer 2013-05-03 10:42:01 UTC 
The bd_debug function should use snprint and vsnprintf to ensure that the constructed string does not exceed the length of the buffer on the stack.
Comment 1 Fedora End Of Life 2013-09-16 13:45:40 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora 20 development cycle.
Changing version to '20'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora20
Comment 2 Xavier Bachelot 2013-10-23 14:15:23 UTC 
This seems to be fixed by http://git.videolan.org/gitweb.cgi/libbluray.git/?p=libbluray.git;a=commitdiff;h=4b68d1c21b415129adfa0097882e4368a33d0594

Florian, is that what you had in mind ?
Comment 3 Florian Weimer 2013-10-23 14:30:16 UTC 
(In reply to Xavier Bachelot from comment #2)
> This seems to be fixed by
> http://git.videolan.org/gitweb.cgi/libbluray.git/?p=libbluray.git;
> a=commitdiff;h=4b68d1c21b415129adfa0097882e4368a33d0594
> 
> Florian, is that what you had in mind ?

Yes, this looks like the proper fix.
Comment 4 Xavier Bachelot 2013-10-23 15:02:33 UTC 
Thanks for the quick reply (unlike mine).

Fixed in 0.3.0 and later, rawhide currently has 0.4.0, F20 and earlier have 0.2.3 (so have the bug).
Note You need to log in before you can comment on or make changes to this bug.