Bug 959309 - Missing startup dependencies in backuppc.service
Summary: Missing startup dependencies in backuppc.service
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: BackupPC
Version: 20
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Bernard Johnson
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-05-03 11:59 UTC by Fritz Elfert
Modified: 2014-03-12 17:27 UTC (History)
3 users (show)

Fixed In Version: BackupPC-3.3.0-2.el6
Clone Of:
Environment:
Last Closed: 2014-03-10 06:48:31 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Diff to fix this bug (320 bytes, patch)
2014-02-22 21:26 UTC, Fritz Elfert
no flags Details | Diff

Description Fritz Elfert 2013-05-03 11:59:53 UTC
Description of problem:
During boot of my machine running backuppc, the service ist started too early and then fails to start because the filesystem which is used for backups is not yet mounted. The filesystem is located on an iSCSI target which is delay-mounted very late in the boot process.
Looking into /usr/lib/systemd/system/backuppc.service, I noticed, that it contains an After= statement which contains only syslog.target. This is not enough. There should be additional dependencies on local-fs.target and probably remote-fs.target as well.

Version-Release number of selected component (if applicable):
BackupPC-3.2.1-11.fc18.x86_64

How reproducible:
always

Steps to Reproduce:
1. Startup system
2. 
3.
  
Actual results:
BackupPC fails to start.
systemctl status backuppc reports:
backuppc.service - BackupPC server
          Loaded: loaded (/usr/lib/systemd/system/backuppc.service; enabled)
          Active: failed (Result: exit-code) since Fri 2013-05-03 12:57:18 CEST; 39min ago
         Process: 542 ExecStart=/usr/share/BackupPC/bin/BackupPC -d (code=exited, status=1/FAILURE)

May 03 12:57:17 fsun.fe.think systemd[1]: Starting BackupPC server...
May 03 12:57:18 fsun.fe.think BackupPC[542]: 2013-05-03 12:57:18 Can't create a test hardlink between a file in /backup/BackupPC//pc and /backup/BackupPC//cpo...uitting...
May 03 12:57:18 fsun.fe.think systemd[1]: backuppc.service: main process exited, code=exited, status=1/FAILURE
May 03 12:57:18 fsun.fe.think systemd[1]: Failed to start BackupPC server.
May 03 12:57:18 fsun.fe.think systemd[1]: Unit backuppc.service entered failed state

Expected results:
BackupPC starting successfully after all filesystems are mounted.

Additional info

Comment 1 Norman Goldstein 2013-05-12 19:08:20 UTC
I agree with Herr Elfert.
On my current fedora18, I added  httpd.service   to the After= to fix the ordering to allow BackupPC to load automatically at boot.

Comment 2 Fedora End Of Life 2013-12-21 13:22:17 UTC
This message is a reminder that Fedora 18 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 18. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '18'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 18's end of life.

Thank you for reporting this issue and we are sorry that we may not be 
able to fix it before Fedora 18 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior to Fedora 18's end of life.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 3 Fedora End Of Life 2014-02-05 21:13:03 UTC
Fedora 18 changed to end-of-life (EOL) status on 2014-01-14. Fedora 18 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.

Comment 4 Fritz Elfert 2014-02-22 21:24:08 UTC
Reopened against Fedora 20 - nothing has changed there.
Can someone PLEASE attend to this? The necessary change in the .service file is just so simple - going to attach a diff now - hopefully someone cares..

Comment 5 Fritz Elfert 2014-02-22 21:26:19 UTC
Created attachment 866485 [details]
Diff to fix this bug

This diff simply adds local-fs.target and remote-fs.target to the service dependencies.

Comment 6 Fedora Update System 2014-02-23 03:02:47 UTC
BackupPC-3.3.0-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/BackupPC-3.3.0-2.fc19

Comment 7 Fedora Update System 2014-02-23 03:03:58 UTC
BackupPC-3.3.0-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/BackupPC-3.3.0-2.el6

Comment 8 Fedora Update System 2014-02-23 03:08:55 UTC
BackupPC-3.3.0-2.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/BackupPC-3.3.0-2.el5

Comment 9 Fritz Elfert 2014-02-23 14:57:25 UTC
Thanks. But: No submission to F20 (or am I missing something)?

Comment 10 Bernard Johnson 2014-02-23 15:04:53 UTC
Looks like I missed that build.  Submitting it now.

Comment 11 Fedora Update System 2014-02-23 15:18:59 UTC
BackupPC-3.3.0-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/BackupPC-3.3.0-2.fc20

Comment 12 Fedora Update System 2014-02-24 06:01:51 UTC
Package BackupPC-3.3.0-2.el6:
* should fix your issue,
* was pushed to the Fedora EPEL 6 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=epel-testing BackupPC-3.3.0-2.el6'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-EPEL-2014-0663/BackupPC-3.3.0-2.el6
then log in and leave karma (feedback).

Comment 13 Fedora Update System 2014-03-10 06:48:31 UTC
BackupPC-3.3.0-2.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2014-03-10 06:49:57 UTC
BackupPC-3.3.0-2.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 15 Fedora Update System 2014-03-12 17:26:44 UTC
BackupPC-3.3.0-2.el5 has been pushed to the Fedora EPEL 5 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 16 Fedora Update System 2014-03-12 17:27:06 UTC
BackupPC-3.3.0-2.el6 has been pushed to the Fedora EPEL 6 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.