This will be for EPEL 6 exclusively. Description: Trac is an integrated system for managing software projects, an enhanced wiki, a flexible web-based issue tracker, and an interface to the Subversion revision control system. At the core of Trac lies an integrated wiki and issue/bug database. Using wiki markup, all objects managed by Trac can directly link to other issues/bug reports, code changesets, documentation and files. Around the core lies other modules, providing additional features and tools to make software development more streamlined and effective. SRPM: http://fedorapeople.org/~limb/review/trac/trac10-1.0.1-3.el6.src.rpm SPEC: http://fedorapeople.org/~limb/review/trac/trac10.spec
You can drop defattr, clean section, rm in the install section and the buildroot definition. python_sitelib should be defined already and I think you should BR python2-devel: https://fedoraproject.org/wiki/Packaging:Python Please use the sysconfdir macro instead of /etc.
This is intended for EL-6 and possibly EL-5, so I'll take those under advisement, but I will macroise /etc. Thanks!
Thanks for replying to that. Naming: OK Licensing: OK SRPM builds just fine on KOJI Can you provide a quick easy way to test this? Thanks, Dan
You mean besides using it to set up a Trac instance on a EL-6 machine?
(In reply to comment #4) > You mean besides using it to set up a Trac instance on a EL-6 machine? No. Is there a quick setup .doc (I haven't looked too hard), or maybe just a link to a site? That way I can say I tested it and it works. I have a CentOS 6.4 32bit machine ready to go. I'm not too familiar with trac. Never set it up myself. I just use it when creating tickets.
I'd start here. http://trac.edgewall.org/wiki/TracInstall#CreatingaProjectEnvironment
If it helps, I have used the RPM posted (changes requested not included) and have been testing it for a few weeks. I have setup 2 new environments and migrated one trac .12 envronment up to 1.0. No anomolies experianced. Hope this helps.
Excellent, thanks!
(In reply to Seth Kress from comment #7) > If it helps, I have used the RPM posted (changes requested not included) and > have been testing it for a few weeks. > > I have setup 2 new environments and migrated one trac .12 envronment up to > 1.0. No anomolies experianced. > > Hope this helps. Thanks. Approved! With that being said you can process your own SCM request. :)
Also, sorry for the delay.
Thanks, much appreciated. But before I do that, can I have you go into a bit more detail about what you reviewed? It's a bit sparse.
I checked licensing, RPMlint, koji builds, all check out ok, I just wanted to test it and work has been a nightmare. I can paste a fedora-review later today, but you have a proven track record. I did go through the spec, rpm, licensing and rpmlint.
Please, do remember, we're evaluating the package at hand, not whatever I may have done in the past. Absolutely anyone can make mistakes, regardless of prior work. That's the whole point. :) Thank you for your confidence. I appreciate it, but will await the fedora-review output. Trust, but verify, as they say. ;)
[dan@localhost srpm]$ rpmlint trac10-1.0.1-3.el6.src.rpm trac10.src: W: spelling-error %description -l en_US Trac -> Traci, Tracy, Tran trac10.src: W: spelling-error %description -l en_US changesets -> change sets, change-sets, changeless trac10.src:36: W: macro-in-comment %patch0 1 packages and 0 specfiles checked; 0 errors, 3 warnings. [dan@localhost srpm]$ rpmlint trac10.spec trac10.spec:36: W: macro-in-comment %patch0 0 packages and 1 specfiles checked; 0 errors, 1 warnings. Scratch build here: koji build --scratch dist-6E-epel trac10-1.0.1-3.el6.src.rpm Uploading srpm: trac10-1.0.1-3.el6.src.rpm [====================================] 100% 00:00:08 3.34 MiB 399.02 KiB/sec Created task: 5469395 Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=5469395 Watching tasks (this may be safely interrupted)... 5469395 build (dist-6E-epel, trac10-1.0.1-3.el6.src.rpm): open (buildvm-20.phx2.fedoraproject.org) 5469398 buildArch (trac10-1.0.1-3.el6.src.rpm, noarch): free 5469398 buildArch (trac10-1.0.1-3.el6.src.rpm, noarch): free -> open (buildvm-22.phx2.fedoraproject.org) 5469398 buildArch (trac10-1.0.1-3.el6.src.rpm, noarch): open (buildvm-22.phx2.fedoraproject.org) -> closed 0 free 1 open 1 done 0 failed 5469395 build (dist-6E-epel, trac10-1.0.1-3.el6.src.rpm): open (buildvm-20.phx2.fedoraproject.org) -> closed 0 free 0 open 2 done 0 failed 5469395 build (dist-6E-epel, trac10-1.0.1-3.el6.src.rpm) completed successfully I think the BSD license coversr the MIT if you want to be super cautious about it, change the license to BSD + MIT (or X11). Other than that we have a comment from someoen confirming that the package works. NOTE: Okay so one thing, does the BSD license cover MIT/X11? That's all I have minus the fact that Requires: python-genshi06 >= 0.6 is obsoleted in Fedora. NOTE: This is not for Fedora it's for EPEL. SHOULD: Get rid of unused patch files in the spec. Other than that looks GOOD to ME. And confirmed working by another comment.
Also note, fedora-review fails, (packages should build on rawhide). Maybe add a provides for Fedora builds?
It says modified BSD in README, and they're all in the same family, so I'll leave it. Thanks! New Package SCM Request ======================= Package Name: trac10 Short Description: Enhanced wiki and issue tracking system Owners: limb Branches: el6 InitialCC:
Git done (by process-git-requests).
Sigh. And now it won't build, test failure. Will fix prior to import.
Odd...there was a few minutes ago. Don't know if that's related but the scratch build is less than 12 hours old
Sorry, there was an infrastructure issue*
I meant locally, not koji.
Odd. Let me know if I can help in anyway. I'll try and be available from the office.
Really odd, worked in mock. Must be something else I have installed. I'll import and build, should be OK.
Happy limbs are good. :)
trac10-1.0.1-4.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/trac10-1.0.1-4.el6
trac10-1.0.1-4.el6 has been pushed to the Fedora EPEL 6 testing repository.
trac10-1.0.1-4.el6 has been pushed to the Fedora EPEL 6 stable repository.