Hide Forgot
Spec URL: http://lotharlutz.fedorapeople.org/jimtcl.spec SRPM URL: http://lotharlutz.fedorapeople.org/jimtcl-0.73-1.fc18.src.rpm Description: Jim is an opensource small-footprint implementation of the Tcl programming language. It implements a large subset of Tcl and adds new features like references with garbage collection, closures, built-in Object Oriented Programming system, Functional Programming commands, first-class arrays and UTF-8 support. Fedora Account System Username: lotharlutz Note: I am aware that no soname is specified. I do have a patch for this, but I am waiting for upstream to clarify the right soname.
Do you can attach "so" patch here?
Initial pre-review: * rm -rf $RPM_BUILD_ROOT is not nesessary: http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean * %defattr(-,root,root,-) is not nesessary: http://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions * to avoid double doc folders and other conflicts (/usr/share/doc/jimtcl/ is in both packages - as in main as in -devel) - you can use additional docs right from sources: ... %make_install +rm -rf %{buildroot}/%{_datadir}/doc/%{name} ... -%doc LICENSE AUTHORS README -%doc %{_docdir}/%{name}/Tcl.html +%doc LICENSE AUTHORS README Tcl.html ... -%doc DEVELOPING -%doc %{_docdir}/%{name}/README.extensions +%doc DEVELOPING README.extensions * If you ship README.extensions and switch all extensions On - to add README.<other_extentions> will be usual * STYLE file (-devel) will be usual too * You must fix git snapshot that you use. Best way - to use git tag in github mirror: https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Github * If you have "so" patch - welcome * Adding Koji builds will be welcoming too
Thanks for your comments. New files (with so-patch included): Spec URL: http://lotharlutz.fedorapeople.org/jimtcl.spec SRPM URL: http://lotharlutz.fedorapeople.org/jimtcl-0.73-2.fc18.src.rpm Koji-builds: http://koji.fedoraproject.org/koji/taskinfo?taskID=5332568
Ordinary -devel subpackage contains libname.so as symlink to fully versioned libname.so.*: jimtcl.i686: W: no-soname /usr/lib/libjim.so This is not a bug, but...
(In reply to comment #4) > Ordinary -devel subpackage contains libname.so as symlink to fully versioned > libname.so.*: > > jimtcl.i686: W: no-soname /usr/lib/libjim.so > > This is not a bug, but... Is this the output of rpmlint against the latest version? (0.73-2) Because this should be fixed by the so-patch. I think the symlink will be created by /sbin/ldconfig
(In reply to comment #5) > (In reply to comment #4) > > Ordinary -devel subpackage contains libname.so as symlink to fully versioned > > libname.so.*: > > > > jimtcl.i686: W: no-soname /usr/lib/libjim.so > > > > This is not a bug, but... > > Is this the output of rpmlint against the latest version? (0.73-2) Because > this should be fixed by the so-patch. Yes - fedora-review right from bugreport no. Look inside resulting rpms. > I think the symlink will be created by /sbin/ldconfig No, ldconfig creates nothing. Ordinary *.so symlink is created by Makefile.
Hmm, I just issued 'fedora-review -b 959747' and no warning 'jimtcl.i686: W: no-soname /usr/lib/libjim.so' is showed inside the log. Running rpmlint on the scratch builds also does not show the warning.
Right now: bash-4.2$ fedora-review -b 959747; LC_ALL=C date INFO: Processing bugzilla bug: 959747 ... INFO: Downloading (Source0): https://github.com/msteveb/jimtcl/archive/0.73.tar.gz WARNING: Cannot download url: https://github.com/msteveb/jimtcl/archive/0.73.tar.gz ... Sun May 5 19:00:01 MSK 2013 bash-4.2$ grep "libjim.so" 959747-jimtcl/review.txt jimtcl.i686: W: no-soname /usr/lib/libjim.so libjim.so.0 libjim.so.0 bash-4.2$ BTW - you use wrong Source0 URL.
And: "- incorpporate review remarks" in changelog is not informative. This bugreport will be closed after some days (after success review). Then people will be confused - "What remarks? What review?"
Spec URL: http://lotharlutz.fedorapeople.org/jimtcl.spec SRPM URL: http://lotharlutz.fedorapeople.org/jimtcl-0.73-3.fc18.src.rpm - fix source url - add symlink to library to devel package Scratch builds: http://koji.fedoraproject.org/koji/taskinfo?taskID=5333420 http://koji.fedoraproject.org/koji/taskinfo?taskID=5333409 http://koji.fedoraproject.org/koji/taskinfo?taskID=5333412 http://koji.fedoraproject.org/koji/taskinfo?taskID=5333415 I issued rpmlint on every single rpm form the scratch builds, but no 'W: no-soname ...'. To be honest: I have no idea why you hit this issue.
As for me - like "reference" package. Good job (together :-). APPROVED
Thanks Eugene...
New Package SCM Request ======================= Package Name: jimtcl Short Description: A small embeddable Tcl interpreter Owners: lotharlutz Branches: f17 f18 f19 el6
(In reply to comment #12) > Thanks Eugene... "Thanks" is too much for me. Reviewing quiterss will be enough :-)
Git done (by process-git-requests).