Bug 959911 - Some ks files got left out of Makefile.am
Summary: Some ks files got left out of Makefile.am
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: spin-kickstarts
Version: 19
Hardware: i386
OS: Linux
unspecified
low
Target Milestone: ---
Assignee: Bruno Wolff III
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 959912 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-05-06 08:40 UTC by James
Modified: 2015-01-04 23:11 UTC (History)
10 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-01-04 23:11:03 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description James 2013-05-06 08:40:44 UTC
Description of problem:

  files missing:
    fedora-live-mate-compiz.ks
    fedora-lxde-packages.ks
    fedora-xfce-packages.ks
  maybe more...

Version-Release number of selected component (if applicable):

  fedora-kickstarts-0.19.4-1.fc19.noarch

How reproducible:
  
  always

Steps to Reproduce:

  A. livecd-creator -v -c /usr/share/spin-kickstarts/fedora-livecd-mate-compiz.ks
  B. livecd-creator -v -c /usr/share/spin-kickstarts/fedora-livecd-lxde.ks
  C. livecd-creator -v -c /usr/share/spin-kickstarts/fedora-livecd-xfce.ks
  
Actual results:

  Unable to open kickstart file curl#37 - "Couldn't open file /home/complainer/livecd19/fedora-xfce-packages.ks"
  etc.

Expected results:

  builds livecd 

Additional info:

  Right now I do not have time to spend for testing.

Comment 1 Bruno Wolff III 2013-05-06 13:13:56 UTC
I am seeing those files in /usr/share/spin-kickstarts/ as part of the files installed from the fedora-kickstarts rpm. I do see the same error message when I test this, so it looks like livecd-creator is messing up the path somehow. For now I am moving this to livecd-tools, but the breakage could potentially be in something used by livecd-tools.

Comment 2 Bruno Wolff III 2013-05-06 13:16:26 UTC
*** Bug 959912 has been marked as a duplicate of this bug. ***

Comment 3 James 2013-05-06 13:57:35 UTC
(In reply to comment #1)
> I am seeing those files in /usr/share/spin-kickstarts/ 
[...]
>it looks like livecd-creator is messing up the path

This is different for me (see directory listing below).

[root@localhost user]# ls /usr/share/spin-kickstarts/  | grep mate
fedora-livecd-mate-compiz.ks

[root@localhost user]# ls /usr/share/spin-kickstarts/ -l
total 108
drwxr-xr-x. 1 root root    90 May  3 14:59 custom
-rw-r--r--. 1 root root  2077 May  1 02:08 fedora-aos.ks
-rw-r--r--. 1 root root  2759 May  1 02:08 fedora-install-fedora.ks
-rw-r--r--. 1 root root  9641 May  1 02:08 fedora-live-base.ks
-rw-r--r--. 1 root root  1201 May  1 02:08 fedora-livecd-desktop.ks
-rw-r--r--. 1 root root  1963 May  1 02:08 fedora-livecd-kde.ks
-rw-r--r--. 1 root root  1354 May  1 02:08 fedora-livecd-lxde.ks
-rw-r--r--. 1 root root  1186 May  1 02:08 fedora-livecd-mate-compiz.ks
-rw-r--r--. 1 root root  7260 May  1 02:08 fedora-livecd-security.ks
-rw-r--r--. 1 root root  3083 May  1 02:08 fedora-livecd-soas.ks
-rw-r--r--. 1 root root  2176 May  1 02:08 fedora-livecd-xfce.ks
-rw-r--r--. 1 root root  2306 May  1 02:08 fedora-live-design-suite.ks
-rw-r--r--. 1 root root  2192 May  1 02:08 fedora-live-desktop.ks
-rw-r--r--. 1 root root   722 May  1 02:08 fedora-livedvd-electronic-lab.ks
-rw-r--r--. 1 root root  2489 May  1 02:08 fedora-livedvd-games.ks
-rw-r--r--. 1 root root  3072 May  1 02:08 fedora-livedvd-robotics.ks
-rw-r--r--. 1 root root  2202 May  1 02:08 fedora-livedvd-scientific-kde.ks
-rw-r--r--. 1 root root  3306 May  1 02:08 fedora-live-jam-kde.ks
-rw-r--r--. 1 root root  4163 May  1 02:08 fedora-live-kde-base.ks
-rw-r--r--. 1 root root  1428 May  1 02:08 fedora-live-kde.ks
-rw-r--r--. 1 root root 11271 May  1 02:08 fedora-live-mini.ks
-rw-r--r--. 1 root root   396 May  1 02:08 fedora-live-minimization.ks
drwxr-xr-x. 1 root root  1766 May  3 15:00 l10n

Comment 4 Brian Lane 2013-05-06 17:44:26 UTC
The files are missing, this isn't a livecd problem. The odd path you are seeing is due to pykickstart trying to find the %include when it isn't in the same directory as the primary ks file.

[root@localhost livecd]# rpm -q fedora-kickstarts spin-kickstarts
fedora-kickstarts-0.19.4-1.fc19.noarch
spin-kickstarts-0.19.4-1.fc19.noarch

[root@localhost livecd]# rpm -ql fedora-kickstarts | grep xfce
/usr/share/spin-kickstarts/fedora-livecd-xfce.ks

Notice the missing fedora-xfce-packages.ks

It looks to me like Makefile.am is missing some of the required ks files, from the logs it looks like some of them were split out, but not added. eg. commit 
f8194b615

Comment 5 Bruno Wolff III 2013-05-06 18:08:49 UTC
Thanks. I now see it was files included in those ks files that are missing. I was misreading it as the top file missing. I should be able to get this fixed tonight.

Comment 6 Bruno Wolff III 2013-05-06 18:37:22 UTC
I did an audit of the ks files in git versus Makefile.am and added all of them to Makefile.am. This has been gitted to f19 and master in git. I'll do builds for f19 and f20 tonight.

Comment 7 Bruno Wolff III 2013-05-07 00:21:59 UTC
This should be fixed in spin-kickstarts-0.19.5-1.fc19 and spin-kickstarts-0.20.3-1.fc20.

Comment 8 James 2013-05-08 10:03:15 UTC
Thank you

(In reply to comment #7)
> This should be fixed in spin-kickstarts-0.19.5-1.fc19 and
> spin-kickstarts-0.20.3-1.fc20.


Note You need to log in before you can comment on or make changes to this bug.