Spec URL: http://anujmore.fedorapeople.org/pkgs/rubygem-debug_inspector/rubygem-debug_inspector.spec SRPM URL: http://anujmore.fedorapeople.org/pkgs/rubygem-debug_inspector/rubygem-debug_inspector-0.0.2-1.fc19.src.rpm Description: A Ruby wrapper for the MRI 2.0 debug_inspector API. Fedora Account System Username: anujmore
Additionally, mock builds: http://anujmore.fedorapeople.org/pkgs/rubygem-debug_inspector/mock-debug_inspector-build.log http://anujmore.fedorapeople.org/pkgs/rubygem-debug_inspector/mock-debug_inspector-screen.txt rpmlint gives this: rubygem-debug_inspector.src:43: W: macro-in-comment %gem_dir rubygem-debug_inspector.x86_64: W: no-soname /usr/lib64/gems/ruby/debug_inspector-0.0.2/lib/debug_inspector.so rubygem-debug_inspector.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 3 warnings.
I will take it for a review.
I am sorry for such a delay. * Both %description for the package and its sub-package should end with a dot (.) * %{gem_instdir}/README.md should be in the main package since it contains license (ideally you should ask upstream to split the license to a separate file) * %{gem_instdir}/README.md should be marked as %doc * Why do you state # TODO: move the extensions if you are moving it already? Otherwise the package works as expected.
Anuj, we need this for Rails 4.2 change, will you work on it or should I do instead?
Since Anuj is unresponsive, I took the liberty to follow from the point he ended and updated the .spec file. Spec URL: https://fedorapeople.org/cgit/vondruch/public_git/rubygem-debug_inspector.git/tree/rubygem-debug_inspector.spec?id=a791e72b22ade661073caa499a8fdf368f55e759 SRPM URL: http://people.redhat.com/vondruch/rubygem-debug_inspector-0.0.2-2.fc22.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=8707535
Package builds, installs, runs, rpmlint does not complain. Spec looks sane, my previous complains were fixed. ==> APPROVED.
Thanks for review! New Package SCM Request ======================= Package Name: rubygem-debug_inspector Short Description: A Ruby wrapper for the MRI 2.0 debug_inspector API Upstream URL: https://github.com/banister/debug_inspector Owners: vondruch jstribny Branches: InitialCC:
Git done (by process-git-requests).