Spec URL: http://anujmore.fedorapeople.org/pkgs/rubygem-faker/rubygem-faker.spec SRPM URL: http://anujmore.fedorapeople.org/pkgs/rubygem-faker/rubygem-faker-1.1.2-1.fc19.src.rpm Description: Faker, a port of Data::Faker from Perl, is used to easily generate fake data: names, addresses, phone numbers, etc. Fedora Account System Username: anujmore
Additionally: http://anujmore.fedorapeople.org/pkgs/rubygem-faker/mock-faker-build.log http://anujmore.fedorapeople.org/pkgs/rubygem-faker/mock-faker-screen.txt rpmlint is being annoying as always: rubygem-faker.noarch: W: no-documentation rubygem-faker.src:51: W: macro-in-comment %gem_dir 3 packages and 0 specfiles checked; 0 errors, 2 warnings. Thanks.
I will take it for a review.
* run tests properly Currently no tests are being run. Including rubygem(i18n) as a BuildDependency should make them run. * comments Why is `BuildRequires: rubygem(yaml)` and `ruby -Ilib:test ...` commented out? Either make useful comments or delete them. * license %doc %{gem_instdir}/License.txt should be in the main package. * rpmlint You should have %%gem_dir instead of %gem_dir in the comment so the macro won't expand. Please run the test suite with rubygem-i18n and fix the spec.
Spec URL: http://anujmore.fedorapeople.org/pkgs/rubygem-faker/rubygem-faker.spec SRPM URL: http://anujmore.fedorapeople.org/pkgs/rubygem-faker/rubygem-faker-1.1.2-2.fc19.src.rpm Builds fine on mock (with test cases this time), rpmlint: 3 packages and 0 specfiles checked; 0 errors, 0 warnings.
Although somebody may disagree, I would suggest to mark %{gem_instdir}/History.txt %{gem_instdir}/README.md As a %doc.
Done: Spec URL: http://anujmore.fedorapeople.org/pkgs/rubygem-faker/rubygem-faker.spec
Anuj, please provide also corresponding SRPM that I can test and approve. Otherwise the spec looks okay :).
Hello Josef, the SRPM has been uploaded to replace the previous RPM (since the changes weren't serious): So the URLs still are: Spec URL: http://anujmore.fedorapeople.org/pkgs/rubygem-faker/rubygem-faker.spec SRPM URL: http://anujmore.fedorapeople.org/pkgs/rubygem-faker/rubygem-faker-1.1.2-2.fc19.src.rpm
Ach, you didn't bump the release, okay then. (It's better for the next time to do so, I can easily see the change.) SRPM builds in Koji, installs & works and rpmlint doesn't complain so I am APPROVING this package.
Package Name: rubygem-faker Short Description: Easily generate fake data Owners: anujmore axilleas Branches: f19
New Package SCM Request ======================= Package Name: rubygem-faker Short Description: Easily generate fake data Owners: anujmore axilleas Branches: f19 InitialCC:
Git done (by process-git-requests).