Updated to V2.43.8

You can find SPEC/SRPM here: http://besser82.fedorapeople.org/pkg/libyui-ncurses/

Or clone my git-repo from besser82:public_git/libyui.git and checkout the libyui-ncurses branch.

BR,
  Björn Esser

Spec URL: http://besser82.fedorapeople.org/pkg/libyui-ncurses/libyui-ncurses.spec
SRPM URL: http://besser82.fedorapeople.org/pkg/libyui-ncurses/libyui-ncurses-2.43.8-1.fc18.src.rpm

Adapted Spec/SRPM urls for tracking inside "fedora-review" tool.

Only some minor things:


* Macro fun. ;-)

Not a blocker according to the guidelines, but I need to point out that I find the growing number of %globals less readable. They will cause you some headaches eventually. Of course, you're free to use so many macros, it's just not really beneficial. Example:

  %global uitype ncurses
  %global uiname %{uitype}

  BuildRequires:  %{uitype}-devel

ncurses is unlikely to be renamed, so spelling out its name would be more clear. In case you want the spec file be suitable for target distributions other than Fedora, ncurses-devel might even be named ncurses-dev instead, and then you would need to change the macros here already.

  $ grep uiname *.spec
  %global uiname %{uitype}

An unused macro, it seems, and it's just a redefinition of %uitype anyway.

Using many custom macros in Provides and Requires can lead to trouble easily. Touching the macro definition in a single place may make the built package provide or require wrong things. Such an error (or typing mistake) would not be obvious when viewing the automatically sent git commit diff mail. It could be something ugly such as an unexpanded macro name. And yes, it's a pitfall other packagers have run into before.


> %description devel

s/sufficent/sufficient/

rpmlint also finds that when you run it on the binary rpms.


> %post -p /sbin/ldconfig
> 
> %postun -p /sbin/ldconfig

Not needed.

This package doesn't store any shared libs in run-timer linker's search path. The plugins are stored in private path %_libdir/yui/ and are dlopen()'ed at run-time via their full path (and including the major library version, currently ".so.5").


> %files
> %dir %{_libdir}/%{libsuffix}

This directory is included in package %parname (libyui) already. 
https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_also_owned_by_a_package_implementing_required_functionality_of_your_package


> %files devel

> %dir %{_libdir}/%{libsuffix}

> %{_includedir}/%{libsuffix}

> %{_datadir}/%{parname}

These dirs are also provided by libyui already. Modern RPM can handle that also upon removing the packages.

Spec URL: http://besser82.fedorapeople.org/pkg/libyui-ncurses/libyui-ncurses.spec
SRPM URL: http://besser82.fedorapeople.org/pkg/libyui-ncurses/libyui-ncurses-2.43.8-2.fc18.src.rpm

Updated the pkg according your advice. Thanks for reviewing.

%changelog
* Wed May 15 2013 Björn Esser <bjoern.esser> - 2.43.8-2
- fixup as suggested in https://bugzilla.redhat.com/show_bug.cgi?id=960199#c3
- exchanged {parname} with {libname}

* Mon May 13 2013 Björn Esser <bjoern.esser> - 2.43.8-1
- Initial RPM release.

Spec URL: http://besser82.fedorapeople.org/pkg/libyui-ncurses/libyui-ncurses.spec
SRPM URL: http://besser82.fedorapeople.org/pkg/libyui-ncurses/libyui-ncurses-2.43.9-1.fc18.src.rpm

New upstream version. Thanks for your review.

%changelog
* Wed May 15 2013 Björn Esser <bjoern.esser> - 2.43.9-1
- new upstream version
- adjusted %{libname}-devel min-version
- added needed bootstrap to prep

* Wed May 15 2013 Björn Esser <bjoern.esser> - 2.43.8-2
- fixup as suggested in https://bugzilla.redhat.com/show_bug.cgi?id=960199#c3
- exchanged {parname} with {libname}

* Mon May 13 2013 Björn Esser <bjoern.esser> - 2.43.8-1
- Initial RPM release.

> %package devel
>
> Requires:	ncurses

ncurses-devel%{?_isa}  of course. Guess I managed to confuse you with the suggestion to get rid of some macros. Ha! :)


Beyond that, save yourself another update in this bugzilla review request, since it'll be more convenient to fix it in Fedora pkg git:

APPROVED

New Package SCM Request
=======================
Package Name: libyui-ncurses
Short Description: Character Based User Interface for libyui
Owners: besser82
Branches: f19

Git done (by process-git-requests).

Package Change Request
======================
Package Name: libyui-ncurses
New Branches: f18
Owners: besser82

Git done (by process-git-requests).

libyui-ncurses-2.43.9-3.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/libyui-ncurses-2.43.9-3.fc18

libyui-ncurses-2.43.9-3.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/libyui-ncurses-2.43.9-3.fc19

libyui-ncurses-2.43.9-3.fc18 has been pushed to the Fedora 18 stable repository.

libyui-ncurses-2.43.9-3.fc19 has been pushed to the Fedora 19 stable repository.

Package Change Request
======================
Package Name: libyui-ncurses
New Branches: el6
Owners: besser82

Want to build on el6, too.

Git done (by process-git-requests).