Spec URL: http://averi.fedorapeople.org/RPMs/perl-File-Touch/File-Touch.spec SRPM URL: http://averi.fedorapeople.org/RPMs/perl-File-Touch/perl-File-Touch-0.08-1.fc18.src.rpm Description: The following Perl module allows you to update access and modification timestamps, creating nonexistent files where necessary. Fedora Account System Username: averi
Added a few additional improvements to the package: http://averi.fedorapeople.org/RPMs/perl-File-Touch/perl-File-Touch.spec http://averi.fedorapeople.org/RPMs/perl-File-Touch/perl-File-Touch-0.08-2.fc18.src.rpm
URL and Source0 are usable. Ok. Source tar ball is original (SHA-256: 2b37f129ba63523027ed636f5ccde8db892e5f6bbb7401077378fddf78a7592c). Ok. Summary verified from Touch.pm. Ok. TODO: Correct summary spelling (timestamps → time stamps). TODO: Rephrase description (The following Perl module allows you to → This Perl module allows you to). Nothing follows after the sentence. FIX: Correct license tag (Touch.pm states (GPL+ or Artistic)). There is no XS code, noarch BuildArch is Ok. TODO: Build-require `perl(IO::File)' (Touch.pm:11). TODO: Build-require `perl(File::stat)' (Touch.pm:12). TODO: Build-require `perl(Fcntl)' (Touch.pm:13). FIX: Do not build-require `perl(base)'. It's used nowhere. TODO: You can use simple `perl' instead of `%{__perl}' macro. All tests pass. Ok. $ rpmlint perl-File-Touch.spec ../SRPMS/perl-File-Touch-0.08-2.fc20.src.rpm ../RPMS/noarch/perl-File-Touch-0.08-2.fc20.noarch.rpm perl-File-Touch.spec:46: W: macro-in-%changelog %{version} perl-File-Touch.src: W: spelling-error Summary(en_US) timestamps -> time stamps, time-stamps, times tamps perl-File-Touch.src: W: spelling-error %description -l en_US timestamps -> time stamps, time-stamps, times tamps perl-File-Touch.src:46: W: macro-in-%changelog %{version} perl-File-Touch.noarch: W: spelling-error Summary(en_US) timestamps -> time stamps, time-stamps, times tamps perl-File-Touch.noarch: W: spelling-error %description -l en_US timestamps -> time stamps, time-stamps, times tamps 2 packages and 1 specfiles checked; 0 errors, 6 warnings. FIX: Escape the per-cent character in the changelog with another per-cent character. TODO: Correct the spelling. $ rpm -q -lv -p ../RPMS/noarch/perl-File-Touch-0.08-2.fc20.noarch.rpm drwxr-xr-x 2 root root 0 May 9 16:19 /usr/share/doc/perl-File-Touch-0.08 -rw-r--r-- 1 root root 550 Jul 25 2009 /usr/share/doc/perl-File-Touch-0.08/Changes -rw-r--r-- 1 root root 2644 May 9 16:19 /usr/share/man/man3/File::Touch.3pm.gz drwxr-xr-x 2 root root 0 May 9 16:19 /usr/share/perl5/vendor_perl/File -rw-r--r-- 1 root root 5812 Jul 25 2009 /usr/share/perl5/vendor_perl/File/Touch.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-File-Touch-0.08-2.fc20.noarch.rpm | sort | uniq -c 1 perl(Carp) 1 perl(Exporter) 1 perl(Fcntl) 1 perl(File::stat) 1 perl(IO::File) 1 perl(:MODULE_COMPAT_5.16.3) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-File-Touch-0.08-2.fc20.noarch.rpm | sort | uniq -c 1 perl(File::Touch) = 0.08 1 perl-File-Touch = 0.08-2.fc20 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-File-Touch-0.08-2.fc20.noarch.rpm Binary dependencies resolvable. Ok. Package build in F20 (http://koji.fedoraproject.org/koji/taskinfo?taskID=5354528). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' issues, consider fixing `TODO' items, and provide new spec file. Resolution: Package NOT approved.
Both the errors are now fixed. The SPEC and SRPMS are available at the same location URL as before.
Spec file changes: --- perl-File-Touch.spec.old 2013-05-09 15:51:15.000000000 +0200 +++ perl-File-Touch.spec 2013-05-09 16:46:24.000000000 +0200 @@ -2,14 +2,13 @@ Summary: Update access, modification timestamps, creating nonexistent files Version: 0.08 Release: 2%{?dist} -License: ASL 2.0 +License: GPL+ or Artistic Group: Development/Libraries URL: http://search.cpan.org/dist/File-Touch BuildArch: noarch Source: http://search.cpan.org/CPAN/authors/id/N/NW/NWETTERS/File-Touch-%{version}.tar.gz BuildRequires: perl(ExtUtils::MakeMaker) BuildRequires: perl -BuildRequires: perl(base) BuildRequires: perl(Carp) BuildRequires: perl(Exporter) BuildRequires: perl(strict) @@ -42,8 +41,7 @@ %changelog * Thu May 9 2013 Andrea Veri <averi> - 0.08-2 -- Change the license to ASL 2.0. -- Fix Source0 to point to UpstreamName-%{version}. +- Fix Source0 to point to UpstreamName-%%{version}. - Add the missing Build Depends. * Mon May 6 2013 Andrea Veri <averi> - 0.08-1 > TODO: Correct summary spelling (timestamps → time stamps). Not addressed. > TODO: Rephrase description (The following Perl module allows you to → This Perl module allows you to). Nothing follows after the sentence. Not addressed. > FIX: Correct license tag (Touch.pm states (GPL+ or Artistic)). -License: ASL 2.0 +License: GPL+ or Artistic Ok. > TODO: Build-require `perl(IO::File)' (Touch.pm:11). > TODO: Build-require `perl(File::stat)' (Touch.pm:12). > TODO: Build-require `perl(Fcntl)' (Touch.pm:13). Not addressed. Please note that this insufficiency can cause build failures in the future. > FIX: Do not build-require `perl(base)'. It's used nowhere. -BuildRequires: perl(base) Ok. > TODO: You can use simple `perl' instead of `%{__perl}' macro. Not addressed. > FIX: Escape the per-cent character in the changelog with another per-cent character. -- Fix Source0 to point to UpstreamName-%{version}. +- Fix Source0 to point to UpstreamName-%%{version}. Ok. $ rpmlint perl-File-Touch.spec ../SRPMS/perl-File-Touch-0.08-2.fc20.src.rpm ../RPMS/noarch/perl-File-Touch-0.08-2.fc20.noarch.rpm perl-File-Touch.src: W: spelling-error Summary(en_US) timestamps -> time stamps, time-stamps, times tamps perl-File-Touch.src: W: spelling-error %description -l en_US timestamps -> time stamps, time-stamps, times tamps perl-File-Touch.noarch: W: spelling-error Summary(en_US) timestamps -> time stamps, time-stamps, times tamps perl-File-Touch.noarch: W: spelling-error %description -l en_US timestamps -> time stamps, time-stamps, times tamps 2 packages and 1 specfiles checked; 0 errors, 4 warnings. TODO: Correct the spelling. Package builds in F20 (http://koji.fedoraproject.org/koji/taskinfo?taskID=5360101). Ok. Please consider fixing the `TODO' items before building the package. Resolution: Package APPROVED.
New Package SCM Request ======================= Package Name: perl-File-Touch Short Description: Update access, modification timestamps, creating nonexistent files Owners: averi psabata Branches: f18 f19 el6 InitialCC: perl-sig
Git done (by process-git-requests).
The package was imported and pushed already.