Spec URL: http://smani.fedorapeople.org/sailcut.spec SRPM URL: http://smani.fedorapeople.org/sailcut-1.3.5-1.svnr771.fc20.src.rpm Description: Sailcut CAD is a sail design and plotting software. Fedora Account System Username: smani
Short preview: Source2: sailcut.xml BuildRequires: cmake ... BuildRequires: shared-mime-info %description ... * You separate as spec sections as section items with CR. It's hard to read. * %{cmake} . > %cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo . (https://bugzilla.redhat.com/show_bug.cgi?id=919044#c31) * make_install == make install DESTDIR=%{buildroot} try "rpm --eval %make_install (or other macro) PS. Don't forget to update release.
Spec URL: http://smani.fedorapeople.org/sailcut.spec SRPM URL: http://smani.fedorapeople.org/sailcut-1.3.5-2.svnr771.fc20.src.rpm * Mon May 06 2013 Sandro Mani <manisandro> - 1.3.5-2.svnr771 - Use -DCMAKE_BUILD_TYPE=RelWithDebInfo - Use %make_install
Ok, next (final?) pre-review: 1. %make_install == make install DESTDIR=%{buildroot} 2. changelog must be in right order (freshest is on the top) 3. Koji builds are welcome 4. Please use unified section split style - or double CR or one. 5. Source0: http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz (http://fedoraproject.org/wiki/Packaging:SourceURL#Sourceforge.net) As you use hand-made svn snapshot - I can't check it and fedora-review can't download sources. From other side - main differences between 771 and original 1.3.5 tarball are a) new test cases (that you don't need) and b) small CmakeLists.txt patch. I propose you to use original 1.3.5 tarball and aply patch.
(In reply to comment #3) > I propose you to use original 1.3.5 tarball and aply patch. Or to use other way (like http://fedoraproject.org/wiki/Packaging:SourceURL#Troublesome_URLs)
Spec URL: http://smani.fedorapeople.org/sailcut.spec SRPM URL: http://smani.fedorapeople.org/sailcut-1.3.5-1.fc20.src.rpm Argh, late night work.. 1. fixed 2. fixed 3. Here: http://koji.fedoraproject.org/koji/taskinfo?taskID=5338611 4. Do you mean the single CR before %description and double elsewhere? If so, fixed (I'd rather keep a single CR before the BuildRequires) 5. fixed And for the snapshot issue, I've ended up using 1.3.5 + patch as you suggested.
Approved. Notes: 1. W: spelling-error %description -l en_US visualise -> visualize, visual 2. Licenses found: "GPL (v2 or later) (with incorrect FSF address)" I recomend you to make total replacement (find+sed) of wrong FSF address with correct: http://www.fsf.org/about/contact/. And check with "licensecheck -r *"
Spec URL: http://smani.fedorapeople.org/sailcut.spec SRPM URL: http://smani.fedorapeople.org/sailcut-1.3.5-2.fc20.src.rpm Spelling and licenses fixed. Thanks for the review!
New Package SCM Request ======================= Package Name: sailcut Short Description: A sail design and plotting software Owners: smani Branches: f18 f19 InitialCC:
Git done (by process-git-requests).
sailcut-1.3.5-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/sailcut-1.3.5-2.fc19
sailcut-1.3.5-2.fc19 has been pushed to the Fedora 19 testing repository.
sailcut-1.3.5-2.fc19 has been pushed to the Fedora 19 stable repository.