Provides support to precompile your JSPs and have them included into your WAR file. Version 2 of the JSP compilation support includes a pluggable JSP compiler implementation, which currently allows different versions of the Tomcat Jasper compiler to be used as needed. Can also be used with Glassfish jspc impl. srpm located at: http://repos.fedorapeople.org/repos/rrati/hadoop/fedora-18/SRPMS/jspc-2.0-0.2.alpha.3.fc18.src.rpm
Updates based on feedback from gil (thanks!) Spec: http://pmackinn.fedorapeople.org/jspc/jspc.spec SRPM: http://pmackinn.fedorapeople.org/jspc/jspc-2.0-0.3.alpha.3.fc18.src.rpm
Created attachment 759470 [details] FTBFS - BuildLog FTBFS on rawhide!!! build.log from mock attached
Sorry about that. Fixed... <snip> Checking for unpackaged file(s): /usr/lib/rpm/check-files /builddir/build/BUILDROOT/jspc-2.0-0.4.alpha.3.fc20.x86_64 Wrote: /builddir/build/RPMS/jspc-2.0-0.4.alpha.3.fc20.noarch.rpm Wrote: /builddir/build/RPMS/jspc-compilers-2.0-0.4.alpha.3.fc20.noarch.rpm Wrote: /builddir/build/RPMS/jspc-compiler-tomcat6-2.0-0.4.alpha.3.fc20.noarch.rpm Wrote: /builddir/build/RPMS/jspc-maven-plugin-2.0-0.4.alpha.3.fc20.noarch.rpm Wrote: /builddir/build/RPMS/jspc-javadoc-2.0-0.4.alpha.3.fc20.noarch.rpm Executing(%clean): /bin/sh -e /var/tmp/rpm-tmp.kNYvPd + umask 022 + cd /builddir/build/BUILD + cd jspc + /usr/bin/rm -rf /builddir/build/BUILDROOT/jspc-2.0-0.4.alpha.3.fc20.x86_64 + exit 0 Child return code was: 0 LEAVE do --> Latest at... Spec: http://pmackinn.fedorapeople.org/jspc/jspc.spec SRPM: http://pmackinn.fedorapeople.org/jspc/jspc-2.0-0.4.alpha.3.fc18.src.rpm
F19 for completeness... Wrote: /builddir/build/RPMS/jspc-2.0-0.4.alpha.3.fc19.noarch.rpm Wrote: /builddir/build/RPMS/jspc-compilers-2.0-0.4.alpha.3.fc19.noarch.rpm Wrote: /builddir/build/RPMS/jspc-compiler-tomcat6-2.0-0.4.alpha.3.fc19.noarch.rpm Wrote: /builddir/build/RPMS/jspc-maven-plugin-2.0-0.4.alpha.3.fc19.noarch.rpm Wrote: /builddir/build/RPMS/jspc-javadoc-2.0-0.4.alpha.3.fc19.noarch.rpm
Package has two issues: * Maven packages should use new style packaging please update or justify. no xmvn binary in F18 will count, when commented about and TODO update after F18 EOLed in spec * incorrect Requires, see in report below ##### Package Review ============== Legend: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Maven packages should use new style packaging Note: If possible update your package to latest guidelines See: https://fedoraproject.org/wiki/Packaging:Java#Apache_Maven ---> please update, least add a comment TODO asap when F18 being EOLed - Fully versioned dependency in subpackages, if present. Note: Missing: Requires: %{name} = %{version}-%{release} in jspc-compilers, jspc-compiler-tomcat6, jspc-maven-plugin See: http://fedoraproject.org/wiki/Packaging/Guidelines#RequiringBasePackage ---> false positve: all pkgs are noarch - incorrect Requires ---> tomcat-lib is pulled by tomcat, needs no explicit dependency. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [-]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in jspc- compilers , jspc-compiler-tomcat6 , jspc-maven-plugin , jspc-javadoc ---> all pkgs are noarch'ed [x]: Package complies to the Packaging Guidelines [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)". Detailed output of licensecheck in /home/bjoern.esser/fedora/review/960720-jspc/licensecheck.txt ---> matches License-tag in spec [x]: License file installed when any subpackage combination is installed. ---> having %doc LICENSE.txt in main- and jdoc-pkg should be enough, but is no blocker, since having LICENSE.txt in all pkgs is OK according to packaging-guidelines. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [!]: Requires correct, justified where necessary. ---> tomcat-lib is pulled by tomcat, needs no explicit dependency. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Large documentation must go in a -doc subpackage. Note: Documentation size is 40960 bytes in 4 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Java: [x]: Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) [x]: Bundled jar/class files should be removed before build Maven: [x]: Pom files have correct Maven mapping Note: Some add_maven_depmap calls found. Please check if they are correct or update to latest guidelines [x]: If package contains pom.xml files install it (including depmaps) even when building with ant [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). ---> see above [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. Java: [x]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: jspc-2.0-0.4.alpha.3.fc20.noarch.rpm jspc-compilers-2.0-0.4.alpha.3.fc20.noarch.rpm jspc-compiler-tomcat6-2.0-0.4.alpha.3.fc20.noarch.rpm jspc-maven-plugin-2.0-0.4.alpha.3.fc20.noarch.rpm jspc-javadoc-2.0-0.4.alpha.3.fc20.noarch.rpm jspc.noarch: W: spelling-error %description -l en_US precompile -> recompile, p recompile, compiler jspc.noarch: W: spelling-error %description -l en_US pluggable -> plug gable, plug-gable, plugged jspc-compiler-tomcat6.noarch: E: explicit-lib-dependency tomcat-lib 5 packages and 0 specfiles checked; 1 errors, 2 warnings. ---> tomcat-lib, see above Rpmlint (installed packages) ---------------------------- # rpmlint jspc-compiler-tomcat6 jspc-compilers jspc jspc-javadoc js pc-maven-plugin jspc-compiler-tomcat6.noarch: E: explicit-lib-dependency tomcat-lib jspc.noarch: W: spelling-error %description -l en_US precompile -> recompile, p recompile, compiler jspc.noarch: W: spelling-error %description -l en_US pluggable -> plug gable, plug-gable, plugged 5 packages and 0 specfiles checked; 1 errors, 2 warnings. # echo 'rpmlint-done:' Requires -------- jspc-compiler-tomcat6 (rpmlib, GLIBC filtered): jpackage-utils jspc-compilers tomcat tomcat-lib jspc-compilers (rpmlib, GLIBC filtered): jpackage-utils jspc jspc (rpmlib, GLIBC filtered): java jpackage-utils jspc-javadoc (rpmlib, GLIBC filtered): jpackage-utils jspc-maven-plugin (rpmlib, GLIBC filtered): jpackage-utils jspc-compiler-tomcat6 mvn(commons-lang:commons-lang) mvn(org.apache.maven.shared:file-management) mvn(org.codehaus.gmaven:gmaven-mojo) Provides -------- jspc-compiler-tomcat6: jspc-compiler-tomcat6 mvn(org.codehaus.mojo.jspc:jspc) mvn(org.codehaus.mojo.jspc:jspc-compiler-api) mvn(org.codehaus.mojo.jspc:jspc-compiler-tomcat6) mvn(org.codehaus.mojo.jspc:jspc-compilers) mvn(org.codehaus.mojo.jspc:jspc-maven-plugin) jspc-compilers: jspc-compilers mvn(org.codehaus.mojo.jspc:jspc) mvn(org.codehaus.mojo.jspc:jspc-compiler-api) mvn(org.codehaus.mojo.jspc:jspc-compiler-tomcat6) mvn(org.codehaus.mojo.jspc:jspc-compilers) mvn(org.codehaus.mojo.jspc:jspc-maven-plugin) jspc: jspc mvn(org.codehaus.mojo.jspc:jspc) mvn(org.codehaus.mojo.jspc:jspc-compiler-api) mvn(org.codehaus.mojo.jspc:jspc-compiler-tomcat6) mvn(org.codehaus.mojo.jspc:jspc-compilers) mvn(org.codehaus.mojo.jspc:jspc-maven-plugin) jspc-javadoc: jspc-javadoc jspc-maven-plugin: jspc-maven-plugin mvn(org.codehaus.mojo.jspc:jspc) mvn(org.codehaus.mojo.jspc:jspc-compiler-api) mvn(org.codehaus.mojo.jspc:jspc-compiler-tomcat6) mvn(org.codehaus.mojo.jspc:jspc-compilers) mvn(org.codehaus.mojo.jspc:jspc-maven-plugin) Generated by fedora-review 0.4.1 (b2e211f) last change: 2013-04-29 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 960720 ##### Please fix and I'll grant review.
Issues: ======= - Maven packages should use new style packaging xmvn unavailable in F18, TODO comment added to spec (changelog too) - incorrect Requires ---> tomcat-lib is pulled by tomcat, needs no explicit dependency. FIXED INFO: Done(/home/pmackinn/rpmbuild/SRPMS/jspc-2.0-0.5.alpha.3.fc18.src.rpm) Config(fedora-19-x86_64) 6 minutes 14 seconds INFO: Done(/home/pmackinn/rpmbuild/SRPMS/jspc-2.0-0.5.alpha.3.fc18.src.rpm) Config(fedora-rawhide-x86_64) 5 minutes 6 seconds Same location: http://pmackinn.fedorapeople.org/jspc
Package is fine, now! APPROVED!
New Package SCM Request ======================= Package Name: jspc Short Description: Maven plugin for JSP compilation using Jasper (and Glassfish) Owners: pmackinn Branches: f18 f19 f20 InitialCC: java-sig
Git done (by process-git-requests).
F19 built: https://koji.fedoraproject.org/koji/buildinfo?buildID=429001