Bug 961 - sndconfig dumps core without PCI kernel support loaded
Summary: sndconfig dumps core without PCI kernel support loaded
Alias: None
Product: Red Hat Linux
Classification: Retired
Component: sndconfig
Version: 5.2
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: David Lawrence
QA Contact:
Depends On:
TreeView+ depends on / blocked
Reported: 1999-01-25 19:47 UTC by kjw
Modified: 2008-05-01 15:37 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 1999-01-25 20:41:14 UTC

Attachments (Terms of Use)

Description kjw 1999-01-25 19:47:17 UTC
sndconfig will dump core (seg fault) if the kernel doesn't
have pci support linked in.  The fix is a one-line change:

oops, this patch is backwards, but I can't get another
diff -u generated until tomorrow.  You can see it's a simple
fix, though; it just doesn't detect the -1 return from the
pciProbeDevice, so it needs to check n<1 instead of the
erroneous !n.

--- pnpconf.c   Sat Jan 23 23:05:16 1999
+++ pnpconf.c-  Sat Jan 23 23:05:03 1999
@@ -305,7 +305,7 @@
     int i,n;

     n = pciProbeDevice(PCI_AUDIO, &devs);
-    if (n<1) {
+    if (!n) {
       return -1;
     /* We don't support more than one card anywhere
else;    */

Comment 1 Bill Nottingham 1999-01-25 20:41:59 UTC
This can be worked around by running sndconfig with '--noprobe'
(of course, that turns off the isapnp probe as well.)

Fixed in sndconfig-0.29-5.

Note You need to log in before you can comment on or make changes to this bug.