Bug 961445 - Review Request: mingw-winstorecompat - MinGW library to help porting to Windows Store
Summary: Review Request: mingw-winstorecompat - MinGW library to help porting to Windo...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Sandro Mani
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-05-09 16:03 UTC by Erik van Pienbroek
Modified: 2013-06-01 03:16 UTC (History)
4 users (show)

Fixed In Version: mingw-winstorecompat-2.0.999-0.2.trunk.20130520.fc19
Clone Of:
Environment:
Last Closed: 2013-06-01 03:16:14 UTC
Type: Bug
Embargoed:
manisandro: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Erik van Pienbroek 2013-05-09 16:03:38 UTC
Spec URL: http://svn.nntpgrab.nl/svn/fedora_cross/mingw-winstorecompat/mingw-winstorecompat.spec
SRPM URL: http://kojipkgs.fedoraproject.org//work/tasks/6073/5356073/mingw-winstorecompat-2.0.999-0.1.trunk.20130509.fc20.src.rpm
Koji scratch build: http://koji.fedoraproject.org/koji/buildinfo?buildID=406915

Description:
This library can be linked to code targetting Windows Store.
Functions that are not available anymore for Windows Store are redefined,
using similar functions that are allowed.
'Forbidden' functions can be found either by browsing MSDN, either by
running WACK (Windows Application Certification Kit) on the application.

Comment 1 Sandro Mani 2013-05-12 21:48:03 UTC
One observation only: should the packages be called mingw{32,64}-winstorecompat-static, since the contents is actually a static library?

Otherwise all ok!

Comment 2 Erik van Pienbroek 2013-05-19 16:03:41 UTC
Strictly speaking I would say yes. However, this package is a bit special as it is only available as static library (it replaces various win32 api functions which isn't possible when using shared libraries). We've also got the same situation with the mingw-crt package. This package also contains various static libraries which are part of the main mingw-w64 toolchain and are used by all mingw binaries. Therefore we also can't use shared libraries there

Comment 3 Sandro Mani 2013-05-19 16:14:31 UTC
Could you re-upload the SRPM? The koji package was deleted in the meantime.

Comment 5 Sandro Mani 2013-05-19 16:43:58 UTC
All ok, approved!

Btw, I'd appreciate it if you could finish reviewing #916797 :)

Comment 6 Erik van Pienbroek 2013-05-19 19:16:13 UTC
Thanks for the review!

New Package SCM Request
=======================
Package Name: mingw-winstorecompat
Short Description: MinGW library to help porting to Windows Store
Owners: epienbro ktietz
Branches: f18 f19
InitialCC:

Comment 7 Gwyn Ciesla 2013-05-20 13:40:46 UTC
Git done (by process-git-requests).

Comment 8 Fedora Update System 2013-05-21 17:45:18 UTC
mingw-winstorecompat-2.0.999-0.2.trunk.20130520.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/mingw-winstorecompat-2.0.999-0.2.trunk.20130520.fc19

Comment 9 Fedora Update System 2013-05-22 22:38:33 UTC
mingw-winstorecompat-2.0.999-0.2.trunk.20130520.fc19 has been pushed to the Fedora 19 testing repository.

Comment 10 Fedora Update System 2013-06-01 03:16:14 UTC
mingw-winstorecompat-2.0.999-0.2.trunk.20130520.fc19 has been pushed to the Fedora 19 stable repository.


Note You need to log in before you can comment on or make changes to this bug.