Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 961691

Summary:	CLI crash upon executing "gluster peer status " command
Product:	[Community] GlusterFS	Reporter:	santosh pradhan <spradhan>
Component:	cli	Assignee:	santosh pradhan <spradhan>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	high	Docs Contact:
Priority:	high
Version:	mainline	CC:	gluster-bugs, rhs-bugs, shmohan, spradhan, surs, vagarwal, vbellur
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.4.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	960946	Environment:
Last Closed:	2013-07-24 17:10:48 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	960946
Bug Blocks:

Comment 1 Anand Avati 2013-05-10 09:46:06 UTC

REVIEW: http://review.gluster.org/4976 (gluster/CLI: crash upon executing "peer status" command) posted (#2) for review on master by Santosh Pradhan (spradhan)

Comment 2 Anand Avati 2013-05-10 12:39:22 UTC

COMMIT: http://review.gluster.org/4976 committed in master by Vijay Bellur (vbellur) 
------
commit fef1270fc2d665c67084c4ce06f60fc8faed4d52
Author: Santosh Kumar Pradhan <spradhan>
Date:   Fri May 10 14:31:27 2013 +0530

    gluster/CLI: crash upon executing "peer status" command
    
    Problem:
    While doing "gluster peer status", cli_cmd_peer_status_cbk() creates
    the frame and passes as arg to gf_cli_list_friends() which sets
    frame->local to GF_CLI_LIST_PEERS flag (value: 0x1). It expects
    gf_cli_list_friends_cbk() [invoked through cli_cmd_submit()] to
    reset frame->local to NULL. But if cli_cmd_submit() fails some
    where before gf_cli_list_friends_cbk() gets invoked, then the
    flag value remains in frame->local and causes a SEGV while
    destroying the stack i.e. [CLI_STACK_DESTROY => cli_local_wipe()].
    
    Fix:
    In gf_cli_list_friends(), if cli_cmd_submit() fails, then
    reset the value of frame->local to NULL.
    
    Change-Id: Ied19f07eaf67e3bd42c75cdc2ff3729b0789e632
    BUG: 961691
    Signed-off-by: Santosh Kumar Pradhan <spradhan>
    Reviewed-on: http://review.gluster.org/4976
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 3 santosh pradhan 2013-05-13 06:35:19 UTC

Already submitted to mainline.

Comment 4 Sachidananda Urs 2013-05-13 06:42:12 UTC

Please update Fixed in Version field before moving to ON_QA

Comment 5 Anand Avati 2013-09-05 10:39:25 UTC

REVIEW: http://review.gluster.org/5811 (gluster/CLI: crash upon executing "peer status" command) posted (#1) for review on release-3.4 by Vijay Bellur (vbellur)

Comment 6 Anand Avati 2013-09-05 15:13:11 UTC

REVIEW: http://review.gluster.org/5811 (gluster/CLI: crash upon executing "peer status" command) posted (#2) for review on release-3.4 by Vijay Bellur (vbellur)

Comment 7 Anand Avati 2013-09-06 04:27:14 UTC

REVIEW: http://review.gluster.org/5811 (gluster/CLI: crash upon executing "peer status" command) posted (#3) for review on release-3.4 by Vijay Bellur (vbellur)

Comment 8 Anand Avati 2013-09-06 07:43:10 UTC

REVIEW: http://review.gluster.org/5811 (gluster/CLI: crash upon executing "peer status" command) posted (#4) for review on release-3.4 by Vijay Bellur (vbellur)

Comment 9 Anand Avati 2013-09-07 15:01:27 UTC

REVIEW: http://review.gluster.org/5811 (gluster/CLI: crash upon executing "peer status" command) posted (#5) for review on release-3.4 by Vijay Bellur (vbellur)

Comment 10 Anand Avati 2013-09-10 00:23:29 UTC

COMMIT: http://review.gluster.org/5811 committed in release-3.4 by Anand Avati (avati) 
------
commit ddcb2409afce17f2720ab8198cf587728b4b3bb4
Author: Santosh Kumar Pradhan <spradhan>
Date:   Fri May 10 14:31:27 2013 +0530

    gluster/CLI: crash upon executing "peer status" command
    
    Problem:
    While doing "gluster peer status", cli_cmd_peer_status_cbk() creates
    the frame and passes as arg to gf_cli_list_friends() which sets
    frame->local to GF_CLI_LIST_PEERS flag (value: 0x1). It expects
    gf_cli_list_friends_cbk() [invoked through cli_cmd_submit()] to
    reset frame->local to NULL. But if cli_cmd_submit() fails some
    where before gf_cli_list_friends_cbk() gets invoked, then the
    flag value remains in frame->local and causes a SEGV while
    destroying the stack i.e. [CLI_STACK_DESTROY => cli_local_wipe()].
    
    Fix:
    In gf_cli_list_friends(), if cli_cmd_submit() fails, then
    reset the value of frame->local to NULL.
    
    Change-Id: Ied19f07eaf67e3bd42c75cdc2ff3729b0789e632
    BUG: 961691
    Signed-off-by: Santosh Kumar Pradhan <spradhan>
    Reviewed-on: http://review.gluster.org/4976
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>
    Reviewed-on: http://review.gluster.org/5811
    Reviewed-by: Anand Avati <avati>