REVIEW: http://review.gluster.org/4976 (gluster/CLI: crash upon executing "peer status" command) posted (#2) for review on master by Santosh Pradhan (spradhan)
COMMIT: http://review.gluster.org/4976 committed in master by Vijay Bellur (vbellur) ------ commit fef1270fc2d665c67084c4ce06f60fc8faed4d52 Author: Santosh Kumar Pradhan <spradhan> Date: Fri May 10 14:31:27 2013 +0530 gluster/CLI: crash upon executing "peer status" command Problem: While doing "gluster peer status", cli_cmd_peer_status_cbk() creates the frame and passes as arg to gf_cli_list_friends() which sets frame->local to GF_CLI_LIST_PEERS flag (value: 0x1). It expects gf_cli_list_friends_cbk() [invoked through cli_cmd_submit()] to reset frame->local to NULL. But if cli_cmd_submit() fails some where before gf_cli_list_friends_cbk() gets invoked, then the flag value remains in frame->local and causes a SEGV while destroying the stack i.e. [CLI_STACK_DESTROY => cli_local_wipe()]. Fix: In gf_cli_list_friends(), if cli_cmd_submit() fails, then reset the value of frame->local to NULL. Change-Id: Ied19f07eaf67e3bd42c75cdc2ff3729b0789e632 BUG: 961691 Signed-off-by: Santosh Kumar Pradhan <spradhan> Reviewed-on: http://review.gluster.org/4976 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur>
Already submitted to mainline.
Please update Fixed in Version field before moving to ON_QA
REVIEW: http://review.gluster.org/5811 (gluster/CLI: crash upon executing "peer status" command) posted (#1) for review on release-3.4 by Vijay Bellur (vbellur)
REVIEW: http://review.gluster.org/5811 (gluster/CLI: crash upon executing "peer status" command) posted (#2) for review on release-3.4 by Vijay Bellur (vbellur)
REVIEW: http://review.gluster.org/5811 (gluster/CLI: crash upon executing "peer status" command) posted (#3) for review on release-3.4 by Vijay Bellur (vbellur)
REVIEW: http://review.gluster.org/5811 (gluster/CLI: crash upon executing "peer status" command) posted (#4) for review on release-3.4 by Vijay Bellur (vbellur)
REVIEW: http://review.gluster.org/5811 (gluster/CLI: crash upon executing "peer status" command) posted (#5) for review on release-3.4 by Vijay Bellur (vbellur)
COMMIT: http://review.gluster.org/5811 committed in release-3.4 by Anand Avati (avati) ------ commit ddcb2409afce17f2720ab8198cf587728b4b3bb4 Author: Santosh Kumar Pradhan <spradhan> Date: Fri May 10 14:31:27 2013 +0530 gluster/CLI: crash upon executing "peer status" command Problem: While doing "gluster peer status", cli_cmd_peer_status_cbk() creates the frame and passes as arg to gf_cli_list_friends() which sets frame->local to GF_CLI_LIST_PEERS flag (value: 0x1). It expects gf_cli_list_friends_cbk() [invoked through cli_cmd_submit()] to reset frame->local to NULL. But if cli_cmd_submit() fails some where before gf_cli_list_friends_cbk() gets invoked, then the flag value remains in frame->local and causes a SEGV while destroying the stack i.e. [CLI_STACK_DESTROY => cli_local_wipe()]. Fix: In gf_cli_list_friends(), if cli_cmd_submit() fails, then reset the value of frame->local to NULL. Change-Id: Ied19f07eaf67e3bd42c75cdc2ff3729b0789e632 BUG: 961691 Signed-off-by: Santosh Kumar Pradhan <spradhan> Reviewed-on: http://review.gluster.org/4976 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> Reviewed-on: http://review.gluster.org/5811 Reviewed-by: Anand Avati <avati>