Bug 961892 - Compilation chain isn't honouring CFLAGS environment variable
Summary: Compilation chain isn't honouring CFLAGS environment variable
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: build
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
Assignee: Amar Tumballi
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-05-10 16:28 UTC by Justin Clift
Modified: 2015-07-13 04:35 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2013-10-24 07:13:41 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:

Attachments (Terms of Use)

Description Justin Clift 2013-05-10 16:28:37 UTC 
Description of problem:

  As reported by a GlusterFS Community member, the autotools based compilation
  chain isn't honouring any CFLAGS variables set in the environment.

  Seems to be caused by a hard coded override in configure.ac:

    CFLAGS="-g"

  That should probably be:

    CFLAGS+="-g"


Version-Release number of selected component (if applicable):

  Upstream git master as of Friday May 10th 2013.

  commit fef1270fc2d665c67084c4ce06f60fc8faed4d52
Comment 1 Anand Avati 2013-05-10 16:44:20 UTC 
REVIEW: http://review.gluster.org/4979 (Adjust configure.ac to honor existing CFLAGS env variable) posted (#1) for review on master by Justin Clift (jclift)
Comment 2 Anand Avati 2013-07-04 17:35:46 UTC 
REVIEW: http://review.gluster.org/4979 ([PATCH] Adjust configure.ac to honor existing CFLAGS env variable) posted (#2) for review on master by Justin Clift (jclift)
Comment 3 Anand Avati 2013-07-12 00:41:16 UTC 
REVIEW: http://review.gluster.org/4979 (Adjust configure.ac to honor existing CFLAGS env variable) posted (#3) for review on master by Anand Avati (avati)
Comment 4 Anand Avati 2013-07-15 07:16:02 UTC 
COMMIT: http://review.gluster.org/4979 committed in master by Anand Avati (avati) 
------
commit a2a01c565328e57b05a2e4700f402c351adc9372
Author: Justin Clift <jclift>
Date:   Thu Jul 4 18:33:50 2013 +0100

    Adjust configure.ac to honor existing CFLAGS env variable
    
    Change-Id: I43a8defc7a8c0c2d391e7bd2c0b7bebfcc522a2a
    BUG: 961892
    Signed-off-by: Justin Clift <jclift>
    Reviewed-on: http://review.gluster.org/4979
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Anand Avati <avati>
Comment 5 Amar Tumballi 2013-10-24 07:13:41 UTC 
fixed as part of glusterfs-3.4.0 release, and the patch available in master branch too..
Note You need to log in before you can comment on or make changes to this bug.