Spec URL: http://echevemaster.fedorapeople.org/libdbusmenu/libdbusmenu.spec RPMS URL: http://echevemaster.fedorapeople.org/libdbusmenu/libdbusmenu-12.10.2-1.fc18.src.rpm Description: It passes a menu structure across DBus so that a program can create a menu simply without worrying about how it is displayed on the other side of the bus Tested on koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=5366006 Fedora Account System Username: echevemaster
*** Bug 842509 has been marked as a duplicate of this bug. ***
Hi Eduardo, i did a quick overview of your spec file. %dir %{_libdir}/girepository-1.0/ Your package owns the whole folder in -main, -gtk2 and -gtk3 package. But it is already owned by gobject-introspection. Please remove those lines. A detailed review comming soon.
The package needs some work! MUST 1. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v3)", "GPL (v2 or later)", "Unknown or generated". 92 files have unknown license. Detailed output of licensecheck in ------------------------------------------------------------------------ GPL (v2 or later) ----------------- /var/lib/mock/fedora-19-x86_64/root/builddir/build/BUILD/libdbusmenu-12.10.2/libdbusmenu-12.10.2/ltmain.sh /var/lib/mock/fedora-19-x86_64/root/builddir/build/BUILD/libdbusmenu-12.10.2/libdbusmenu-gtk3-12.10.2/ltmain.sh GPL (v3) -------- /var/lib/mock/fedora-19-x86_64/root/builddir/build/BUILD/libdbusmenu-12.10.2/libdbusmenu-12.10.2/tests/glib-server-nomenu.c /var/lib/mock/fedora-19-x86_64/root/builddir/build/BUILD/libdbusmenu-12.10.2/libdbusmenu-12.10.2/tests/json-loader.c /var/lib/mock/fedora-19-x86_64/root/builddir/build/BUILD/libdbusmenu-12.10.2/libdbusmenu-12.10.2/tests/json-loader.h /var/lib/mock/fedora-19-x86_64/root/builddir/build/BUILD/libdbusmenu-12.10.2 <snip> Unknown or generated -------------------- /var/lib/mock/fedora-19-x86_64/root/builddir/build/BUILD/libdbusmenu-12.10.2/libdbusmenu-12.10.2/libdbusmenu-glib/client-marshal.c /var/lib/mock/fedora-19-x86_64/root/builddir/build/BUILD/libdbusmenu-12.10.2/libdbusmenu-12.10.2/libdbusmenu-glib/client-marshal.h /var/lib/mock/fedora-19-x86_64/root/builddir/build/BUILD/libdbusmenu-12.10.2/libdbusmenu-12.10.2/libdbusmenu-glib/client-menuitem.c <snip> ------------------------------------------------------------------------------ detailed output is attached. Your package use GPL (v2 or later) and GPL (v3) which is in one term GPLv2+. So change license field to License: GPLv2+ 2. [!]: Package does not own files or directories owned by other packages. %dir %{_libdir}/girepository-1.0/ Your package owns the whole folder in -main, -gtk2 and -gtk3 package. But it is already owned by gobject-introspection. Please remove those lines. 3. Pls add Requires: %{name} = %{version}-%{release} to -doc subpackage, otherwise it's possible to install the doc package without the main package. Don't use the the isa tag here, this will cause an install error. OTHERS: 4. [rave@mother srpm-unpacked]$ rpmlint -i libdbusmenu.spec libdbusmenu.spec:140: W: macro-in-comment %{buildroot} There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. libdbusmenu.spec:140: W: macro-in-comment %{_libexecdir} There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. libdbusmenu.spec:151: W: macro-in-comment %{buildroot} There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. libdbusmenu.spec:151: W: macro-in-comment %{_libexecdir} There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. libdbusmenu.spec:251: W: macro-in-comment %{_libexecdir} There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. libdbusmenu.spec:62: W: mixed-use-of-spaces-and-tabs (spaces: line 62, tab: line 1) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. 0 packages and 1 specfiles checked; 0 errors, 6 warnings. ------------------------------------------------------------ Pls, fix mixed-use-of-spaces-and-tabs. I prefer spaces, in result the spec file looks same in all editors. The other warning you can easyly fix, change i.e # chrpath --delete %{buildroot}%{_libexecdir}/dbusmenu-dumper to # chrpath --delete %%{buildroot}%%{_libexecdir}/dbusmenu-dumper or remove those comment out lines from spec file. 5. %files docs %doc %{name}-%{version}/README %doc %{name}-%{version}/COPYING %doc %{name}-%{version}/COPYING.2.1 %doc %{name}-%{version}/AUTHORS I propose to simplify it before. %doc README COPYING COPYING.2.1 AUTHORS This installs all the docs to /usr/share/doc/%{name}-%{version}/ . The rest looks good.
Created attachment 753660 [details] licensecheck.txt
Hi Wolfgang, thanks for the review SPEC: http://echevemaster.fedorapeople.org/libdbusmenu/2/libdbusmenu.spec SRPM: http://echevemaster.fedorapeople.org/libdbusmenu/2/libdbusmenu-12.10.2-2.fc18.src.rpm Tested on koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=5431907 (In reply to Wolfgang Ulbrich from comment #3) > The package needs some work! > > MUST > 1. > [!]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses found: > "GPL (v3)", "GPL (v2 or later)", "Unknown or generated". 92 files have > unknown license. Detailed output of licensecheck in > > ------------------------------------------------------------------------ > GPL (v2 or later) > ----------------- > /var/lib/mock/fedora-19-x86_64/root/builddir/build/BUILD/libdbusmenu-12.10.2/ > libdbusmenu-12.10.2/ltmain.sh > /var/lib/mock/fedora-19-x86_64/root/builddir/build/BUILD/libdbusmenu-12.10.2/ > libdbusmenu-gtk3-12.10.2/ltmain.sh This files (ltmain.sh) are part of Gnu Libtool, them have an exception, i quote "As a special exception to the GNU General Public License, if you distribute this file as part of a program or library that is built using GNU Libtool, you may include this file under the same distribution terms that you use for the rest of that program." therefore the application is not GPLv2+ > GPL (v3) > -------- > /var/lib/mock/fedora-19-x86_64/root/builddir/build/BUILD/libdbusmenu-12.10.2/ > libdbusmenu-12.10.2/tests/glib-server-nomenu.c > /var/lib/mock/fedora-19-x86_64/root/builddir/build/BUILD/libdbusmenu-12.10.2/ > libdbusmenu-12.10.2/tests/json-loader.c > /var/lib/mock/fedora-19-x86_64/root/builddir/build/BUILD/libdbusmenu-12.10.2/ > libdbusmenu-12.10.2/tests/json-loader.h > /var/lib/mock/fedora-19-x86_64/root/builddir/build/BUILD/libdbusmenu-12.10.2 > <snip> > Unknown or generated > -------------------- > /var/lib/mock/fedora-19-x86_64/root/builddir/build/BUILD/libdbusmenu-12.10.2/ > libdbusmenu-12.10.2/libdbusmenu-glib/client-marshal.c > /var/lib/mock/fedora-19-x86_64/root/builddir/build/BUILD/libdbusmenu-12.10.2/ > libdbusmenu-12.10.2/libdbusmenu-glib/client-marshal.h > /var/lib/mock/fedora-19-x86_64/root/builddir/build/BUILD/libdbusmenu-12.10.2/ > libdbusmenu-12.10.2/libdbusmenu-glib/client-menuitem.c > <snip> > ----------------------------------------------------------------------------- > - > detailed output is attached. > Your package use GPL (v2 or later) and GPL (v3) which is in one term GPLv2+. > So change license field to > License: GPLv2+ > > 2. > [!]: Package does not own files or directories owned by other packages. > > %dir %{_libdir}/girepository-1.0/ > Your package owns the whole folder in -main, -gtk2 and -gtk3 package. But it > is already owned by gobject-introspection. Please remove those lines. > Fixed in 2 > 3. > Pls add Requires: %{name} = %{version}-%{release} to -doc subpackage, > otherwise it's possible to install the doc package without the main package. > Don't use the the isa tag here, this will cause an install error. > It is usually not desirable for documentation packages to depend on the main packages, because users may want to install the docs before they decide whether they want to install the package. > OTHERS: > 4. > [rave@mother srpm-unpacked]$ rpmlint -i libdbusmenu.spec > libdbusmenu.spec:140: W: macro-in-comment %{buildroot} > There is a unescaped macro after a shell style comment in the specfile. > Macros > are expanded everywhere, so check if it can cause a problem in this case and > escape the macro with another leading % if appropriate. > > libdbusmenu.spec:140: W: macro-in-comment %{_libexecdir} > There is a unescaped macro after a shell style comment in the specfile. > Macros > are expanded everywhere, so check if it can cause a problem in this case and > escape the macro with another leading % if appropriate. > > libdbusmenu.spec:151: W: macro-in-comment %{buildroot} > There is a unescaped macro after a shell style comment in the specfile. > Macros > are expanded everywhere, so check if it can cause a problem in this case and > escape the macro with another leading % if appropriate. > > libdbusmenu.spec:151: W: macro-in-comment %{_libexecdir} > There is a unescaped macro after a shell style comment in the specfile. > Macros > are expanded everywhere, so check if it can cause a problem in this case and > escape the macro with another leading % if appropriate. > > libdbusmenu.spec:251: W: macro-in-comment %{_libexecdir} > There is a unescaped macro after a shell style comment in the specfile. > Macros > are expanded everywhere, so check if it can cause a problem in this case and > escape the macro with another leading % if appropriate. > > libdbusmenu.spec:62: W: mixed-use-of-spaces-and-tabs (spaces: line 62, tab: > line 1) > The specfile mixes use of spaces and tabs for indentation, which is a > cosmetic > annoyance. Use either spaces or tabs for indentation, not both. > > 0 packages and 1 specfiles checked; 0 errors, 6 warnings. > ------------------------------------------------------------ > Pls, fix mixed-use-of-spaces-and-tabs. I prefer spaces, in result the spec > file looks same in all editors. > The other warning you can easyly fix, change i.e > # chrpath --delete %{buildroot}%{_libexecdir}/dbusmenu-dumper > to > # chrpath --delete %%{buildroot}%%{_libexecdir}/dbusmenu-dumper > or remove those comment out lines from spec file. > Yes, i'm sorry for that; I didn't cleanup of my spec, before sending Fixed in 4 > 5. > %files docs > %doc %{name}-%{version}/README > %doc %{name}-%{version}/COPYING > %doc %{name}-%{version}/COPYING.2.1 > %doc %{name}-%{version}/AUTHORS > > I propose to simplify it before. > %doc README COPYING COPYING.2.1 AUTHORS > Remember that i did a split of the packages, and the licenses are in their respectives directories (gtk and gtk3), therefore not accessible from the main flow. I did a workaround in %prep for fix it Fixed in 5 > This installs all the docs to /usr/share/doc/%{name}-%{version}/ . > > The rest looks good.
(In reply to Eduardo Echeverria from comment #5) > > ------------------------------------------------------------------------ > > GPL (v2 or later) > > ----------------- > > /var/lib/mock/fedora-19-x86_64/root/builddir/build/BUILD/libdbusmenu-12.10.2/ > > libdbusmenu-12.10.2/ltmain.sh > > /var/lib/mock/fedora-19-x86_64/root/builddir/build/BUILD/libdbusmenu-12.10.2/ > > libdbusmenu-gtk3-12.10.2/ltmain.sh > This files (ltmain.sh) are part of Gnu Libtool, them have an exception, > > i quote > > "As a special exception to the GNU General Public License, > if you distribute this file as part of a program or library that > is built using GNU Libtool, you may include this file under the > same distribution terms that you use for the rest of that program." > > therefore the application is not GPLv2+ Ok, i agree. > > > > 2. > > [!]: Package does not own files or directories owned by other packages. > > > > %dir %{_libdir}/girepository-1.0/ > > Your package owns the whole folder in -main, -gtk2 and -gtk3 package. But it > > is already owned by gobject-introspection. Please remove those lines. > > > Fixed in 2 You forget to do this for the -gtk2 subpackage, anyway you can do this before uploading to git. > > > 3. > > Pls add Requires: %{name} = %{version}-%{release} to -doc subpackage, > > otherwise it's possible to install the doc package without the main package. > > Don't use the the isa tag here, this will cause an install error. > > > It is usually not desirable for documentation packages to depend on the main > packages, because users may want to install the docs before they decide > whether they want to install the package. Ok, i agree, results comming soon.
APPROVED ! Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [-]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libdbusmenu-jsonloader , libdbusmenu-doc [x]: Package complies to the Packaging Guidelines [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v3)", "GPL (v2 or later)", "Unknown or generated". 92 files have unknown license. Detailed output of licensecheck in /home/rave/962029-libdbusmenu/licensecheck.txt [-]: License file installed when any subpackage combination is installed. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [!]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Large documentation must go in a -doc subpackage. Note: Documentation size is 102400 bytes in 7 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: libdbusmenu-12.10.2-2.fc19.x86_64.rpm libdbusmenu-devel-12.10.2-2.fc19.x86_64.rpm libdbusmenu-gtk2-12.10.2-2.fc19.x86_64.rpm libdbusmenu-gtk3-12.10.2-2.fc19.x86_64.rpm libdbusmenu-gtk2-devel-12.10.2-2.fc19.x86_64.rpm libdbusmenu-gtk3-devel-12.10.2-2.fc19.x86_64.rpm libdbusmenu-jsonloader-12.10.2-2.fc19.x86_64.rpm libdbusmenu-jsonloader-devel-12.10.2-2.fc19.x86_64.rpm libdbusmenu-doc-12.10.2-2.fc19.noarch.rpm libdbusmenu-tools-12.10.2-2.fc19.x86_64.rpm libdbusmenu-gtk2.x86_64: W: no-documentation libdbusmenu-gtk3.x86_64: W: no-documentation libdbusmenu-gtk2-devel.x86_64: W: no-documentation libdbusmenu-gtk3-devel.x86_64: W: no-documentation libdbusmenu-jsonloader.x86_64: W: no-documentation libdbusmenu-jsonloader-devel.x86_64: W: no-documentation libdbusmenu-tools.x86_64: W: spelling-error Summary(en_US) dbusmenu -> ombudsmen 10 packages and 0 specfiles checked; 0 errors, 7 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint libdbusmenu-gtk2-devel libdbusmenu-gtk3 libdbusmenu libdbusmenu-js onloader libdbusmenu-gtk3-devel libdbusmenu-tools libdbusmenu-devel libdbusmenu-doc libdbus menu-jsonloader-devel libdbusmenu-gtk2 libdbusmenu-gtk2-devel.x86_64: W: no-documentation libdbusmenu-gtk3.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libdbusmenu-gtk3.so.4.0.12 /lib64/libpthread.so.0 libdbusmenu-gtk3.x86_64: W: no-documentation libdbusmenu.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libdbusmenu-glib.so.4.0.12 /lib64/libpthread.so.0 libdbusmenu-jsonloader.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libdbusmenu-jsonloader.so.4.0.12 /lib64/libpthread.so.0 libdbusmenu-jsonloader.x86_64: W: no-documentation libdbusmenu-gtk3-devel.x86_64: W: no-documentation libdbusmenu-tools.x86_64: W: spelling-error Summary(en_US) dbusmenu -> businessmen libdbusmenu-jsonloader-devel.x86_64: W: no-documentation libdbusmenu-gtk2.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libdbusmenu-gtk.so.4.0.12 /lib64/libpthread.so.0 libdbusmenu-gtk2.x86_64: W: no-documentation 10 packages and 0 specfiles checked; 0 errors, 11 warnings. # echo 'rpmlint-done:' Requires -------- libdbusmenu-gtk2-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config dbus-glib-devel gtk2-devel libdbusmenu(x86-64) libdbusmenu-gtk.so.4()(64bit) libdbusmenu-gtk2(x86-64) pkgconfig(dbusmenu-glib-0.4) pkgconfig(gdk-pixbuf-2.0) pkgconfig(gtk+-2.0) libdbusmenu-gtk3 (rpmlib, GLIBC filtered): /sbin/ldconfig libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libdbusmenu(x86-64) libdbusmenu-glib.so.4()(64bit) libgdk-3.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-3.so.0()(64bit) libpango-1.0.so.0()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) libdbusmenu (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) libdbusmenu-jsonloader (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libdbusmenu-devel(x86-64) libdbusmenu-glib.so.4()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libjson-glib-1.0.so.0()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) libdbusmenu-gtk3-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config dbus-glib-devel gtk3-devel libdbusmenu(x86-64) libdbusmenu-gtk3(x86-64) libdbusmenu-gtk3.so.4()(64bit) pkgconfig(dbusmenu-glib-0.4) pkgconfig(gdk-pixbuf-2.0) pkgconfig(gtk+-3.0) libdbusmenu-tools (rpmlib, GLIBC filtered): /usr/bin/python2 libc.so.6()(64bit) libdbusmenu(x86-64) libdbusmenu-glib.so.4()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libjson-glib-1.0.so.0()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) libdbusmenu-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config dbus-glib-devel libdbusmenu(x86-64) libdbusmenu-glib.so.4()(64bit) libdbusmenu-doc (rpmlib, GLIBC filtered): libdbusmenu-jsonloader-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libdbusmenu(x86-64) libdbusmenu-jsonloader(x86-64) libdbusmenu-jsonloader.so.4()(64bit) pkgconfig(dbusmenu-glib-0.4) pkgconfig(json-glib-1.0) libdbusmenu-gtk2 (rpmlib, GLIBC filtered): /sbin/ldconfig libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libdbusmenu(x86-64) libdbusmenu-glib.so.4()(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libpango-1.0.so.0()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) Provides -------- libdbusmenu-gtk2-devel: libdbusmenu-gtk2-devel libdbusmenu-gtk2-devel(x86-64) pkgconfig(dbusmenu-gtk-0.4) libdbusmenu-gtk3: libdbusmenu-gtk3 libdbusmenu-gtk3(x86-64) libdbusmenu-gtk3.so.4()(64bit) libdbusmenu: libdbusmenu libdbusmenu(x86-64) libdbusmenu-glib.so.4()(64bit) libdbusmenu-jsonloader: libdbusmenu-jsonloader libdbusmenu-jsonloader(x86-64) libdbusmenu-jsonloader.so.4()(64bit) libdbusmenu-gtk3-devel: libdbusmenu-gtk3-devel libdbusmenu-gtk3-devel(x86-64) pkgconfig(dbusmenu-gtk3-0.4) libdbusmenu-tools: libdbusmenu-tools libdbusmenu-tools(x86-64) libdbusmenu-devel: libdbusmenu-devel libdbusmenu-devel(x86-64) pkgconfig(dbusmenu-glib-0.4) libdbusmenu-doc: libdbusmenu-doc libdbusmenu-jsonloader-devel: libdbusmenu-jsonloader-devel libdbusmenu-jsonloader-devel(x86-64) pkgconfig(dbusmenu-jsonloader-0.4) libdbusmenu-gtk2: libdbusmenu-gtk.so.4()(64bit) libdbusmenu-gtk2 libdbusmenu-gtk2(x86-64) Source checksums ---------------- https://launchpad.net/libdbusmenu/12.10/12.10.2/+download/libdbusmenu-12.10.2.tar.gz : CHECKSUM(SHA256) this package : 9d6ad4a0b918b342ad2ee9230cce8a095eb601cb0cee6ddc1122d0481f9d04c9 CHECKSUM(SHA256) upstream package : 9d6ad4a0b918b342ad2ee9230cce8a095eb601cb0cee6ddc1122d0481f9d04c9 Generated by fedora-review 0.4.1 (b2e211f) last change: 2013-04-29 Buildroot used: fedora-19-x86_64 Command line :/usr/bin/fedora-review -v -m fedora-19-x86_64 -b 962029 -------------------------------------------------------------------------- Eduaro, pls fix some stuff before you upload to git. [!]: Package does not own files or directories owned by other packages. remove %dir %{_libdir}/girepository-1.0/ from -gtk2 subpackage
New Package SCM Request ======================= Package Name: libdbusmenu Short Description: A library that pulling out some code out of indicator-applet Owners: echevemaster Branches: f17 f18 f19 InitialCC:
Git done (by process-git-requests).
libdbusmenu-12.10.2-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/libdbusmenu-12.10.2-2.fc19
libdbusmenu-12.10.2-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/libdbusmenu-12.10.2-2.fc18
libdbusmenu-12.10.2-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/libdbusmenu-12.10.2-2.fc17
libdbusmenu-12.10.2-2.fc19 has been pushed to the Fedora 19 testing repository.
libdbusmenu-12.10.2-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/libdbusmenu-12.10.2-3.fc19
libdbusmenu-12.10.2-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/libdbusmenu-12.10.2-3.fc18
libdbusmenu-12.10.2-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/libdbusmenu-12.10.2-3.fc17
libdbusmenu-12.10.2-3.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.
libdbusmenu-12.10.2-3.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report.
libdbusmenu-12.10.2-3.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report.
Package Change Request ====================== Package Name: libdbusmenu New Branches: epel7 Owners: slaanesh
Comments from the primary maintainers?
Why all my requests for the epel7 libdbusmenu/libindicator/libappindicator have been dropped with no explanation? Is there any reason?