Bug 962225 - libvirt-client update causes suspend on all guests
Summary: libvirt-client update causes suspend on all guests
Alias: None
Product: Fedora
Classification: Fedora
Component: libvirt
Version: 19
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
Assignee: Eric Blake
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: 1033626
TreeView+ depends on / blocked
Reported: 2013-05-12 18:46 UTC by Kevin Fenzi
Modified: 2013-12-31 02:02 UTC (History)
13 users (show)

Fixed In Version: libvirt-
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1033626 (view as bug list)
Last Closed: 2013-12-31 02:02:49 UTC
Type: Bug

Attachments (Terms of Use)

Description Kevin Fenzi 2013-05-12 18:46:21 UTC
When updating libvirt-client, the scriptlets run a '/usr/bin/systemctl try-restart libvirt-guests.service >/dev/null 2>&1 || :' and this causes all my guests to be suspended. 

When there's a bunch of guests this takes a while and disrupts service to them. 

Is there any way it could not do this on upgrade?

Comment 1 Eric Blake 2013-05-13 14:37:58 UTC
Uggh, sounds like a nasty regression; possibly as a result of commit 9c51de2b which was in response to Red Hatbug 957779

Comment 2 Cole Robinson 2013-11-21 20:16:27 UTC
I've posted a patch upstream:


Comment 3 Cole Robinson 2013-11-22 14:35:24 UTC
Upstream now, and backported to upstream f19 and f20 maint branches:

commit d65e0e1466b09964b85c79b8cc78be454df53583
Author: Cole Robinson <crobinso>
Date:   Thu Nov 21 15:04:35 2013 -0500

    spec: Don't save/restore running VMs on libvirt-client update

Comment 4 Jiri Denemark 2013-11-25 15:26:20 UTC
The patch is incomplete, it removes one save/restore iteration on libvirt-client update but unfortunately, there were two iterations so domains are still saved/restored during update (although "just" once).

Comment 5 Jiri Denemark 2013-11-25 16:04:50 UTC
And really fixed upstream by

commit 604f79b3603d6f7d922c7155d67ff9617411e79f
Author: Jiri Denemark <jdenemar>
Date:   Mon Nov 25 16:37:32 2013 +0100

    spec: Don't save/restore running VMs on libvirt-client update
    The previous attempt (commit d65e0e1) removed just one of two
    libvirt-guests restarts that happened on libvirt-client update. Let's
    remove the last one too :-)
    Signed-off-by: Jiri Denemark <jdenemar>

Comment 6 Fedora Update System 2013-12-14 21:19:13 UTC
libvirt- has been submitted as an update for Fedora 19.

Comment 7 Fedora Update System 2013-12-16 22:55:12 UTC
Package libvirt-
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing libvirt-'
as soon as you are able to.
Please go to the following url:
then log in and leave karma (feedback).

Comment 8 Fedora Update System 2013-12-31 02:02:49 UTC
libvirt- has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.