Bug 962451 - Review Request: hibernate-jpa-2.1-api - Java Persistence 2.1 (JSR 338) API
Summary: Review Request: hibernate-jpa-2.1-api - Java Persistence 2.1 (JSR 338) API
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Tom "spot" Callaway
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 962839
TreeView+ depends on / blocked
 
Reported: 2013-05-13 14:15 UTC by gil cattaneo
Modified: 2013-05-26 03:39 UTC (History)
3 users (show)

Fixed In Version: hibernate-jpa-2.1-api-1.0.0-0.1.Draft.16.fc19
Clone Of:
Environment:
Last Closed: 2013-05-25 12:12:19 UTC
Type: ---
Embargoed:
tcallawa: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description gil cattaneo 2013-05-13 14:15:46 UTC
Spec URL: http://gil.fedorapeople.org/hibernate-jpa-2.1-api.spec
SRPM URL: http://gil.fedorapeople.org/hibernate-jpa-2.1-api-1.0.0-0.1.Draft.16.fc18.src.rpm
Description: Hibernate definition of the Java Persistence 2.1 (JSR 338) API.
Fedora Account System Username: gil

Comment 1 gil cattaneo 2013-05-13 14:56:33 UTC
Required by hibernate-validator 5.0.1.Final

Comment 2 Tom "spot" Callaway 2013-05-16 14:40:34 UTC
= Review =

Good:

- rpmlint checks return:

hibernate-jpa-2.1-api.src: W: invalid-url URL: http://www.hibernate.org/ HTTP Error 403: Forbidden
hibernate-jpa-2.1-api.noarch: W: invalid-url URL: http://www.hibernate.org/ HTTP Error 403: Forbidden
hibernate-jpa-2.1-api-javadoc.noarch: W: invalid-url URL: http://www.hibernate.org/ HTTP Error 403: Forbidden

All safe to ignore. Weird, but fine. :)

- package meets naming guidelines
- package meets packaging guidelines
- license (EPL and BSD) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream (675e7365e4c014369aeb62a284644c7fcb9a166e634c7466a05200f71fab1d99)
- package compiles on f19 (noarch)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- -javadocs ok
- nothing in %doc affects runtime
- no need for .desktop file

APPROVED.

Comment 3 gil cattaneo 2013-05-16 14:46:02 UTC
Thanks for the review

New Package SCM Request
=======================
Package Name: hibernate-jpa-2.1-api
Short Description: Java Persistence 2.1 (JSR 338) API
Owners: gil
Branches: f18 f19
InitialCC: java-sig

Comment 4 Gwyn Ciesla 2013-05-16 15:32:07 UTC
Git done (by process-git-requests).

Comment 5 Fedora Update System 2013-05-16 17:24:52 UTC
hibernate-jpa-2.1-api-1.0.0-0.1.Draft.16.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/hibernate-jpa-2.1-api-1.0.0-0.1.Draft.16.fc19

Comment 6 Fedora Update System 2013-05-16 17:42:03 UTC
hibernate-jpa-2.1-api-1.0.0-0.1.Draft.16.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/hibernate-jpa-2.1-api-1.0.0-0.1.Draft.16.fc18

Comment 7 Fedora Update System 2013-05-17 03:29:35 UTC
hibernate-jpa-2.1-api-1.0.0-0.1.Draft.16.fc18 has been pushed to the Fedora 18 testing repository.

Comment 8 Fedora Update System 2013-05-25 12:12:19 UTC
hibernate-jpa-2.1-api-1.0.0-0.1.Draft.16.fc18 has been pushed to the Fedora 18 stable repository.

Comment 9 Fedora Update System 2013-05-26 03:39:49 UTC
hibernate-jpa-2.1-api-1.0.0-0.1.Draft.16.fc19 has been pushed to the Fedora 19 stable repository.


Note You need to log in before you can comment on or make changes to this bug.