Bug 962452 - Review Request: jaxb2-maven-plugin - JAXB-2 Maven Plugin
Summary: Review Request: jaxb2-maven-plugin - JAXB-2 Maven Plugin
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Tom "spot" Callaway
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 962839
TreeView+ depends on / blocked
 
Reported: 2013-05-13 14:19 UTC by gil cattaneo
Modified: 2013-05-26 03:41 UTC (History)
3 users (show)

Fixed In Version: jaxb2-maven-plugin-1.5-1.fc19
Clone Of:
Environment:
Last Closed: 2013-05-25 12:18:18 UTC
Type: ---
Embargoed:
tcallawa: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description gil cattaneo 2013-05-13 14:19:50 UTC
Spec URL: http://gil.fedorapeople.org/jaxb2-maven-plugin.spec
SRPM URL: http://gil.fedorapeople.org/jaxb2-maven-plugin-1.5-1.fc18.src.rpm
Description: Mojo's JAXB-2 Maven plugin is used to create an object graph from
XSDs based on the JAXB 2.1 implementation and to generate XSDs from
JAXB-annotated Java classes.
Fedora Account System Username: gil

Comment 1 gil cattaneo 2013-05-13 14:55:58 UTC
Required by hibernate-validator 5.0.1.Final

Comment 2 Tom "spot" Callaway 2013-05-16 14:31:58 UTC
= Review =

Good:

- rpmlint checks return:

jaxb2-maven-plugin.noarch: W: spelling-error %description -l en_US Mojo's -> Moho's, Moo's, Mono's
jaxb2-maven-plugin.src: W: spelling-error %description -l en_US Mojo's -> Moho's, Moo's, Mono's
jaxb2-maven-plugin.src: W: invalid-url Source0: jaxb2-maven-plugin-1.5-src-svn.tar.gz

All safe to ignore.

- package meets naming guidelines
- package meets packaging guidelines
- license (ASL 2.0) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream (manual diff due to SVN source)
- package compiles on f19 (noarch)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- -javadocs ok
- nothing in %doc affects runtime
- no need for .desktop file

APPROVED.

Comment 3 gil cattaneo 2013-05-16 14:35:36 UTC
Thanks for the review

New Package SCM Request
=======================
Package Name: jaxb2-maven-plugin
Short Description: JAXB-2 Maven Plugin
Owners: gil
Branches: f18 f19
InitialCC: java-sig

Comment 4 Gwyn Ciesla 2013-05-16 15:32:40 UTC
Git done (by process-git-requests).

Comment 5 Fedora Update System 2013-05-16 16:19:00 UTC
jaxb2-maven-plugin-1.5-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/jaxb2-maven-plugin-1.5-1.fc19

Comment 6 Fedora Update System 2013-05-16 16:55:42 UTC
jaxb2-maven-plugin-1.5-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/jaxb2-maven-plugin-1.5-1.fc18

Comment 7 Fedora Update System 2013-05-17 03:25:06 UTC
jaxb2-maven-plugin-1.5-1.fc18 has been pushed to the Fedora 18 testing repository.

Comment 8 Fedora Update System 2013-05-25 12:18:18 UTC
jaxb2-maven-plugin-1.5-1.fc18 has been pushed to the Fedora 18 stable repository.

Comment 9 Fedora Update System 2013-05-26 03:41:35 UTC
jaxb2-maven-plugin-1.5-1.fc19 has been pushed to the Fedora 19 stable repository.


Note You need to log in before you can comment on or make changes to this bug.