Bug 962470 - Review Request: cdi-api11 - CDI APIs
Summary: Review Request: cdi-api11 - CDI APIs
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Tom "spot" Callaway
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 962839
TreeView+ depends on / blocked
 
Reported: 2013-05-13 14:53 UTC by gil cattaneo
Modified: 2013-06-03 19:29 UTC (History)
3 users (show)

Fixed In Version: cdi-api11-1.1-1.fc18
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-05-26 03:39:57 UTC
tcallawa: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description gil cattaneo 2013-05-13 14:53:33 UTC
Spec URL: http://gil.fedorapeople.org/cdi-api11.spec
SRPM URL: <srpm info here>
Description: APIs for CDI (Contexts and Dependency Injection for Java EE).
Fedora Account System Username: gil

Required by hibernate-validator 5.0.1.Final

Comment 2 Tom "spot" Callaway 2013-05-16 14:18:55 UTC
Review was done on the cdi-api11 package.

= Review =

Good:

- rpmlint checks return nothing
- package meets naming guidelines
- package meets packaging guidelines
- license (ASL 2.0) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream (487632079089c4f48ef20578a15f1cd24b396c06e5f9f925e636a5b953585e21)
- package compiles on f19 (noarch)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- -javadocs ok
- nothing in %doc affects runtime
- no need for .desktop file

APPROVED.

Comment 3 gil cattaneo 2013-05-16 14:33:33 UTC
Thanks for the review

New Package SCM Request
=======================
Package Name: cdi-api11
Short Description: CDI APIs
Owners: gil
Branches: f18 f19
InitialCC: java-sig

Comment 4 Gwyn Ciesla 2013-05-16 15:34:04 UTC
Git done (by process-git-requests).

Comment 5 Fedora Update System 2013-05-16 17:37:24 UTC
cdi-api11-1.1-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/cdi-api11-1.1-1.fc19

Comment 6 Fedora Update System 2013-05-16 17:55:54 UTC
cdi-api11-1.1-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/cdi-api11-1.1-1.fc18

Comment 7 Fedora Update System 2013-05-17 22:20:54 UTC
cdi-api11-1.1-1.fc19 has been pushed to the Fedora 19 testing repository.

Comment 8 Fedora Update System 2013-05-26 03:39:57 UTC
cdi-api11-1.1-1.fc19 has been pushed to the Fedora 19 stable repository.

Comment 9 Fedora Update System 2013-05-27 00:29:57 UTC
cdi-api11-1.1-1.fc18 has been pushed to the Fedora 18 stable repository.


Note You need to log in before you can comment on or make changes to this bug.