Bug 962473 - Review Request: bean-validation-api11 - Bean Validation API (JSR 349)
Summary: Review Request: bean-validation-api11 - Bean Validation API (JSR 349)
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Tom "spot" Callaway
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 962839
TreeView+ depends on / blocked
 
Reported: 2013-05-13 14:58 UTC by gil cattaneo
Modified: 2013-06-03 19:29 UTC (History)
3 users (show)

Fixed In Version: bean-validation-api11-1.1.0-1.fc18
Clone Of:
Environment:
Last Closed: 2013-05-26 03:38:54 UTC
Type: ---
Embargoed:
tcallawa: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description gil cattaneo 2013-05-13 14:58:04 UTC
Spec URL: http://gil.fedorapeople.org/beanvalidation-api.spec
SRPM URL: http://gil.fedorapeople.org/beanvalidation-api-1.1.0-1.fc18.src.rpm
Description: This package contains Bean Validation (JSR 349) API.
Fedora Account System Username: gil
Required by hibernate-validator 5.0.1.Final

Comment 2 Tom "spot" Callaway 2013-05-16 14:15:21 UTC
Review was done on the bean-validation-api11 package.

= Review =

Good:

- rpmlint checks return nothing
- package meets naming guidelines
- package meets packaging guidelines
- license (ASL 2.0) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream (6a60ccc311363fbcb6ad09d88a6bcbfad37e4b3194bd2d0ba7a96b9d2f6f5ee9)
- package compiles on f19 (noarch)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- -javadocs ok
- nothing in %doc affects runtime
- no need for .desktop file

APPROVED. Nice work.

Comment 3 gil cattaneo 2013-05-16 14:20:40 UTC
New Package SCM Request
=======================
Package Name: bean-validation-api11
Short Description: Bean Validation API (JSR 349)
Owners: gil
Branches: f18 f19
InitialCC: java-sig

Comment 4 Gwyn Ciesla 2013-05-16 15:34:53 UTC
Git done (by process-git-requests).

Comment 5 Fedora Update System 2013-05-16 17:36:16 UTC
bean-validation-api11-1.1.0-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/bean-validation-api11-1.1.0-1.fc19

Comment 6 Fedora Update System 2013-05-16 17:53:20 UTC
bean-validation-api11-1.1.0-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/bean-validation-api11-1.1.0-1.fc18

Comment 7 Fedora Update System 2013-05-17 22:23:03 UTC
bean-validation-api11-1.1.0-1.fc19 has been pushed to the Fedora 19 testing repository.

Comment 8 Fedora Update System 2013-05-26 03:38:54 UTC
bean-validation-api11-1.1.0-1.fc19 has been pushed to the Fedora 19 stable repository.

Comment 9 Fedora Update System 2013-05-27 00:28:32 UTC
bean-validation-api11-1.1.0-1.fc18 has been pushed to the Fedora 18 stable repository.


Note You need to log in before you can comment on or make changes to this bug.