Red Hat Bugzilla – Bug 962576
PassSync fails to open changelog
Last modified: 2013-05-13 19:22:28 EDT
This bug is created as a clone of upstream ticket:
We have seen some instances of PassSync failing to open it's changelog (passhook.dat) even though it exists. In the PassSync log, you will see looping messages like this:
04/21/13 18:02:49: No entries yet
04/22/13 05:55:49: No entries yet
04/22/13 06:11:24: No entries yet
04/22/13 06:47:02: No entries yet
04/22/13 07:51:44: No entries yet
If you look in the PassSync code, this message only occurs when we attempt to run SyncPasswords(), which is only executed on start-up, or when we receive a notification from passhook.dll. The fact that this message loops without PassSync restarting means that passhook.dll is writing changes to the changelog and properly notifying PassSync that we need to process the changes. If you trace the code further, you will see that "No entries yet" only occurs when loadSet() returns 1. The loadSet() function only returns 1 when the open() fails with ENOENT.
When this problem happens, we know that the changelog file exists since passhook.dll is writing changes there and notifying us. This leads me to believe that PassSync is using an incorrect filename when it tries to open the changelog. The filename is built up dynamically when PassSync is started. It is made of of the "%SystemRoot%" environment variable plus a hard coded path:
ExpandEnvironmentStrings("%SystemRoot%", sysPath, SYNCSERV_BUF_SIZE);
_snprintf(dataFilename, SYNCSERV_BUF_SIZE, "%s\\system32\\passhook.dat", sysPath);
I believe that "%SystemRoot%" is not being properly expanded when this problem occurs, but I'm not sure what triggers this to happen. Regardless, I think we need to handle things better when this expansion fails. If we can't expand this variable, we should probably fail to start the PassSync service. It would also be helpful to log the filename we are using when we encounter a problem like the ENOENT error.