Bug 963016 - Please drop the gettext dep
Summary: Please drop the gettext dep
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: libvirt
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Libvirt Maintainers
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-05-15 01:40 UTC by Matthias Clasen
Modified: 2013-05-15 03:09 UTC (History)
10 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-05-15 02:09:30 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Matthias Clasen 2013-05-15 01:40:45 UTC
It is documented as 'needed for the libvirt-guests initscript'.

However, that initscript doesn't exist anymore, and the systemd service file shows no signs of needing gettext.

Comment 1 Eric Blake 2013-05-15 02:09:30 UTC
The systemd service file calls into the /usr/libexec/libvirt-guests.sh shell script, and THAT file DOES deppend on gettext.  Basically, when we moved from initscripts to systemd, we migrated what used to be the init script into a standalone shell script that both initscripts and systemd could reuse.

As such, I'm closing this as not a bug; the dependency on gettext is intentional.

Comment 2 Eric Blake 2013-05-15 03:09:14 UTC
That said, I did make this upstream tweak to fix the comment.

commit 9615ca59c6ec41fc2f41b2b89087ff1cacfd1dec
Author: Eric Blake <eblake>
Date:   Tue May 14 20:14:34 2013 -0600

    spec: fix outdated comment
    
    https://bugzilla.redhat.com/show_bug.cgi?id=963016 points out that
    we don't use initscripts by default on Fedora any more.
    
    * libvirt.spec.in (Requires): Better explanation of gettext.
    
    Signed-off-by: Eric Blake <eblake>


Note You need to log in before you can comment on or make changes to this bug.