Bug 963198 - Please drop /etc/sysconfig/modules/kvm.modules from qemu-system-x86
Summary: Please drop /etc/sysconfig/modules/kvm.modules from qemu-system-x86
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: qemu
Version: 19
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Paolo Bonzini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: WhyWeBootSoSlow
TreeView+ depends on / blocked
 
Reported: 2013-05-15 11:26 UTC by Lennart Poettering
Modified: 2013-06-01 03:21 UTC (History)
9 users (show)

Fixed In Version: qemu-1.4.2-2.fc19
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-05-18 04:54:11 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Lennart Poettering 2013-05-15 11:26:53 UTC
The KVM kernel modules can do CPU-feature based kernel module auto-loading anyway these days, so there's no need for any special userspace magic in userspace anymore:

$ modinfo kvm-intel
...
alias:          x86cpu:vendor:*:family:*:model:*:feature:*0085*
...

$ modinfo kvm-amd
...
alias:          x86cpu:vendor:*:family:*:model:*:feature:*00C2*
...

Comment 1 Fedora Update System 2013-05-15 22:05:44 UTC
qemu-1.4.1-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/qemu-1.4.1-2.fc19

Comment 2 Paolo Bonzini 2013-05-16 09:33:45 UTC
What about vhost-net?  Is there a way to load it without relying on fedora-load-modules.service?

Comment 3 Paolo Bonzini 2013-05-16 09:45:55 UTC
Ah, learnt about modules-load.d.

Comment 4 Fedora Update System 2013-05-16 11:01:17 UTC
qemu-1.4.1-3.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/qemu-1.4.1-3.fc19

Comment 5 Lennart Poettering 2013-05-16 11:42:17 UTC
$ modinfo vhost-net
...
alias:          devname:vhost-net
alias:          char-major-10-238
...

That suggests vhost-net is also auto-loaded on demand.

Also see:

   cat /usr/lib/modules/`uname -r`/modules.devname

Which shows all device nodes that are created by udev, and which the kernel then will auto-load modules for. As you see both uinput and vhost_net are listed there. Hence, please do not do any manual module loading anymore, neither via /etc/sysconfig/modules/* nor via /usr/lib/modules-load.d/. This all is unnecessary.

Comment 6 Paolo Bonzini 2013-05-16 12:19:22 UTC
Yup, thanks Lennart.

I removed vhost-net from the script.

Only PPC and s390 remain, and I've asked the upstream KVM maintainers to add a devname:kvm alias.  (On x86, the kvm module that implements devname:kvm is better picked up as a dependency of kvm-{amd,intel}).

Comment 7 Fedora Update System 2013-05-16 17:22:44 UTC
Package qemu-1.4.1-3.fc19:
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing qemu-1.4.1-3.fc19'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-8354/qemu-1.4.1-3.fc19
then log in and leave karma (feedback).

Comment 8 Fedora Update System 2013-05-18 04:54:11 UTC
qemu-1.4.1-3.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2013-05-25 19:44:12 UTC
qemu-1.4.2-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/qemu-1.4.2-1.fc19

Comment 10 Fedora Update System 2013-05-27 13:13:51 UTC
qemu-1.4.2-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/qemu-1.4.2-2.fc19

Comment 11 Fedora Update System 2013-06-01 03:21:07 UTC
qemu-1.4.2-2.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.