Bug 965432 - edit-node should offer fallback if isoname doesn't follow NVRA
Summary: edit-node should offer fallback if isoname doesn't follow NVRA
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: oVirt
Classification: Retired
Component: ovirt-node
Version: 3.2
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: ---
Assignee: Fabian Deutsch
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-05-21 08:55 UTC by Fabian Deutsch
Modified: 2013-11-28 11:57 UTC (History)
6 users (show)

Fixed In Version: ovirt-node-3.0.3
Clone Of:
Environment:
Last Closed: 2013-11-28 11:57:02 UTC
oVirt Team: ---
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 14970 0 None None None Never

Description Fabian Deutsch 2013-05-21 08:55:12 UTC 
Description of problem:
edit-node currently expects the filename of the original iso file to follow NVRA naming scheme, but it's not always the cased.
edit-node should have a fallback mechanism if the detection of NVRA (and buiölding the new iso name) fails.

The error looks like (with e.g. rhevh.iso):

Traceback (most recent call last):
File "./git/ovirt-node/tools/edit-node", line 1637, in <module>
  sys.exit(main())
File "./git/ovirt-node/tools/edit-node", line 1526, in main
  finished_iso = build_isoname_for_plugins(edited_iso, [n])
File "./git/ovirt-node/tools/edit-node", line 1614, in build_isoname_for_plugins
  nvra = isoname_to_nvr(editname_prefix)
File "./git/ovirt-node/tools/edit-node", line 1584, in isoname_to_nvr
  return filename_to_nvra(newfn)
File "./git/ovirt-node/tools/edit-node", line 1565, in filename_to_nvra
  v = nvra_.pop()
IndexError: pop from empty list
Comment 1 Fabian Deutsch 2013-05-22 09:05:35 UTC 
http://gerrit.ovirt.org/#/c/14970/
Note You need to log in before you can comment on or make changes to this bug.