Description of problem: http://fedoraproject.org/wiki/Packaging:Guidelines#PIE says that "you MUST enable the PIE compiler flags if your package has suid binaries...". However, currently nagios-plugins is not being built with PIE flags. This is a clear violation of the packaging guidelines. This issue (in its wider scope) is being discussed at, https://fedorahosted.org/fesco/ticket/1104 https://lists.fedoraproject.org/pipermail/devel/2013-March/180827.html Version-Release number of selected component (if applicable): nagios-plugins-dhcp-1.4.16-6.fc19.x86_64.rpm How reproducible: You can use following programs to check if a package is hardened: http://people.redhat.com/sgrubb/files/rpm-chksec OR https://github.com/kholia/checksec Steps to Reproduce: Get scanner.py from https://github.com/kholia/checksec $ ./scanner.py nagios-plugins-dhcp-1.4.16-6.fc19.x86_64.rpm nagios-plugins-dhcp,nagios-plugins-dhcp-1.4.16-6.fc19.x86_64.rpm,/usr/lib64/nagios/plugins/check_dhcp,mode=0104750,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=network-ip
Just added %global _hardened_build 1 to the specfile. This solves the problem for Fedora 18, 19, and rawhide but not for EPEL6.
nagios-plugins-1.4.16-7.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nagios-plugins-1.4.16-7.fc19
nagios-plugins-1.4.16-7.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/nagios-plugins-1.4.16-7.fc18
>> This solves the problem for Fedora 18, 19, and rawhide but not for EPEL6. What happens under EPEL 6? Does the build fail? If yes, can you post more details?
(In reply to Dhiru Kholia from comment #4) > >> This solves the problem for Fedora 18, 19, and rawhide but not for EPEL6. > > What happens under EPEL 6? Does the build fail? If yes, can you post more > details? The EPEL6 build completes successfully but the definition "%global _hardened_build 1" appears to be have no effect whatsoever. Steps done: 1 - downloaded the Fedora 20 SRPM from koji to a local mock builder (SL6.4) http://kojipkgs.fedoraproject.org//packages/nagios-plugins/1.4.16/7.fc20/src/nagios-plugins-1.4.16-7.fc20.src.rpm 2 - used mock to build it for EPEL6 x86_64 (and i386) 3 - rpmdev-extract ../nagios-plugins-dhcp-1.4.16-7.el6.x86_64.rpm 4 - checksec.sh --file ./nagios-plugins-dhcp-1.4.16-7.el6.x86_64/usr/lib64/nagios/plugins/check_dhcp Reports: RELRO STACK CANARY NX PIE RPATH RUNPATH FILE No RELRO Canary found NX enabled No PIE Note: For the F18+ builds (Koji RPMs: http://koji.fedoraproject.org/koji/packageinfo?packageID=2594) checksec.sh reports PIE enabled: $ checksec.sh --file ./nagios-plugins-dhcp-1.4.16-7.fc20.x86_64/usr/lib64/nagios/plugins/check_dhcp RELRO STACK CANARY NX PIE RPATH RUNPATH FILE Full RELRO Canary found NX enabled PIE enabled No RPATH No RUNPATH ./nagios-plugins-dhcp-1.4.16-7.fc20.x86_64/usr/lib64/nagios/plugins/check_dhcp
I forgot to mention that I have used the shell script checksec.sh downloaded from http://www.trapkit.de/tools/checksec.htm .
Package nagios-plugins-1.4.16-7.fc18: * should fix your issue, * was pushed to the Fedora 18 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing nagios-plugins-1.4.16-7.fc18' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-8935/nagios-plugins-1.4.16-7.fc18 then log in and leave karma (feedback).
nagios-plugins-1.4.16-7.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report.
nagios-plugins-1.4.16-7.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.