Spec URL: http://shakthimaan.fedorapeople.org/SPECS/cbmc.spec SRPM URL: http://shakthimaan.fedorapeople.org/SRPMS/cbmc-4.3-1.20130515svn.fc17.src.rpm Description: Bounded Model Checker for ANSI-C and C++ programs Fedora Account System Username: shakthimaan
$ rpmlint cbmc.spec cbmc.spec:15: W: mixed-use-of-spaces-and-tabs (spaces: line 15, tab: line 3) /home/shaks/rpmbuild/SPECS/cbmc.spec: W: invalid-url Source0: cbmc-20130515.tar.xz 0 packages and 1 specfiles checked; 0 errors, 2 warnings. $ rpmlint cbmc-4.3-1.20130515svn.fc17.x86_64.rpm cbmc.x86_64: E: explicit-lib-dependency minisat2-libs cbmc.x86_64: W: incoherent-version-in-changelog 4.3-20130515svn ['4.3-1.20130515svn.fc17', '4.3-1.20130515svn'] cbmc.x86_64: W: no-manual-page-for-binary cbmc cbmc.x86_64: W: no-manual-page-for-binary goto-instrument cbmc.x86_64: W: no-manual-page-for-binary goto-cc 1 packages and 0 specfiles checked; 1 errors, 4 warnings. $ rpmlint cbmc-debuginfo-4.3-1.20130515svn.fc17.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint cbmc-4.3-1.20130515svn.fc17.src.rpm cbmc.src:15: W: mixed-use-of-spaces-and-tabs (spaces: line 15, tab: line 3) cbmc.src: W: invalid-url Source0: cbmc-20130515.tar.xz 1 packages and 0 specfiles checked; 0 errors, 2 warnings. Successful Koji builds at: Koji Success f18 http://koji.fedoraproject.org/koji/taskinfo?taskID=5404712 Koji Success f17 http://koji.fedoraproject.org/koji/taskinfo?taskID=5404713 Koji Success f19 http://koji.fedoraproject.org/koji/taskinfo?taskID=5404714 Koji Success f20 http://koji.fedoraproject.org/koji/taskinfo?taskID=5404711
Can anything be done about the rpmlint output?
Which ones in the rpmlint output?
> Which ones in the rpmlint output? These: > $ rpmlint cbmc.spec > cbmc.spec:15: W: mixed-use-of-spaces-and-tabs (spaces: line 15, tab: line 3) > /home/shaks/rpmbuild/SPECS/cbmc.spec: W: invalid-url Source0: > cbmc-20130515.tar.xz > $ rpmlint cbmc-4.3-1.20130515svn.fc17.x86_64.rpm > cbmc.x86_64: E: explicit-lib-dependency minisat2-libs > cbmc.x86_64: W: incoherent-version-in-changelog 4.3-20130515svn > ['4.3-1.20130515svn.fc17', '4.3-1.20130515svn']
Fixed the mixed-use-of-spaces-and-tabs, and incoherent-version-in-changelog rpmlint errors. Since, it is a svn checkout for Source0, a comment has been added explaining how to obtain the sources. SPEC: http://shakthimaan.fedorapeople.org/SPECS/cbmc.spec SRPM: http://shakthimaan.fedorapeople.org/SRPMS/cbmc-4.3-2.20130515svn.fc18.src.rpm $ rpmlint cbmc.spec /home/mbuf/rpmbuild/SPECS/cbmc.spec: W: invalid-url Source0: cbmc-4.3-20130515svn.tar.gz 0 packages and 1 specfiles checked; 0 errors, 1 warnings. $ rpmlint cbmc-4.3-2.20130515svn.fc18.x86_64.rpm cbmc.x86_64: W: no-manual-page-for-binary cbmc cbmc.x86_64: W: no-manual-page-for-binary goto-instrument cbmc.x86_64: W: no-manual-page-for-binary goto-cc 1 packages and 0 specfiles checked; 0 errors, 3 warnings. $ rpmlint cbmc-debuginfo-4.3-2.20130515svn.fc18.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint cbmc-4.3-2.20130515svn.fc18.src.rpm cbmc.src: W: invalid-url Source0: cbmc-4.3-20130515svn.tar.gz 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Successful Koji builds: Koji Success f19 http://koji.fedoraproject.org/koji/taskinfo?taskID=5538769 Koji Success f17 http://koji.fedoraproject.org/koji/taskinfo?taskID=5538773 Koji Success f18 http://koji.fedoraproject.org/koji/taskinfo?taskID=5538765 Koji Success f20 http://koji.fedoraproject.org/koji/taskinfo?taskID=5538766
I think I found some more problems: - license tag should be "BSD with advertising" - I think the build does not set CFLAGS/CXXFLAGS to include the required build flags for Fedora Bad file paths: /usr/share/doc/html-manual /usr/share/man/cbmc.1 and also please check and explain/fix: Rpmlint ------- Checking: cbmc-4.3-2.20130515svn.fc20.x86_64.rpm cbmc.x86_64: E: non-standard-executable-perm /usr/bin/cbmc 0775L cbmc.x86_64: E: non-standard-executable-perm /usr/bin/goto-instrument 0775L cbmc.x86_64: E: non-standard-executable-perm /usr/bin/goto-cc 0775L I think group write is not needed - not sure what L means here.
The license tag and the file paths have been updated. The CFLAGS and CXXFLAGS are set to use ${RPM_OPT_FLAGS}, and the value can be seen in the output. For example: $ rpm --eval "%{optflags}" -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic and at: http://kojipkgs.fedoraproject.org//work/tasks/8770/5538770/build.log The permissions are shown correctly as 755 for the F20 built RPM: $ rpmls cbmc-4.3-2.20130515svn.fc20.x86_64.rpm -rwxr-xr-x /usr/bin/cbmc -rwxr-xr-x /usr/bin/goto-cc -rwxr-xr-x /usr/bin/goto-instrument SPEC: http://shakthimaan.fedorapeople.org/SPECS/cbmc.spec SRPM: http://shakthimaan.fedorapeople.org/SRPMS/cbmc-4.3-3.20130515svn.fc17.src.rpm
Thanks for the update: License and compile flags look good now. BTW you could also use make %{?_smp_mflags} -C src CFLAGS=${RPM_OPT_FLAGS} CXXFLAGS=${RPM_OPT_FLAGS}" instead of patching "src/common". I see in the build.log and srpm rpmlint output: warning: bogus date in %changelog: Sat Jun 30 2013 Shakthi Kannan <shakthimaan [AT] fedoraproject.org> - 4.3-3.20130515svn Please fix the day - though it is not a blocker per se, but otherwise the warning will appearing in every build log. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Permissions on files are set properly. Note: See rpmlint output See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions - Header files in -devel subpackage, if present. Note: cbmc : /usr/share/doc/cbmc-4.3/html-manual/boop-example/driver.h cbmc : /usr/share/doc/cbmc-4.3/html-manual/boop-example/kdev_t.h cbmc : /usr/share/doc/cbmc-4.3/html-manual/boop-example/modules.h See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package complies to the Packaging Guidelines [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 1545 files have unknown license. Detailed output of licensecheck in /home/petersen/pkgreview/965570-cbmc/licensecheck.txt [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [-]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [-]: Large documentation must go in a -doc subpackage. Note: Documentation size is 256000 bytes in 52 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Fully versioned dependency in subpackages, if present. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [ ]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: cbmc-4.3-3.20130515svn.fc20.x86_64.rpm cbmc.x86_64: E: non-standard-executable-perm /usr/bin/cbmc 0775L cbmc.x86_64: E: non-standard-executable-perm /usr/bin/goto-instrument 0775L cbmc.x86_64: E: non-standard-executable-perm /usr/bin/goto-cc 0775L cbmc.x86_64: W: no-manual-page-for-binary goto-instrument cbmc.x86_64: W: no-manual-page-for-binary goto-cc 1 packages and 0 specfiles checked; 3 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint cbmc cbmc.x86_64: E: non-standard-executable-perm /usr/bin/cbmc 0775L cbmc.x86_64: E: non-standard-executable-perm /usr/bin/goto-instrument 0775L cbmc.x86_64: E: non-standard-executable-perm /usr/bin/goto-cc 0775L cbmc.x86_64: W: no-manual-page-for-binary goto-instrument cbmc.x86_64: W: no-manual-page-for-binary goto-cc 1 packages and 0 specfiles checked; 3 errors, 2 warnings. # echo 'rpmlint-done:' Package basically looks fine now except for above rpmlint: You must fix the bindir permissions when importing the package. You can do that either my using "install -p ..." instead of "cp -p" (or possibly by setting the permissions explicitly in the %files). APPROVED (conditional on above change)
Thanks for the review. I have fixed the ChangeLog date, and used "install" for copying the binaries. SPEC: http://shakthimaan.fedorapeople.org/SPECS/cbmc.spec SRPM: http://shakthimaan.fedorapeople.org/SRPMS/cbmc-4.3-4.20130515svn.fc18.src.rpm
New Package SCM Request ======================= Package Name: cbmc Short Description: Bounded Model Checker for ANSI-C and C++ programs Owners: shakthimaan Branches: f17 f18 f19 InitialCC: shakthimaan
Git done (by process-git-requests).
cbmc-4.3-4.20130515svn.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/cbmc-4.3-4.20130515svn.fc18
cbmc-4.3-4.20130515svn.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/cbmc-4.3-4.20130515svn.fc19
cbmc-4.3-4.20130515svn.fc18 has been pushed to the Fedora 18 testing repository.
cbmc-4.3-5.20130515svn.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/cbmc-4.3-5.20130515svn.fc18
cbmc-4.3-5.20130515svn.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/cbmc-4.3-5.20130515svn.fc19
cbmc-4.3-5.20130515svn.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.
cbmc-4.3-5.20130515svn.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report.