Bug 965835 - Review Request: mingw-protobuf - Protocol Buffers - Google's data interchange format
Review Request: mingw-protobuf - Protocol Buffers - Google's data interchange...
Status: CLOSED NOTABUG
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
unspecified Severity medium
: ---
: ---
Assigned To: Nobody's working on this, feel free to take it
Fedora Extras Quality Assurance
:
Depends On:
Blocks: FE-DEADREVIEW
  Show dependency treegraph
 
Reported: 2013-05-21 16:10 EDT by Steve
Modified: 2015-07-21 08:30 EDT (History)
5 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2015-01-09 16:00:31 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Steve 2013-05-21 16:10:30 EDT
Spec URL: https://www.box.com/s/hi6w1pjh12sifyzfjxl3
SRPM URL: https://www.box.com/s/xrej0xxefm5w24ujff09
Description: This is the MinGW version of protobuf, already available as a standard Fedora package.  It's based on the existing protobuf package, and fedora-review found no significant issues, so hopefully approving this package isn't much effort.
Also, hopefully, submitting this package for review isn't considered "spam" -- that's certainly not my intent.
I would like to submit all of the dependencies of the MS Windows version of Mixxx (see http://www.mixxx.org/ for more info), and there are about 12.  The new version of mixxx (1.11.0) has finally been approved on RPMFusion.
Fedora Account System Username: ulatekh
Comment 1 Veaceslav Mindru 2013-07-30 04:15:14 EDT
Hello Steve,


Please remove rm -rf under %install.

>rm -rf %{buildroot}


http://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25install_section 

Following E/W are reported by rpmlint.  


mingw-protobuf.spec:295: W: macro-in-comment %doc
mingw-protobuf.spec:315: W: macro-in-comment %doc
mingw-protobuf.spec:321: W: macro-in-comment %doc
mingw-protobuf.spec:327: W: macro-in-comment %doc
mingw-protobuf.spec:26: W: mixed-use-of-spaces-and-tabs (spaces: line 16, tab: line 26)
Comment 2 Pavol Rusnak 2014-08-03 18:35:47 EDT
I updated the package to follow the latest protobuf (2.5.0):

Spec URL: http://cargo.gk2.sk/mingw-protobuf/mingw-protobuf.spec
SRPM URL: http://cargo.gk2.sk/mingw-protobuf/mingw-protobuf-2.5.0-9.src.rpm

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7236229
Comment 3 František Dvořák 2014-08-16 06:24:30 EDT
It looks like this review is stalled as original submitter haven't responsed for more than a year.

Let's wait one more week according to http://fedoraproject.org/wiki/Policy_for_stalled_package_reviews . After that time this review can be closed. It will be possible to create branch new review request for this package.
Comment 4 Pavol Rusnak 2015-01-09 12:12:31 EST
Bump?
Comment 5 František Dvořák 2015-01-09 16:00:31 EST
Yes, let's close this one. New review can be submitted, if needed.

Note You need to log in before you can comment on or make changes to this bug.