Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 965995

Summary:	quick-read and open-behind xlator: Make options (volume_options ) structure NULL terminated.
Product:	[Community] GlusterFS	Reporter:	santosh pradhan <spradhan>
Component:	quick-read	Assignee:	santosh pradhan <spradhan>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	gluster-bugs, vagarwal
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	glusterfs-3.4.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-07-24 17:20:39 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description santosh pradhan 2013-05-22 09:08:56 UTC

Description of problem:

Make the options (of type volume_options) structure NULL terminated.

Version-Release number of selected component (if applicable):


How reproducible:
N/A

Steps to Reproduce:
1.
2.
3.
N/A.

Actual results:


Expected results:


Additional info:

Comment 1 santosh pradhan 2013-05-22 09:10:45 UTC

Found this while scanned through all the xlator options structure.

Comment 2 Anand Avati 2013-05-22 10:08:44 UTC

REVIEW: http://review.gluster.org/5064 (xlator: NULL termiate volume_options struct) posted (#1) for review on master by Santosh Pradhan (spradhan)

Comment 3 Anand Avati 2013-05-22 12:47:21 UTC

REVIEW: http://review.gluster.org/5064 (xlator: NULL terminate volume_options struct) posted (#2) for review on master by Santosh Pradhan (spradhan)

Comment 4 Anand Avati 2013-05-22 17:33:19 UTC

COMMIT: http://review.gluster.org/5064 committed in master by Vijay Bellur (vbellur) 
------
commit 4df7a3c4888fbf1e1f84246aeac92af396879ce5
Author: Santosh Kumar Pradhan <spradhan>
Date:   Wed May 22 15:26:04 2013 +0530

    xlator: NULL terminate volume_options struct
    
    Problem:
    volume_options struct for open-behind and quick-read xlators
    were not NULL terminated.
    
    Fix:
    Make them NULL terminated.
    
    Change-Id: I2615a1f15c6e5674030a219a99ddf91596bf346b
    BUG: 965995
    Signed-off-by: Santosh Kumar Pradhan <spradhan>
    Reviewed-on: http://review.gluster.org/5064
    Reviewed-by: Kaleb KEITHLEY <kkeithle>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 6 santosh pradhan 2013-05-23 03:50:27 UTC

typo does not need.

Comment 7 Anand Avati 2013-09-05 10:38:27 UTC

REVIEW: http://review.gluster.org/5809 (xlator: NULL terminate volume_options struct) posted (#1) for review on release-3.4 by Vijay Bellur (vbellur)

Comment 8 Anand Avati 2013-09-05 15:14:08 UTC

REVIEW: http://review.gluster.org/5809 (xlator: NULL terminate volume_options struct) posted (#2) for review on release-3.4 by Vijay Bellur (vbellur)

Comment 9 Anand Avati 2013-09-06 04:28:22 UTC

REVIEW: http://review.gluster.org/5809 (xlator: NULL terminate volume_options struct) posted (#3) for review on release-3.4 by Vijay Bellur (vbellur)

Comment 10 Anand Avati 2013-09-06 07:44:09 UTC

REVIEW: http://review.gluster.org/5809 (xlator: NULL terminate volume_options struct) posted (#4) for review on release-3.4 by Vijay Bellur (vbellur)

Comment 11 Anand Avati 2013-09-07 15:02:28 UTC

REVIEW: http://review.gluster.org/5809 (xlator: NULL terminate volume_options struct) posted (#5) for review on release-3.4 by Vijay Bellur (vbellur)

Comment 12 Anand Avati 2013-09-10 00:22:08 UTC

COMMIT: http://review.gluster.org/5809 committed in release-3.4 by Anand Avati (avati) 
------
commit c28b40ebb682eee88c7afa4d64b8e6bfde529668
Author: Santosh Kumar Pradhan <spradhan>
Date:   Wed May 22 15:26:04 2013 +0530

    xlator: NULL terminate volume_options struct
    
    Problem:
    volume_options struct for open-behind and quick-read xlators
    were not NULL terminated.
    
    Fix:
    Make them NULL terminated.
    
    Change-Id: I2615a1f15c6e5674030a219a99ddf91596bf346b
    BUG: 965995
    Signed-off-by: Santosh Kumar Pradhan <spradhan>
    Reviewed-on: http://review.gluster.org/5064
    Reviewed-by: Kaleb KEITHLEY <kkeithle>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>
    Reviewed-on: http://review.gluster.org/5809
    Reviewed-by: Anand Avati <avati>