Red Hat Bugzilla – Bug 966156
Review Request: prwd - A tool can print reduced working directory
Last modified: 2015-07-27 15:10:42 EDT
Spec URL: http://cicku.me/prwd.spec SRPM URL: http://cicku.me/prwd-1.6-1.fc20.src.rpm Description: Most shells read $PS1 differently and have a very rigid way to display the current working directory. prwd allows you to have one way to handle the display of your working directory and use it across multiple shells. It also allows you to keep an eye on your current branch when you enter a project handled by git or mercurial. Fedora Account System Username: cicku
New upstream release: Spec URL: http://cicku.me/prwd.spec SRPM URL: http://cicku.me/prwd-1.7-1.fc20.src.rpm
In %prep: gzip %{name}.1 Don't compress man pages with a certain algorithm. The plain version will be compressed automatically by rpm.
(In reply to Mario Blättermann from comment #2) > In %prep: > gzip %{name}.1 > > Don't compress man pages with a certain algorithm. The plain version will be > compressed automatically by rpm. I'll fix that for all packages. Will you do a review for me? Thanks. Spec URL: http://cicku.me/prwd.spec SRPM URL: http://cicku.me/prwd-1.7-2.fc20.src.rpm
(In reply to Christopher Meng from comment #3) > Will you do a review for me? I'll do the review, but be patient. Probably I don't have time left until next weekend.
Christopher, Always specify which changes you have made in the spec: > * Sun May 26 2013 Christopher Meng <rpm@cicku.me> - 1.7-2 > - Small fixes. "Small fixes" it's not clear.
(In reply to Mario Blättermann from comment #4) > (In reply to Christopher Meng from comment #3) > > Will you do a review for me? > > I'll do the review, but be patient. Probably I don't have time left until > next weekend. Hi Mario, Thanks for your help in this bugzilla. I can conduct it. Cheers Douglas
[OK] MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review. Rpmlint ------- Checking: prwd-1.7-2.fc18.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint prwd 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [OK] MUST: The package must be named according to the Package Naming Guidelines [OK] MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. [OK] MUST: The package must meet the Packaging Guidelines . [OK] MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines . [OK] MUST: The License field in the package spec file must match the actual license. [OK] MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc [OK] MUST: The spec file must be written in American English. [OK] MUST: The spec file for the package MUST be legible. [OK] MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use sha256sum for this task as it is used by the sources file once imported into git. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. CHECKSUM(SHA256) this package : 89373a30c9b4193b973317275f519955537e5b4c8f78b4e25fd606493bdc7e64 CHECKSUM(SHA256) upstream package : 89373a30c9b4193b973317275f519955537e5b4c8f78b4e25fd606493bdc7e64 [OK] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. [OK] MUST: Packages must NOT bundle copies of system libraries [OK] MUST: A Fedora package must not list a file more than once in the spec file's %files listings. (Notable exception: license texts in specific situations) [OK] MUST: Permissions on files must be set properly. [OK] MUST: Each package must consistently use macros. [OK] MUST: The package must contain code, or permissable content [OK] MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built.[ [OK] MUST: Packages must not own files or directories already owned by other packages [OK] MUST: All filenames in rpm packages must be valid UTF-8. [OK]: SHOULD Package functions as described. [OK]: SHOULD Latest version is packaged. [OK]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [OK]: Sources can be downloaded from URI in Source: tag [OK]: Reviewer should test that the package builds in mock. [OK]: Buildroot is not present [OK]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [OK]: Dist tag is present. [OK]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [OK]: Uses parallel make. [OK]: SourceX tarball generation or download is documented. [OK]: SourceX is a working URL. [OK]: Spec use %global instead of %define. Just a comment: ===================== As I suggested in comment#5, please write changelogs with the full changes that you have made instead of using phrases like: "Small fixes". It doesn't help next guy that can work into your rpm. The above minor comment can be fixed in parallel of packaging. Status: APPROVED.
New Package SCM Request ======================= Package Name: prwd Short Description: A tool can print reduced working directory Owners: cicku Branches: f18 f19 el6 InitialCC:
Git done (by process-git-requests).
prwd-1.7-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/prwd-1.7-2.fc19
prwd-1.7-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/prwd-1.7-2.fc18
prwd-1.7-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/prwd-1.7-2.el6
prwd-1.7-2.el6 has been pushed to the Fedora EPEL 6 testing repository.
prwd-1.7-2.fc18 has been pushed to the Fedora 18 stable repository.
prwd-1.7-2.fc19 has been pushed to the Fedora 19 stable repository.
prwd-1.7-2.el6 has been pushed to the Fedora EPEL 6 stable repository.
Package Change Request ====================== Package Name: prwd New Branches: epel7 Owners: cicku