Bug 966379 - pkg-config incorrectly adds libxfce4ui to -I
Summary: pkg-config incorrectly adds libxfce4ui to -I
Keywords:
Status: CLOSED INSUFFICIENT_DATA
Alias: None
Product: Fedora
Classification: Fedora
Component: libxfce4ui
Version: 18
Hardware: x86_64
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Christoph Wickert
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-05-23 08:18 UTC by José Luis González
Modified: 2013-05-24 17:12 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2013-05-24 17:12:15 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Fix for the pkg-config file (318 bytes, patch)
2013-05-23 08:40 UTC, José Luis González
no flags Details | Diff

Description José Luis González 2013-05-23 08:18:58 UTC
Description of problem:

pkg-config adds libxfce4ui at the end of the -I cflag, thus breaking the common practice of #including <libxfce4ui/someheader.h>. As an example, xfce4-timer-plugin version 1.5.0 doesn't compile because of this:

xfcetimer.c:41:35: error fatal: libxfce4ui/libxfce4ui.h: No existe el fichero o el directorio
compilación terminada.
make[2]: *** [xfce4_timer-xfcetimer.o] Error 1

Removing the libxfce4ui addy from libxfce4ui-1.pc makes it work.

Version-Release number of selected component (if applicable):

libxfce4ui-devel-4.10.0-4.fc18.x86_64

How reproducible:

$ pkg-config --cflags libxfce4ui-1
-pthread -I/usr/include/xfce4/libxfce4ui-1/libxfce4ui [...]

vs. for instance

$ pkg-config --cflags libxfce4panel-1.0
-pthread -I/usr/include/xfce4/libxfce4panel-1.0 [...]


Steps to Reproduce:

$ pkg-config --cflags libxfceui-1

or compile a plugin that uses it like xfce4-timer-plugin 1.5.0.

Expected results:

$ pkg-config --cflags libxfce4ui-1
-pthread -I/usr/include/xfce4/libxfce4ui-1 [...]

Comment 1 José Luis González 2013-05-23 08:40:41 UTC
Created attachment 752047 [details]
Fix for the pkg-config file

Comment 2 Kevin Fenzi 2013-05-23 20:40:02 UTC
I'm not seeing this here: 

[root@sheelba ~]# rpm -q libxfce4ui-devel
libxfce4ui-devel-4.10.0-4.fc18.x86_64
[root@sheelba ~]# pkg-config --cflags libxfce4ui-1
-pthread -I/usr/include/xfce4/libxfce4ui-1 ...

Can you do a 'rpm -V libxfce4ui-devel' and check and make sure you don't have any locally compiled versions in /usr/local ?

Comment 3 José Luis González 2013-05-24 07:16:43 UTC
My .pc file was modified to correct the cflags problem, so mtime is changed. Interestingly, the "fixed" size seems to be that of the package:

$ rpm -V libxfce4ui-devel
.......T.    /usr/lib64/pkgconfig/libxfce4ui-1.pc
$ rpm -V --nomtime libxfce4ui-devel

So I don't understand how the libfxfce4ui addy came to my file. I haven't compiled libs in this machine, only a couple of plugins:

$ ls /usr/local/include

And, to the best of my knowledge, never modified any .pc file, besides for fixing this. I had no need to. The whole system (fedora 18 + xfce) was installed from scratch this April, the 24th.

Comment 4 Kevin Fenzi 2013-05-24 15:56:17 UTC
Weird. well, from what I see the problem doesn't exist in the packaged version at all. 

You want to investigate some more? Or shall we close this out?

Comment 5 José Luis González 2013-05-24 17:12:15 UTC
No idea what else to investigate. I think it can be closed.


Note You need to log in before you can comment on or make changes to this bug.