Bug 966427
| Summary: | [RFE] improve confirmation dialog layout (e.g. too short scrolling area in "are you sure" confirmation dialog) | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [oVirt] ovirt-engine | Reporter: | Martin Pavlik <mpavlik> | ||||||||
| Component: | Frontend.WebAdmin | Assignee: | Nobody's working on this, feel free to take it <nobody> | ||||||||
| Status: | CLOSED WONTFIX | QA Contact: | Meni Yakove <myakove> | ||||||||
| Severity: | low | Docs Contact: | |||||||||
| Priority: | medium | ||||||||||
| Version: | --- | CC: | bsettle, bugs, oourfali, rbalakri, Rhev-m-bugs, vszocs, ykaul | ||||||||
| Target Milestone: | --- | Keywords: | FutureFeature, Improvement | ||||||||
| Target Release: | --- | Flags: | ylavi:
ovirt-future?
rule-engine: planning_ack? rule-engine: devel_ack? rule-engine: testing_ack? |
||||||||
| Hardware: | x86_64 | ||||||||||
| OS: | Linux | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | Enhancement | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2017-05-15 05:53:52 UTC | Type: | Bug | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | UX | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Attachments: |
|
||||||||||
Same problem appears in dialog for removing logical networks, see screenshot 2 Created attachment 752060 [details]
screenshot 2
Created attachment 752303 [details]
screen-shot: Remove DataCenter(s) dialog
see attachment 752303 [details] - Remove DataCenter(s) dialog has that same unused space as well -> the problem is not only network-related - it applies probably to all confirmation dialogs in the system, which I assume we manage via the same widget/component -> moving to 'ux'
(In reply to Einav Cohen from comment #4) > see attachment 752303 [details] - Remove DataCenter(s) dialog has that same > unused space as well -> the problem is not only network-related - it applies > probably to all confirmation dialogs in the system, which I assume we manage > via the same widget/component -> moving to 'ux' That's correct, this issue applies to all confirmation dialogs as it's related to RemoveConfirmationPopup{PresenterWidget|View} component. Looking at RemoveConfirmationPopupView.ui.xml - "items" panel (used to display list of items to remove) has "height:60%" and below this panel, there are some additional elements: - Approve Operation checkbox (invisible by default) - Force Remove checkbox (invisible by default) - red note label I guess we can remove "height:60%" restriction in order not to impose explicit height constraint on items panel. (In reply to vszocs from comment #8) > (In reply to Einav Cohen from comment #4) > > see attachment 752303 [details] - Remove DataCenter(s) dialog has that same > > unused space as well -> the problem is not only network-related - it applies > > probably to all confirmation dialogs in the system, which I assume we manage > > via the same widget/component -> moving to 'ux' > > That's correct, this issue applies to all confirmation dialogs as it's > related to > RemoveConfirmationPopup{PresenterWidget|View} component. > > Looking at RemoveConfirmationPopupView.ui.xml - "items" panel (used to > display list of items to remove) has "height:60%" and below this panel, > there are some additional elements: > - Approve Operation checkbox (invisible by default) > - Force Remove checkbox (invisible by default) > - red note label > > I guess we can remove "height:60%" restriction in order not to impose > explicit height constraint on items panel. Thanks for the clarification, Vojtech. [I am removing the "EasyFix" keyword for now] ideally, we would want to the dialog height to be set automatically, according to the visibility of the "extra" items (Approve Operation checkbox, Force Remove checkbox, red note label). @Vojtech - do you think that by removing the "height:60%" restriction, as you suggested, we will be able to accomplish that? > ideally, we would want to the dialog height to be set automatically,
> according to the visibility of the "extra" items (Approve Operation
> checkbox, Force Remove checkbox, red note label).
> @Vojtech - do you think that by removing the "height:60%" restriction, as
> you suggested, we will be able to accomplish that?
Assuming there are lots of items to be displayed in the confirm dialog:
- we can modify dialog content CSS -> dialog height is still fixed (400px) but the scrolling area will span the entire dialog content, i.e. "extra" elements will be part of the scrolling area
- after showing the dialog, to get rid of vertical scroll bar, we can try to calculate scrolling area height and resize dialog through code, or rely on auto-sizing of dialog content [needs some testing] [*]
[*] By default, all UI dialogs are shown using fixed dimensions.
*** Bug 1092586 has been marked as a duplicate of this bug. *** need to keep in mind also confirmation dialogs that contain check-boxes at the bottom (see duplicate bug 1092586 for example). Closing old bugs. |
Created attachment 752055 [details] screenshot 1 Description of problem: when user selects 20 VNICs on VM for removal, Remove Network Interfaces dialog displays much less VNIC names than it could, there is quite big empty space which could be used to display VNIC names, see screenshot Version-Release number of selected component (if applicable): Red Hat Enterprise Virtualization Manager Version: 3.2.0-11.28.el6ev How reproducible: 100% Steps to Reproduce: 1. have VM with 20VNICs 2. select all VNICs and click remove 3. Actual results: too short area which displays VNIC names (screenshot) Expected results: are for VNIC names should match the dialog size Additional info: