Red Hat Bugzilla – Bug 966535
oo-admin-cartridge usage pattern and actual usage mismatch: --cartridge_version/--cartridge-version
Last modified: 2015-05-14 19:19:42 EDT
Description of problem: The usage pattern that oo-admin-cartridge prints when I enter `oo-admin-cartridge -h` is inaccurate: it lists --cartridge-version (with a hyphen), but oo-admin-cartridge only recognises --cartridge_version (with an underscore). Version-Release number of selected component (if applicable): How reproducible: Entirely. Steps to Reproduce: 1. [root@node01 ~]# oo-admin-cartridge --help Usage: --action ACTION [--recursive] [--mco] [--source directory] [--name NAME - -version VERSION --cartridge-version VERSION] 2. [root@node01 ~]# oo-admin-cartridge --action erase --name php --version 5.3 --ca rtridge-version 0.0.1 /usr/sbin/oo-admin-cartridge:108:in `<main>': invalid option: --cartridge-versio n (OptionParser::InvalidOption) 3. [root@node01 ~]# oo-admin-cartridge --action erase --name php --version 5.3 --ca rtridge_version 0.0.1 succeeded Actual results: I got an error on step 2 where I followed the usage pattern that `oo-admin-cartridge -h` gave me. Expected results: Step 2 should have worked. Additional info: Looks like this defect has existed since the introduction of oo-admin-cartridge: https://github.com/calfonso/origin-server/commit/d868eef8f2f8ef649d014361e40937760063b5af
PR submitted to master.
Commit pushed to master at https://github.com/openshift/origin-server https://github.com/openshift/origin-server/commit/4e67591b6c166f5a39d352163c72be40139198b6 Bug 966535
verified on devenv_3605, issue can't be reproduced. [root@ip-10-167-13-167 cartridges]# oo-admin-cartridge --help Usage: --action ACTION [--recursive] [--mco] [--source directory] [--name NAME --version VERSION --cartridge_version VERSION] Options: -a, --action ACTION one of <install|list|erase> -s, --source path Directory of the cartridge to install --mco Issue action via mcollective agent -R, --recursive Source is assumed to point to a directory containing cartridge directories -l, --list List cartridges in repository -n, --name NAME Name of cartridge to erase -v, --version VERSION Version of packaged software to erase -c, --cartridge_version VERSION Version of cartridge to erase --offline ignored -d, --debug enable additional output [root@ip-10-167-13-167 cartridges]# oo-admin-cartridge --action erase --name zend --version 5.6 --cartridge_version 0.0.4 succeeded