Spec URL: http://cheeselee.fedorapeople.org/vmtouch.spec SRPM URL: http://cheeselee.fedorapeople.org/vmtouch-0.8.0-1.fc18.src.rpm Description: Vmtouch is a tool for learning about and controlling the file system cache of Unix and Unix-like systems. Fedora Account System Username: cheeselee
Hi Robin, I have few questions: 1) BuildRequires: /usr/bin/dos2unix BuildRequires: /usr/bin/mac2unix What about replace with: BuildRequires: dos2unix ? $ rpm -qf /usr/bin/dos2unix dos2unix-6.0.1-1.fc18.x86_64 $ rpm -qf /usr/bin/mac2unix dos2unix-6.0.1-1.fc18.x86_64 2) %build cc %{optflags} -o %{name} %{name}.c Why not "make %{?_smp_mflags}" ? https://fedoraproject.org/wiki/PackagingGuidelines#Parallel_make Thanks Douglas
(In reply to Douglas Schilling Landgraf from comment #1) > Hi Robin, > > I have few questions: > > 1) > BuildRequires: /usr/bin/dos2unix > BuildRequires: /usr/bin/mac2unix > > What about replace with: > > BuildRequires: dos2unix ? > > $ rpm -qf /usr/bin/dos2unix > dos2unix-6.0.1-1.fc18.x86_64 > $ rpm -qf /usr/bin/mac2unix > dos2unix-6.0.1-1.fc18.x86_64 What I actually use are the two commands, I don't have to care about what package that provides those commands. Yum would find out the package. > > 2) > %build > cc %{optflags} -o %{name} %{name}.c > > Why not "make %{?_smp_mflags}" ? > https://fedoraproject.org/wiki/PackagingGuidelines#Parallel_make Vmtouch is built from a single source file. And the upstream Makefile doesn't accept optflags setting. So I compile it directly with cc. > > Thanks > Douglas
Hi Robin, Thanks for your reply. Below my review. [OK] MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review. Rpmlint ------- Checking: vmtouch-0.8.0-1.fc18.x86_64.rpm vmtouch.x86_64: W: no-manual-page-for-binary watch-vmtouch 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint vmtouch vmtouch.x86_64: W: no-manual-page-for-binary watch-vmtouch 1 packages and 0 specfiles checked; 0 errors, 1 warnings. - There is no man page for watch-vmtouch. [OK] MUST: The package must be named according to the Package Naming Guidelines [OK] MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. [2] . [OK] MUST: The package must meet the Packaging Guidelines [OK] MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines [OK] MUST: The License field in the package spec file must match the actual license. [OK] MUST: The spec file must be written in American English. [OK] [OK] MUST: The spec file for the package MUST be legible [OK] [OK] MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use sha256sum for this task as it is used by the sources file once imported into git. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. CHECKSUM(SHA256) this package : 6848b9355451e8ab848501b5604f47a396bce1ef1dcb613577feaaaea1dfe262 CHECKSUM(SHA256) upstream package : 6848b9355451e8ab848501b5604f47a396bce1ef1dcb613577feaaaea1dfe262 [OK] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture [OK] MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. [OK] MUST: Packages must NOT bundle copies of system libraries [OK] MUST: A Fedora package must not list a file more than once in the spec file's %files listings. [OK] MUST: Each package must consistently use macros. [OK] MUST: The package must contain code, or permissable content. [OK] MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. [OK] MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built. [OK] MUST: All filenames in rpm packages must be valid UTF-8 [OK] SHOULD: Package functions as described. [OK] SHOULD: Latest version is packaged. [OK] SHOULD: Packager, Vendor, PreReq, Copyright tags should not be in spec file [OK] SHOULD: Sources can be downloaded from URI in Source: tag [OK] SHOULD: Reviewer should test that the package builds in mock. [OK] SHOULD: Buildroot is not present [OK] SHOULD: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [OK] SHOULD: Dist tag is present. [OK] SHOULD: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [OK] SHOULD: SourceX tarball generation or download is documented. [OK] SHOULD: SourceX is a working URL. [OK] SHOULD: Spec use %global instead of %define. Status: APPROVED
Thanks! New Package SCM Request ======================= Package Name: vmtouch Short Description: Portable file system cache diagnostics and control Owners: cheeselee Branches: f17 f18 f19 el6 InitialCC:
Git done (by process-git-requests).
vmtouch-0.8.0-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/vmtouch-0.8.0-1.fc17
vmtouch-0.8.0-1.fc17 has been pushed to the Fedora 17 testing repository.
vmtouch-0.8.0-1.fc17 has been pushed to the Fedora 17 stable repository.