Bug 967408 - z88dk includes non-free code
Summary: z88dk includes non-free code
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: z88dk
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kevin Kofler
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-Legal
TreeView+ depends on / blocked
 
Reported: 2013-05-27 04:39 UTC by mejiko
Modified: 2015-07-09 21:46 UTC (History)
2 users (show)

Fixed In Version: z88dk-1.10.1-8.20150709cvs.fc23
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-07-09 21:46:22 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Debian BTS 709520 0 None None None Never
GNU Savannah 39054 0 None None None Never

Description mejiko 2013-05-27 04:39:38 UTC
Hello.

SRC RPM is "z88dk-1.10.1-1.fc18.src.rpm"

z88dk included non free code. 
Please See Debian bug number "709520" details.

I think that this package be affected by debian bug number "709520". (I view and checked this source package)

Suggests:


1. Remove non-free code and rebuild.
2. Replace to Fedora free(acceptable licensed) file.
3. Remove Fedora repos.


Thanks.


Reference:

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=709520
https://savannah.nongnu.org/bugs/?func=detailitem&item_id=39054

Comment 1 mejiko 2013-05-27 04:40:37 UTC
Blocking FE-Legal, This is license problem.

Comment 2 Kevin Kofler 2013-05-27 13:10:31 UTC
Where's the report to upstream z88dk.org? (They have a bug tracker at SourceForge, a web-based forum and mailing lists, I don't see any report of this issue anywhere there.)

Comment 3 Tom "spot" Callaway 2013-05-28 14:59:44 UTC
Reported upstream here:
http://www.z88dk.org/forum/viewtopic.php?pid=8504

This is a valid issue.

Comment 4 Kevin Kofler 2013-05-28 15:25:26 UTC
I don't doubt that it's valid. If I had caught this during review, I'd have failed it instantly. Sadly, I was neither the submitter nor the reviewer, I only picked this thing up after it got orphaned.

I need to have a look at how easy it is to get rid of the offending files.

Comment 5 Kevin Kofler 2013-05-28 15:36:26 UTC
For the Z80 emulation core under test/machine, I can just zap the testsuite altogether. The specfile isn't running it in the first place, and it doesn't test all that much.

The ozcustomisr.asm issue is more annoying. The sledgehammer approach would be to nuke the whole OZ-7xx target. I think I'll wait a couple days for upstream to double-check with the author, if you're OK with that.

Comment 6 Tom "spot" Callaway 2013-05-29 12:46:13 UTC
Upstream is making good progress in the forum thread. We can wait to see if they can fix it entirely on their end before applying workarounds.

Comment 7 Kevin Kofler 2013-05-29 22:51:58 UTC
OK, agreed. I'll keep watching this, feel free to poke me if I forget. :-)

Comment 8 mejiko 2013-08-05 02:45:24 UTC
Fedora 19 version is not resolved this problem.

Comment 9 mejiko 2013-10-15 05:15:26 UTC
I see current upstream CVS, There non-free files is removed. 

http://z88dk.cvs.sourceforge.net/viewvc/z88dk/z88dk/test/machine/Z80/
http://z88dk.cvs.sourceforge.net/viewvc/z88dk/z88dk/libsrc/oz/ozinterrupt/

I suggests that upgrade current CVS version.

Thanks.

Comment 10 mejiko 2014-03-15 10:05:38 UTC
Changed to rawhide. 

Is this bug is resolved ?
How it this bug current status ?

Thanks.


Reference:

https://trisquel.info/en/issues/8717

Comment 11 Kevin Kofler 2015-02-22 00:31:26 UTC
The issue is resolved in upstream CVS HEAD, but there has been no release with the fix.

Comment 12 Jaroslav Reznik 2015-03-03 14:57:10 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 22 development cycle.
Changing version to '22'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora22

Comment 13 Kevin Kofler 2015-07-09 21:46:22 UTC
The offending files are gone in the current upstream snapshot that I built for Rawhide.


Note You need to log in before you can comment on or make changes to this bug.