Hide Forgot
Created attachment 753659 [details] keepalived-1.2.7-add-smtp-email-to-header.patch Description of problem: keepalived vrrp alert emails are missing to-header, so the "To" field is empty in email programs, which makes filtering/sorting email harder. I've written a patch to implement the missing to-header, see: Email post to keepalived-devel mailinglist: http://sourceforge.net/mailarchive/message.php?msg_id=29897449 patch (also added to this bz as an attachment): http://sourceforge.net/mailarchive/attachment.php?list_name=keepalived-devel&message_id=20120928122744.GR8912%40reaktio.net&counter=1 It'd be nice to get that patch included in rhel6 keepalived rpm! Version-Release number of selected component (if applicable): keepalived-1.2.7-3
Is there an upstream pull request for this patch? I didn't see one. I think this patch will need to be rebased for it to apply to master branch.
Patch submission to keepalived-devel: http://marc.info/?l=keepalived-devel&m=134883532417448&w=2 "I will merge your patch in next release": http://marc.info/?l=keepalived-devel&m=135023180526573&w=2 If it doesn't apply anymore, sure, I can rebase and resend..
(In reply to Pasi Karkkainen from comment #2) > Patch submission to keepalived-devel: > http://marc.info/?l=keepalived-devel&m=134883532417448&w=2 Right. I was curious if there was a pull request on github. I don't see one, so what I will do is take your patch and put it in my devel branch on github. I have an outstanding pull request with several patches there already. > "I will merge your patch in next release": > http://marc.info/?l=keepalived-devel&m=135023180526573&w=2 > > > If it doesn't apply anymore, sure, I can rebase and resend.. I see what happened. I think your patch is based on v1.27, which is the latest release, but HEAD of master branch has some cosmetic changes that causes your patch to no apply. I'll fix it to apply to HEAD to make merging upstream easier.
That's correct, my patch is/was on top of v1.2.7. And yes, feel free to rework the patch and put it to your devel branch and send for upstreaming merging! Thanks a lot!
My patch is now included in the recently released upstream keepalived v1.2.8. Thanks!
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHBA-2014-1510.html