Spec URL: http://www.matthias-runge.de/fedora/python-testresources.spec SRPM URL: http://www.matthias-runge.de/fedora/python-testresources-0.2.7-1.fc19.src.rpm Description: testresources: extensions to python unittest to allow declarative use of resources by test cases. Fedora Account System Username: mrunge scratchbuild: http://koji.fedoraproject.org/koji/taskinfo?taskID=5437523
The upstream egg is in the "lib" subfolder, that's why remove it as follows: rm -rf lib/%{pypi_name}.egg-info Please add NEWS to %doc. Perhaps example.py from the "doc" subfolder should be added there, too.
Thank you, Mario. Updated SPEC: http://www.matthias-runge.de/fedora/python-testresources.spec SRPM: http://www.matthias-runge.de/fedora/python-testresources-0.2.7-2.fc19.src.rpm
Based on information here [0], it also supports Python 3. What about a Python 3 subpackage? [0] https://pypi.python.org/pypi/testresources
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== Issues ===== Must: testresources/tests/TestUtil.py license Should: Python 3 subpackage ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [!]: License field in the package spec file matches the actual license. testresources/tests/TestUtil.py is GPLv2+! It also has incorrect FSF address [!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Note: Documentation size is 30720 bytes in 3 files. [x]: Package complies to the Packaging Guidelines Except the license thing above [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [-]: Fully versioned dependency in subpackages if applicable. [-]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [-]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python-testresources-0.2.7-2.fc18.noarch.rpm python-testresources.noarch: W: spelling-error Summary(en_US) pyunit -> impunity python-testresources.noarch: W: spelling-error %description -l en_US unittest -> unit test, unit-test, unities python-testresources.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/testresources/tests/TestUtil.py 1 packages and 0 specfiles checked; 1 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint python-testresources python-testresources.noarch: W: spelling-error Summary(en_US) pyunit -> impunity python-testresources.noarch: W: spelling-error %description -l en_US unittest -> unit test, unit-test, unities python-testresources.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/testresources/tests/TestUtil.py 1 packages and 0 specfiles checked; 1 errors, 2 warnings. # echo 'rpmlint-done:' Requires -------- python-testresources (rpmlib, GLIBC filtered): python(abi) Provides -------- python-testresources: python-testresources Source checksums ---------------- https://pypi.python.org/packages/source/t/testresources/testresources-0.2.7.tar.gz : CHECKSUM(SHA256) this package : ad0a117383dd463827b199eaa92829b4d6a3147fbd97459820df53bae81d7231 CHECKSUM(SHA256) upstream package : ad0a117383dd463827b199eaa92829b4d6a3147fbd97459820df53bae81d7231 Generated by fedora-review 0.4.0 (eaf16cd) last change: 2013-05-30 Buildroot used: fedora-18-x86_64 Command line :./try-fedora-review -b 968229 Files and permissions --------------------- $ rpm -qlvp ./python-testresources-0.2.7-2.fc18.noarch.rpm drwxr-xr-x 2 root root 0 kvě 31 13:02 /usr/lib/python2.7/site-packages/testresources drwxr-xr-x 2 root root 0 kvě 31 13:02 /usr/lib/python2.7/site-packages/testresources-0.2.7-py2.7.egg-info -rw-r--r-- 1 root root 12752 kvě 31 13:02 /usr/lib/python2.7/site-packages/testresources-0.2.7-py2.7.egg-info/PKG-INFO -rw-r--r-- 1 root root 566 kvě 31 13:02 /usr/lib/python2.7/site-packages/testresources-0.2.7-py2.7.egg-info/SOURCES.txt -rw-r--r-- 1 root root 1 kvě 31 13:02 /usr/lib/python2.7/site-packages/testresources-0.2.7-py2.7.egg-info/dependency_links.txt -rw-r--r-- 1 root root 14 kvě 31 13:02 /usr/lib/python2.7/site-packages/testresources-0.2.7-py2.7.egg-info/top_level.txt -rw-r--r-- 1 root root 32367 led 20 12:59 /usr/lib/python2.7/site-packages/testresources/__init__.py -rw-r--r-- 1 root root 29643 kvě 31 13:02 /usr/lib/python2.7/site-packages/testresources/__init__.pyc -rw-r--r-- 1 root root 29595 kvě 31 13:02 /usr/lib/python2.7/site-packages/testresources/__init__.pyo drwxr-xr-x 2 root root 0 kvě 31 13:02 /usr/lib/python2.7/site-packages/testresources/tests -rw-r--r-- 1 root root 2882 led 19 22:58 /usr/lib/python2.7/site-packages/testresources/tests/TestUtil.py -rw-r--r-- 2 root root 3632 kvě 31 13:02 /usr/lib/python2.7/site-packages/testresources/tests/TestUtil.pyc -rw-r--r-- 2 root root 3632 kvě 31 13:02 /usr/lib/python2.7/site-packages/testresources/tests/TestUtil.pyo -rw-r--r-- 1 root root 2496 led 20 12:57 /usr/lib/python2.7/site-packages/testresources/tests/__init__.py -rw-r--r-- 2 root root 3306 kvě 31 13:02 /usr/lib/python2.7/site-packages/testresources/tests/__init__.pyc -rw-r--r-- 2 root root 3306 kvě 31 13:02 /usr/lib/python2.7/site-packages/testresources/tests/__init__.pyo -rw-r--r-- 1 root root 28383 kvě 4 2011 /usr/lib/python2.7/site-packages/testresources/tests/test_optimising_test_suite.py -rw-r--r-- 2 root root 28236 kvě 31 13:02 /usr/lib/python2.7/site-packages/testresources/tests/test_optimising_test_suite.pyc -rw-r--r-- 2 root root 28236 kvě 31 13:02 /usr/lib/python2.7/site-packages/testresources/tests/test_optimising_test_suite.pyo -rw-r--r-- 1 root root 4890 led 19 23:04 /usr/lib/python2.7/site-packages/testresources/tests/test_resource_graph.py -rw-r--r-- 2 root root 5028 kvě 31 13:02 /usr/lib/python2.7/site-packages/testresources/tests/test_resource_graph.pyc -rw-r--r-- 2 root root 5028 kvě 31 13:02 /usr/lib/python2.7/site-packages/testresources/tests/test_resource_graph.pyo -rw-r--r-- 1 root root 6618 kvě 5 2011 /usr/lib/python2.7/site-packages/testresources/tests/test_resourced_test_case.py -rw-r--r-- 2 root root 8757 kvě 31 13:02 /usr/lib/python2.7/site-packages/testresources/tests/test_resourced_test_case.pyc -rw-r--r-- 2 root root 8757 kvě 31 13:02 /usr/lib/python2.7/site-packages/testresources/tests/test_resourced_test_case.pyo -rw-r--r-- 1 root root 1324 úno 26 2010 /usr/lib/python2.7/site-packages/testresources/tests/test_test_loader.py -rw-r--r-- 2 root root 1133 kvě 31 13:02 /usr/lib/python2.7/site-packages/testresources/tests/test_test_loader.pyc -rw-r--r-- 2 root root 1133 kvě 31 13:02 /usr/lib/python2.7/site-packages/testresources/tests/test_test_loader.pyo -rw-r--r-- 1 root root 20686 led 20 12:59 /usr/lib/python2.7/site-packages/testresources/tests/test_test_resource.py -rw-r--r-- 2 root root 24428 kvě 31 13:02 /usr/lib/python2.7/site-packages/testresources/tests/test_test_resource.pyc -rw-r--r-- 2 root root 24428 kvě 31 13:02 /usr/lib/python2.7/site-packages/testresources/tests/test_test_resource.pyo drwxr-xr-x 2 root root 0 kvě 31 13:02 /usr/share/doc/python-testresources-0.2.7 -rw-r--r-- 1 root root 6033 led 20 13:02 /usr/share/doc/python-testresources-0.2.7/NEWS -rw-r--r-- 1 root root 9898 led 20 12:58 /usr/share/doc/python-testresources-0.2.7/README drwxr-xr-x 2 root root 0 led 20 13:05 /usr/share/doc/python-testresources-0.2.7/doc -rw-r--r-- 1 root root 1428 úno 26 2010 /usr/share/doc/python-testresources-0.2.7/doc/example.py
Thank you for the review! wrong fsf-address: http://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address, I'll notify upstream Regarding py3 package: I'm working on it https://bugzilla.redhat.com/show_bug.cgi?id=969413 Updated SPEC: http://www.matthias-runge.de/fedora/python-testresources.spec SRPM: http://www.matthias-runge.de/fedora/python-testresources-0.2.7-3.fc19.src.rpm
Package APPROVED.
New Package SCM Request ======================= Package Name: python-testresources Short Description: Testresources, a pyunit extension for managing expensive test resources Owners: mrunge Branches: f19 el6
Git done (by process-git-requests).
python-testresources-0.2.7-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-testresources-0.2.7-3.fc19
python-testresources-0.2.7-3.fc19 has been pushed to the Fedora 19 testing repository.
python-testresources-0.2.7-3.fc19 has been pushed to the Fedora 19 stable repository.
Package Change Request ====================== Package Name: python-testresources New Branches: epel7 Owners: mrunge apevec