Description of problem: Please refactor following unnecessary while loop: " while (answer.hasMoreElements()) { // Print the objectGUID for the user as well as URI and query path String guid = guidFromResults(answer.next()); if (guid == null) { break; } userGuid.append(guid); logQueryContext(userGuid.toString(), uri.toString(), currentLdapServer); return AuthenticationResult.OK; } " In any case this loop runs only once so the problem solved by it can be replaced by "if" decission statement. Version-Release number of selected component (if applicable): Any
Proposed patch: if (answer.hasMoreElements()) { String guid = guidFromResults(answer.next()); if (guid != null) { userGuid.append(guid); logQueryContext(userGuid.toString(), uri.toString(), currentLdapServer); return AuthenticationResult.OK; } } Where logQueryContext procedure got added by http://gerrit.ovirt.org/#/c/15176/ to replace current weak logging options.
Propsed patch in gerrit: http://gerrit.ovirt.org/15217/
as RC is built, moving to ON_QA (hopefully did not catch incorrect bugs when doing this)
closing as this should be in 3.3 (doing so in bulk, so may be incorrect)