Spec URL: http://echevemaster.fedorapeople.org/libappindicator/1/libindicator.spec SRPM URL: http://echevemaster.fedorapeople.org/libappindicator/1/libappindicator-12.10.0-1.fc18.src.rpm Description: A library to allow applications to export a menu into the Unity Menu bar. Based on KSNI it also works in KDE and will fallback to generic Systray support if none of those are available. FAS: echevemaster Tested on koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=5447269
I'm sorry, wrong spec this is the correct: SPEC URL: http://echevemaster.fedorapeople.org/libappindicator/1/libappindicator.spec SRPM URL: http://echevemaster.fedorapeople.org/libappindicator/1/libappindicator-12.10.0-1.fc18.src.rpm
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [-]: Package does not contain kernel modules. [-]: Package contains no static executables. [-]: Development (unversioned) .so files in -devel subpackage, if present. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: %build honors applicable compiler flags or justifies otherwise. [-]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [-]: Package requires other packages for directories it uses. [-]: Package uses nothing in %doc for runtime. [-]: Package is not known to require ExcludeArch. [x]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python- appindicator , libappindicator-devel , libappindicator-gtk3 , libappindicator-gtk3-devel , libappindicator-docs , libappindicator-sharp , libappindicator-sharp-devel [x]: Package complies to the Packaging Guidelines [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [-]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [-]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [-]: Large documentation must go in a -doc subpackage. Note: Documentation size is 122880 bytes in 12 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Python: [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: Uses parallel make. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [-]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [-]: Package does not include license text files separate from upstream. [-]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: libappindicator-12.10.0-1.fc20.x86_64.rpm python-appindicator-12.10.0-1.fc20.x86_64.rpm libappindicator-devel-12.10.0-1.fc20.x86_64.rpm libappindicator-gtk3-12.10.0-1.fc20.x86_64.rpm libappindicator-gtk3-devel-12.10.0-1.fc20.x86_64.rpm libappindicator-docs-12.10.0-1.fc20.noarch.rpm libappindicator-sharp-12.10.0-1.fc20.x86_64.rpm libappindicator-sharp-devel-12.10.0-1.fc20.x86_64.rpm python-appindicator.x86_64: W: private-shared-object-provides /usr/lib64/python2.7/site-packages/appindicator/_appindicator.so _appindicator.so()(64bit) python-appindicator.x86_64: W: no-documentation libappindicator-devel.x86_64: W: spelling-error %description -l en_US appindicator -> app indicator, app-indicator, indicator libappindicator-devel.x86_64: W: no-documentation libappindicator-gtk3-devel.x86_64: W: spelling-error %description -l en_US appindicator -> app indicator, app-indicator, indicator libappindicator-gtk3-devel.x86_64: W: no-documentation libappindicator-docs.noarch: W: spelling-error %description -l en_US appindicator -> app indicator, app-indicator, indicator libappindicator-sharp.x86_64: W: only-non-binary-in-usr-lib libappindicator-sharp-devel.x86_64: W: spelling-error %description -l en_US appindicator -> app indicator, app-indicator, indicator libappindicator-sharp-devel.x86_64: W: no-documentation 8 packages and 0 specfiles checked; 0 errors, 10 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint libappindicator-devel libappindicator-gtk3-devel python-appindicator libappindicator-sharp-devel libappind icator-sharp libappindicator libappindicator-gtk3 libappindicator-docs libappindicator-devel.x86_64: W: spelling-error %description -l en_US appindicator -> app indicator, app-indicator, indicator libappindicator-devel.x86_64: W: no-documentation libappindicator-gtk3-devel.x86_64: W: spelling-error %description -l en_US appindicator -> app indicator, app-indicator, indicator libappindicator-gtk3-devel.x86_64: W: no-documentation python-appindicator.x86_64: W: private-shared-object-provides /usr/lib64/python2.7/site-packages/appindicator/_appindicator.so _appindicator.so()(64bit) python-appindicator.x86_64: W: no-documentation libappindicator-sharp-devel.x86_64: W: spelling-error %description -l en_US appindicator -> app indicator, app-indicator, indicator libappindicator-sharp-devel.x86_64: W: no-documentation libappindicator-sharp.x86_64: W: only-non-binary-in-usr-lib libappindicator.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libappindicator.so.1.0.0 /lib64/libgdk-x11-2.0.so.0 libappindicator.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libappindicator.so.1.0.0 /lib64/libpangocairo-1.0.so.0 libappindicator.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libappindicator.so.1.0.0 /lib64/libatk-1.0.so.0 libappindicator.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libappindicator.so.1.0.0 /lib64/libcairo.so.2 libappindicator.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libappindicator.so.1.0.0 /lib64/libgdk_pixbuf-2.0.so.0 libappindicator.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libappindicator.so.1.0.0 /lib64/libpangoft2-1.0.so.0 libappindicator.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libappindicator.so.1.0.0 /lib64/libpango-1.0.so.0 libappindicator.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libappindicator.so.1.0.0 /lib64/libfreetype.so.6 libappindicator.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libappindicator.so.1.0.0 /lib64/libfontconfig.so.1 libappindicator.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libappindicator.so.1.0.0 /lib64/libpthread.so.0 libappindicator-gtk3.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libappindicator3.so.1.0.0 /lib64/libgdk-3.so.0 libappindicator-gtk3.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libappindicator3.so.1.0.0 /lib64/libpangocairo-1.0.so.0 libappindicator-gtk3.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libappindicator3.so.1.0.0 /lib64/libpango-1.0.so.0 libappindicator-gtk3.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libappindicator3.so.1.0.0 /lib64/libatk-1.0.so.0 libappindicator-gtk3.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libappindicator3.so.1.0.0 /lib64/libcairo-gobject.so.2 libappindicator-gtk3.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libappindicator3.so.1.0.0 /lib64/libcairo.so.2 libappindicator-gtk3.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libappindicator3.so.1.0.0 /lib64/libgdk_pixbuf-2.0.so.0 libappindicator-gtk3.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libappindicator3.so.1.0.0 /lib64/libpthread.so.0 libappindicator-docs.noarch: W: spelling-error %description -l en_US appindicator -> app indicator, app-indicator, indicator 8 packages and 0 specfiles checked; 0 errors, 28 warnings. # echo 'rpmlint-done:' Requires -------- libappindicator-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config dbus-glib-devel libappindicator libappindicator.so.1()(64bit) libdbusmenu-devel pkgconfig(dbusmenu-glib-0.4) pkgconfig(gtk+-2.0) libappindicator-gtk3-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config dbus-glib-devel libappindicator-gtk3 libappindicator3.so.1()(64bit) libdbusmenu-devel pkgconfig(dbusmenu-glib-0.4) pkgconfig(gtk+-3.0) python-appindicator (rpmlib, GLIBC filtered): libappindicator libappindicator.so.1()(64bit) libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libdbusmenu-glib.so.4()(64bit) libdbusmenu-gtk.so.4()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libindicator.so.7()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) libpthread.so.0()(64bit) python(abi) rtld(GNU_HASH) libappindicator-sharp-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libappindicator-sharp pkgconfig(gtk-sharp-2.0) libappindicator-sharp (rpmlib, GLIBC filtered): mono(gdk-sharp) mono(glib-sharp) mono(gtk-sharp) mono(mscorlib) libappindicator (rpmlib, GLIBC filtered): /sbin/ldconfig libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libdbusmenu-glib.so.4()(64bit) libdbusmenu-gtk.so.4()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libindicator.so.7()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) libappindicator-gtk3 (rpmlib, GLIBC filtered): /sbin/ldconfig libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libcairo-gobject.so.2()(64bit) libcairo.so.2()(64bit) libdbusmenu-glib.so.4()(64bit) libdbusmenu-gtk3.so.4()(64bit) libgdk-3.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-3.so.0()(64bit) libindicator3.so.7()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) libappindicator-docs (rpmlib, GLIBC filtered): Provides -------- libappindicator-devel: libappindicator-devel libappindicator-devel(x86-64) pkgconfig(appindicator-0.1) libappindicator-gtk3-devel: libappindicator-gtk3-devel libappindicator-gtk3-devel(x86-64) pkgconfig(appindicator3-0.1) python-appindicator: _appindicator.so()(64bit) python-appindicator python-appindicator(x86-64) libappindicator-sharp-devel: libappindicator-sharp-devel libappindicator-sharp-devel(x86-64) pkgconfig(appindicator-sharp-0.1) libappindicator-sharp: libappindicator-sharp libappindicator-sharp(x86-64) mono(appindicator-sharp) mono(policy.0.0.appindicator-sharp) mono(policy.0.1.appindicator-sharp) libappindicator: libappindicator libappindicator(x86-64) libappindicator.so.1()(64bit) libappindicator-gtk3: libappindicator-gtk3 libappindicator-gtk3(x86-64) libappindicator3.so.1()(64bit) libappindicator-docs: libappindicator-docs Unversioned so-files -------------------- python-appindicator: /usr/lib64/python2.7/site-packages/appindicator/_appindicator.so ---------------- PACKAGE APPROVED ----------------
Thanks yohan, New Package SCM Request ======================= Package Name: libappindicator Short Description: Application indicators library Owners: echevemaster Branches: f17 f18 f19 InitialCC:
Git done (by process-git-requests).
libappindicator-12.10.0-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/libappindicator-12.10.0-2.fc18
libappindicator-12.10.0-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/libappindicator-12.10.0-2.fc17
libappindicator-12.10.0-2.fc18 has been pushed to the Fedora 18 testing repository.
libappindicator-12.10.0-2.fc18 has been pushed to the Fedora 18 stable repository.
Package Change Request ====================== Package Name: libappindicator New Branches: epel7 Owners: slaanesh
Comments from the primary maintainers?