This patch: http://git.jdl.com/gitweb/?p=dtc.git;a=commitdiff;h=8716901d2215a314504b7df6282aedfcf89da1ea modified libfdt to install libfdt_env.h. Other distros already do so. Please make the same change to the Fedora package. (libfdt_env.h is customizable, but the default version should be good enough for userspace applications and is meant to be placed in /usr/include).
Fixed. libfdt_env.h is included in the libfdt-devel subpackage with 1.3.0-7.
Josh, thanks for updating dtc! I backported that single patch to the el6 branch (commit 602419e4). Any chance of having that in f19 too?
dtc-1.3.0-6.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/dtc-1.3.0-6.el6
(In reply to Paolo Bonzini from comment #2) > Josh, > > thanks for updating dtc! I backported that single patch to the el6 branch > (commit 602419e4). Any chance of having that in f19 too? Yes. I'll build and submit an update later today.
dtc-1.3.0-7.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/dtc-1.3.0-7.fc19
So with this update I can't get qemu.git to build. Bunch of errors like: In file included from /usr/include/libfdt.h:55:0, from /home/crobinso/src/qemu/device_tree.c:28: /usr/include/fdt.h:58:2: error: unknown type name ‘fdt32_t’ fdt32_t magic; /* magic word FDT_MAGIC */ ^ /usr/include/fdt.h:59:2: error: unknown type name ‘fdt32_t’ fdt32_t totalsize; /* total size of DT block */ Paolo, do you know what's going on? I assume this bz was motivated by something qemu related.
Here's a full build log: http://kojipkgs.fedoraproject.org//work/tasks/3832/5493832/build.log Reopening, though maybe this is just a qemu issue.
The types it's complaining about are clearly defined in libfdt_env.h from libfdt-devel: typedef uint16_t __bitwise fdt16_t; typedef uint32_t __bitwise fdt32_t; typedef uint64_t __bitwise fdt64_t; /usr/include/libfdt.h includes libfdt_env.h before it includes fdt.h: #include <libfdt_env.h> #include <fdt.h> I noticed qemu-1.5.0 seems to include it's own copy of dtc. Then I looked in the include/ directory and saw that it also has it's own copy of libfdt_env.h. That copy is stale and doesn't have the above defines. I'm guessing because of all the crazy -I switches being passed, the compiler is picking up qemu-1.5.0/include/libfdt_env.h and not the one provided by libfdt-devel. If you add a patch to qemu to delete that file, does it build?
(In reply to Josh Boyer from comment #8) > The types it's complaining about are clearly defined in libfdt_env.h from > libfdt-devel: > > typedef uint16_t __bitwise fdt16_t; > typedef uint32_t __bitwise fdt32_t; > typedef uint64_t __bitwise fdt64_t; > > /usr/include/libfdt.h includes libfdt_env.h before it includes fdt.h: > > #include <libfdt_env.h> > #include <fdt.h> > > > I noticed qemu-1.5.0 seems to include it's own copy of dtc. Then I looked > in the include/ directory and saw that it also has it's own copy of > libfdt_env.h. That copy is stale and doesn't have the above defines. > > I'm guessing because of all the crazy -I switches being passed, the compiler > is picking up qemu-1.5.0/include/libfdt_env.h and not the one provided by > libfdt-devel. If you add a patch to qemu to delete that file, does it build? I answered my own question. The answer seems to be yes: http://koji.fedoraproject.org/koji/taskinfo?taskID=5495943
Thanks Josh, reclosing.
dtc-1.3.0-8.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.
dtc-1.3.0-6.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.