Bug 970194 - Tests hang when own-thread is set
Summary: Tests hang when own-thread is set
Alias: None
Product: GlusterFS
Classification: Community
Component: transport (Show other bugs)
(Show other bugs)
Version: mainline
Hardware: Unspecified Unspecified
Target Milestone: ---
Assignee: Jeff Darcy
QA Contact:
Depends On:
TreeView+ depends on / blocked
Reported: 2013-06-03 16:15 UTC by Jeff Darcy
Modified: 2014-04-17 11:42 UTC (History)
2 users (show)

Fixed In Version: glusterfs-3.5.0
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2014-04-17 11:42:42 UTC
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)
Log files of failures for './tests/bugs/bug-857330/normal.t' and './tests/bugs/bug-884455.t' (1.82 KB, application/x-gzip)
2013-06-05 16:34 UTC, John Smith
no flags Details

Description Jeff Darcy 2013-06-03 16:15:01 UTC
Reported via list email:

cat /usr/lib*/glusterfs/$VERSION/filter/multi-thread.sh
sed -i 's/.*type protocol.*/&\n    option transport.socket.own-thread on/' $1

and do './run-tests'. tests that otherwise succeed either fail or hang.

Comment 1 Anand Avati 2013-06-03 16:16:29 UTC
REVIEW: http://review.gluster.org/5137 (transport/socket: fix connect/disconnect races) posted (#1) for review on master by Jeff Darcy (jdarcy@redhat.com)

Comment 2 Anand Avati 2013-06-04 21:12:21 UTC
REVIEW: http://review.gluster.org/5137 (transport/socket: fix connect/disconnect races) posted (#2) for review on master by Jeff Darcy (jdarcy@redhat.com)

Comment 3 Anand Avati 2013-06-04 22:38:27 UTC
COMMIT: http://review.gluster.org/5137 committed in master by Anand Avati (avati@redhat.com) 
commit 5c1710ed60ccb151ccd7a2890b24bb99518d36da
Author: Jeff Darcy <jdarcy@redhat.com>
Date:   Tue Jun 4 15:20:45 2013 -0400

    transport/socket: fix connect/disconnect races
    We might receive a connect request while a disconnect is still in
    progress, requiring more states and (the return of) poller generation
    numbers to avoid redundant pollers.  We might also get either kind of
    request from within our own rpc_transport_notify upcall, so we have to
    avoid locking and use the PLEASE_DIE state instead.
    Change-Id: Icbaacf96c516b607a79ff62c90b74d42b241780f
    BUG: 970194
    Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
    Reviewed-on: http://review.gluster.org/5137
    Tested-by: Gluster Build System <jenkins@build.gluster.com>
    Reviewed-by: Anand Avati <avati@redhat.com>

Comment 4 John Smith 2013-06-05 16:32:33 UTC
Thanks to the commit above, the 'prove' tests no longer hang for me when setting 'option transport.socket.own-thread on' in the .vol files.

However, now I am getting (intermittent) failues of these tests when own-thread is set :


normal.t often completes without errors, and when it does fail it doesnt always fail at exactly the same sub-tests. I included the output of 2 different runs of the same test to show this. One run fails at TEST 13, and one run doesnt. I havent figured out a way to make the test fail 100% of the time. The test 'bug-884455.t' always fails for me when setting 'own-thread' on. Both tests succeed without error for the same git revision when 'own-thread' is not set in the .vol files.

Comment 5 John Smith 2013-06-05 16:34:09 UTC
Created attachment 757277 [details]
Log files of failures for './tests/bugs/bug-857330/normal.t' and './tests/bugs/bug-884455.t'

Comment 6 Niels de Vos 2014-04-17 11:42:42 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.5.0, please reopen this bug report.

glusterfs-3.5.0 has been announced on the Gluster Developers mailinglist [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/6137
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Note You need to log in before you can comment on or make changes to this bug.