Red Hat Bugzilla – Bug 970194
Tests hang when own-thread is set
Last modified: 2014-04-17 07:42:42 EDT
Reported via list email:
sed -i 's/.*type protocol.*/&\n option transport.socket.own-thread on/' $1
and do './run-tests'. tests that otherwise succeed either fail or hang.
REVIEW: http://review.gluster.org/5137 (transport/socket: fix connect/disconnect races) posted (#1) for review on master by Jeff Darcy (email@example.com)
REVIEW: http://review.gluster.org/5137 (transport/socket: fix connect/disconnect races) posted (#2) for review on master by Jeff Darcy (firstname.lastname@example.org)
COMMIT: http://review.gluster.org/5137 committed in master by Anand Avati (email@example.com)
Author: Jeff Darcy <firstname.lastname@example.org>
Date: Tue Jun 4 15:20:45 2013 -0400
transport/socket: fix connect/disconnect races
We might receive a connect request while a disconnect is still in
progress, requiring more states and (the return of) poller generation
numbers to avoid redundant pollers. We might also get either kind of
request from within our own rpc_transport_notify upcall, so we have to
avoid locking and use the PLEASE_DIE state instead.
Signed-off-by: Jeff Darcy <email@example.com>
Tested-by: Gluster Build System <firstname.lastname@example.org>
Reviewed-by: Anand Avati <email@example.com>
Thanks to the commit above, the 'prove' tests no longer hang for me when setting 'option transport.socket.own-thread on' in the .vol files.
However, now I am getting (intermittent) failues of these tests when own-thread is set :
normal.t often completes without errors, and when it does fail it doesnt always fail at exactly the same sub-tests. I included the output of 2 different runs of the same test to show this. One run fails at TEST 13, and one run doesnt. I havent figured out a way to make the test fail 100% of the time. The test 'bug-884455.t' always fails for me when setting 'own-thread' on. Both tests succeed without error for the same git revision when 'own-thread' is not set in the .vol files.
Created attachment 757277 [details]
Log files of failures for './tests/bugs/bug-857330/normal.t' and './tests/bugs/bug-884455.t'
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.5.0, please reopen this bug report.
glusterfs-3.5.0 has been announced on the Gluster Developers mailinglist , packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist  and the update infrastructure for your distribution.